[IMP] dashboards: various updates for 19.0 #14800
Closed
+256
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
auva-odoo
requested changes
Oct 14, 2025
There was a problem hiding this comment.
Thank you for your work @mcsi-odoo, I learned a lot 🙂 In addition to my review comments:
- I'm not sure about using the word page in this context (for the whole doc page); we usually try avoiding it to refer to Odoo's UI.
- I'd change the heading on line 401 in dashboards.rst to be consistent with the other headings in that section (which use the -ing form); I'd also say Sharing a dashboard snapshot?
Feel free to reach out if there's anything you'd like to discuss!
Comment on lines
220
to
224
| for five days, and the current position of the slider allows data from the last five days to be | ||
| shown. | ||
|
|
||
| .. image:: dashboards/navigate-charts.png | ||
| :alt: Zoomed-in chart with slider |
There was a problem hiding this comment.
Since this is the default position of the slider when you have zoomed in, I think it might be more helpful to show the slider in a different place (and adjust the text to reflect that)
Comment on lines
+228
to
+240
| Standard dashboards | ||
| =================== |
There was a problem hiding this comment.
I kinda want to suggest that this be moved to the top of the doc page, before Use dashboards because this is probably where users are going to start, right? They're going to see some (standard) dashboards in the app and then play with (use) them?
task-5149303
mcsi-odoo
force-pushed
the
19.0-dashboards-various-updates-mcsi
branch
from
6f43d2c to
95f80c9
Compare
auva-odoo
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-5149303