-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[IMP] Luxembourg: update localization page #14880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
Hi @dade-odoo I'd love to have an informal chat about this task before we move on to a more formal review, but wanted to already create the PR just so I can see the CI results. 😄 |
1e6ec12
to
22e6c23
Compare
@dade-odoo I think this is all ready for a more formal review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @antoine162 , thanks for a great first doc PR (as part of the content team)!
Because you're still getting used to our writing guidelines (and of course there are some that aren't explicitly spelled out on the guidelines page), I've been pretty nit-picky, but I've tried to give explanations behind them all. Please let me know if you have any questions about them - I'm happy to talk about it all.
Overall you did a great job improving this doc, and I'm sure users of the Luxembourgish localization will appreciate the update.
content/applications/finance/fiscal_localizations/luxembourg.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/fiscal_localizations/luxembourg.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/fiscal_localizations/luxembourg.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/fiscal_localizations/luxembourg.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/fiscal_localizations/luxembourg.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/fiscal_localizations/luxembourg.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/fiscal_localizations/luxembourg.rst
Outdated
Show resolved
Hide resolved
.. note:: The Annual VAT declaration comes populated with the amounts for the | ||
**simplified annual declaration**. The fields for the **complete annual declaration** are | ||
available to be manually filled in if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What fields are required for the complete annual declaration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into this a bit further, and I think Odoo doesn't actually handle exporting the "simplified annual declaration".
The simplified annual declaration is for companies with a turnover of under €30,000 which are exempt from the VAT regime, so they don't collect or deduct VAT. These companies can fill in their simplified annual declaration directly on the eCDF website, but we don't handle exporting a simplified annual declaration as an XML.
However, the annual declaration generated by Odoo isn't complete in that it doesn't precisely indicate VAT debit amounts for each type of sale (e.g. VAT collected for sales of in-house manufactured goods, versus sales of goods not manufactured in-house). Odoo can't fill these sections precisely because it doesn't have knowledge of that information, so the user needs to manually distribute the total VAT debit for the year among those categories.
I've tried to explain this in the doc, and I would appreciate if you can take another look at it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ask OLMA when he's back if this is supposed to be distributed manually as you explained or if any of it should happen automatically.
Mention editing report lines instead of "each category". I'm not opposed to keeping the first instance of "sales categories" but I think replacing at least "each category" with "each report line" would make it more clear to the user where they're supposed to enter the amounts.
content/applications/finance/fiscal_localizations/luxembourg.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/fiscal_localizations/luxembourg.rst
Outdated
Show resolved
Hide resolved
22e6c23
to
79f944a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing to change as we wait for OLMA to get back :) great work @antoine162 !
task-4559158 - Don't mention module `l10n_lu_reports_annual_vat` that was merged into `l10n_lu_reports` in saas-15.4 - Add brief sections for taxes and for e-invoicing via Peppol - Simplify the monthly and annual VAT declaration sections (both have an XML export for upload to the eCDF platform)
79f944a
to
28f1418
Compare
task-4559158
l10n_lu_reports_annual_vat
that was merged intol10n_lu_reports
in saas-15.4