Skip to content

Conversation

@oomsveta
Copy link
Contributor

@oomsveta oomsveta commented Oct 22, 2025

@robodoo
Copy link
Collaborator

robodoo commented Oct 22, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 22, 2025 12:20
@oomsveta oomsveta force-pushed the master-remove_voip_onsip-wil branch from 05d2e39 to 8fe7afb Compare October 24, 2025 14:25
@Felicious
Copy link
Contributor

Appreciate you for keeping the documentation updated with your code change, @oomsveta !

For context, @jero-odoo, the OnSIP integration is made more direct in master, as we no longer need a separate module, and instead the Auth username just needs to match their username. (see line 77 of the doc). Can you double-check whether all the wording changes that oomsveta made are written clearly, have enough context for the everyday user, and everything is formatted according to our standards?

After that, we'll merge this PR the same time the enterprise PR merges!

@Felicious Felicious requested a review from jero-odoo October 24, 2025 20:48
@oomsveta oomsveta force-pushed the master-remove_voip_onsip-wil branch from 8fe7afb to 1ba54a0 Compare October 30, 2025 12:52
@oomsveta
Copy link
Contributor Author

Hello @jero-odoo, do you want to have a look or can I just r+ it?

@jero-odoo
Copy link
Contributor

@oomsveta I apologize for the delay, this looks good to merge from my end, thank you!

@Felicious
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Oct 30, 2025

@oomsveta @Felicious linked pull request(s) odoo/upgrade#8679 not ready. Linked PRs are not staged until all of them are ready.

@Felicious
Copy link
Contributor

@robodoo delegate=@oomsveta

For when the linked PR is ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants