-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] rental: product page #15238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] rental: product page #15238
Conversation
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work on this new doc that you've basically authored from scratch, @meval1006 !!
Incredible work; it's structured well and follows our style (but because writing is subjective, you'll see some comments in the review), and most importantly, it takes the reader through the process from end-to-end! (:
I've completed my content review, so after you take a look at my comments and address whatever you think is reasonable, let's aim for perfect RST formatting + syntax (defined by no errors when you run make fast and make review, passes all CI checks and only 1 commit) when you push this PR up again, and tag me again for the technical/RST formatting review (: it'll be a quick look-over and (hopefully) merge if I don't find anything!
57647ac to
aa818a1
Compare
|
@Felicious Hi Felicia, I have revised the page according to your comments. The most significant changes are:
|
aa818a1 to
388b55b
Compare
|
@Felicious, I added a Create an invoice section and revised the Pickup and Return sections. |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great, @meval1006 ! I like that you added the invoicing section to cover the entire workflow and the example is a lot more clear and concise now (:
I had a smol feedback about the pickup page, and since we confirmed the behavior in your database, the runbots might be showing a new flow that sprung up over the weekend, and we can revisit the two different pickup flows (in the pop-up and the inventory delivery order) in a follow-up PR
Make sure when you push the PR back up, it passes all the make review and make fast checks!
ff34667 to
5e26999
Compare
|
@Felicious I have revised the Pickup products and Return products sections. |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks great, @meval1006 !
I think there are two unused images, so after you remove those, this PR is ready to be merged!
@robodoo delegate+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still using this image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still using this image?
5e26999 to
5a6a37d
Compare
|
@robodoo r+ |

Project task: Add Product page