Skip to content

Conversation

@meval1006
Copy link
Contributor

  • Copied and revised the Rental Order information from the Rental home page and made a new Products page under Rental.

Project task: Add Product page

@meval1006 meval1006 requested a review from Felicious November 11, 2025 23:42
@meval1006 meval1006 self-assigned this Nov 11, 2025
@robodoo
Copy link
Collaborator

robodoo commented Nov 11, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team November 11, 2025 23:44
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this new doc that you've basically authored from scratch, @meval1006 !!

Incredible work; it's structured well and follows our style (but because writing is subjective, you'll see some comments in the review), and most importantly, it takes the reader through the process from end-to-end! (:

I've completed my content review, so after you take a look at my comments and address whatever you think is reasonable, let's aim for perfect RST formatting + syntax (defined by no errors when you run make fast and make review, passes all CI checks and only 1 commit) when you push this PR up again, and tag me again for the technical/RST formatting review (: it'll be a quick look-over and (hopefully) merge if I don't find anything!

@Felicious Felicious added the 5 label Nov 14, 2025
@meval1006 meval1006 force-pushed the 19.0-rental-products-meval branch from 57647ac to aa818a1 Compare November 14, 2025 21:29
@meval1006
Copy link
Contributor Author

@Felicious Hi Felicia, I have revised the page according to your comments. The most significant changes are:

  • Revising the language to detail that this is for a physical product.
  • Reorganized the Create a new physical product section: Added a new note and simplified the Example.

@meval1006 meval1006 requested a review from Felicious November 14, 2025 21:32
@meval1006 meval1006 force-pushed the 19.0-rental-products-meval branch from aa818a1 to 388b55b Compare November 15, 2025 01:33
@meval1006
Copy link
Contributor Author

@Felicious, I added a Create an invoice section and revised the Pickup and Return sections.

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, @meval1006 ! I like that you added the invoicing section to cover the entire workflow and the example is a lot more clear and concise now (:

I had a smol feedback about the pickup page, and since we confirmed the behavior in your database, the runbots might be showing a new flow that sprung up over the weekend, and we can revisit the two different pickup flows (in the pop-up and the inventory delivery order) in a follow-up PR

Make sure when you push the PR back up, it passes all the make review and make fast checks!

@meval1006 meval1006 force-pushed the 19.0-rental-products-meval branch from ff34667 to 5e26999 Compare November 17, 2025 22:57
@meval1006 meval1006 requested a review from Felicious November 17, 2025 22:57
@meval1006
Copy link
Contributor Author

@Felicious I have revised the Pickup products and Return products sections.

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks great, @meval1006 !

I think there are two unused images, so after you remove those, this PR is ready to be merged!

@robodoo delegate+

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still using this image?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still using this image?

@meval1006 meval1006 force-pushed the 19.0-rental-products-meval branch from 5e26999 to 5a6a37d Compare November 18, 2025 00:22
@meval1006
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants