Skip to content

Conversation

@oco-odoo
Copy link
Contributor

task-5243334

@robodoo
Copy link
Collaborator

robodoo commented Nov 18, 2025

Pull request status dashboard

@oco-odoo
Copy link
Contributor Author

@antoine162 I'm not sure how much I need to go into the details for this. Let me know what you think :)

@C3POdoo C3POdoo requested a review from a team November 18, 2025 16:10
Copy link
Contributor

@dade-odoo dade-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oco-odoo for the addition. A couple minor things to align with the doc guidelines. Once you make them you can request a review from be-doc-review and they'll r+ it :)

Comment on lines 173 to +175
Used to match an expression from another report targeted by the xml_id or the report ID itself.
If `force_date_scope` is added, the :guilabel:`Date Scope` defined on the expression will be
used to compute all the expressions used by the formula.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Used to match an expression from another report targeted by the xml_id or the report ID itself.
If `force_date_scope` is added, the :guilabel:`Date Scope` defined on the expression will be
used to compute all the expressions used by the formula.
Match an expression from another report targeted by the xml_id or the report ID itself. If
`force_date_scope` is added, the :guilabel:`Date Scope` defined on the expression will be used to
to compute all the expressions used by the formula.

**dictionary** returned by this function. Use this computation engine only if making a custom
module.

Date Filtering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Date Filtering
Date filtering

Comment on lines +304 to +305
to the ones strictly within the interval selected on the report. You can change that behavior by
modifying the :guilabel:`Date Scope` field of the expression.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to the ones strictly within the interval selected on the report. You can change that behavior by
modifying the :guilabel:`Date Scope` field of the expression.
to the ones strictly within the interval selected on the report. To change that behavior, modify the
:guilabel:`Date Scope` field of the expression.

@antoine162
Copy link
Contributor

Hi @oco-odoo thank you so much for making the doc better, I think this is a great improvement 😄
I think it's great and don't have any comments 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants