[IMP] outlook mail_plugin: add solution for cookie issue #1645

lse-odoo · 2022-03-01T16:02:48Z

No description provided.

robodoo · 2022-03-01T16:03:01Z

lse-odoo · 2022-03-01T16:04:23Z

@Feyensv could you review it please ? :) It's been a loooong while that I didn't made a PR for the documentation, let me know if I need to ping someone in particular for that

Feyensv · 2022-03-01T16:22:12Z

There are codeowners for the doc as well now, so C3POdoo should assign them automatically, and after the codeowners have reviewed the PR, they ping us (doc-review team, ANV & I) for the tech review & r+.

AntoineVDV · 2022-03-01T16:29:38Z

There was an issue with the code owners mapping. It's now fixed 🚀

meng-odoo

@lse-odoo Hello! Thanks for your contribution here. I'm requesting some small changes, mostly to improve wording and sentence flow, before we approve. Please let me know if you have any questions :)

meng-odoo · 2022-04-21T23:32:33Z

content/applications/productivity/mail_plugins/outlook.rst

      trial. This feature requires :ref:`prepaid credits <mail_plugins/pricing>`.

+   .. warning::
+      If, after a short while, the panel is still empty. It is possible that your browser cookies


I made small changes to this sentence to fix a sentence fragment and improve flow.

If, after a short while, the panel is still empty, it is possible that your browser cookie

meng-odoo · 2022-04-21T23:33:56Z

content/applications/productivity/mail_plugins/outlook.rst


+   .. warning::
+      If, after a short while, the panel is still empty. It is possible that your browser cookies
+      settings policy did prevent it to load.


Small changes to improve sentence flow.

settings prevented it from loading.

meng-odoo · 2022-04-21T23:34:51Z

content/applications/productivity/mail_plugins/outlook.rst

+   .. warning::
+      If, after a short while, the panel is still empty. It is possible that your browser cookies
+      settings policy did prevent it to load.
+      Note that this policy does also change if you are connected in "Incognito" mode on your


Small changes to improve sentence flow.

Note that these settings also change if you are in "Incognito" mode on your

meng-odoo · 2022-04-21T23:39:59Z

content/applications/productivity/mail_plugins/outlook.rst

+
+      To fix this issue, you can configure your browser to always allow cookies on Odoo's plugin page.
+
+      For Chrome in particular you can do so by following the guide at:


Small changes to improve wording and punctuation.

For Google Chrome, you can do so by following the guide at

meng-odoo · 2022-04-21T23:44:01Z

content/applications/productivity/mail_plugins/outlook.rst

+      Note that this policy does also change if you are connected in "Incognito" mode on your
+      browser.
+
+      To fix this issue, you can configure your browser to always allow cookies on Odoo's plugin page.


Deleted "you can" so that it reads more like instructions, rather than just an option.

To fix this issue, configure your browser to always allow cookies on Odoo's plugin page.

meng-odoo · 2022-04-21T23:49:23Z

content/applications/productivity/mail_plugins/outlook.rst

+
+      For Chrome in particular you can do so by following the guide at:
+      `https://support.google.com/chrome/answer/95647 <https://support.google.com/chrome/answer/95647#:~:text=Allow%20or%20block%20cookies%20for%20a%20specific%20site>`_
+      then add `download.odoo.com` in the list of `Sites that can always use cookies`.


Small changes to keep the grammar consistent throughout the sentence.

and adding download.odoo.com to the list of Sites that can always use cookies.

Please note that I removed the backtick punctuation around "download.odoo.com" and "Sites that can always use cookies" in my corrected quote above, because Github reads it as formatting. You'll want to keep those backticks in the actual version.

meng-odoo · 2022-04-21T23:53:13Z

content/applications/productivity/mail_plugins/outlook.rst

+         :align: center
+         :alt: Chrome cookie configuration to fix the empty panel issue
+
+      Once done, the panel needs to be open again.


Fixed a small grammar mistake.

Once done, the panel needs to be opened again.

Also, which panel are you referring to here? It might be good to specify.

robodoo · 2022-04-26T11:21:37Z

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

robodoo · 2022-04-26T11:21:38Z

Pull request status dashboard.

lse-odoo · 2022-04-26T11:24:12Z

@meng-odoo thank you for your review. I did update the text accordingly (in theory). Let me know your thoughts on the matter

meng-odoo

@lse-odoo Hi! Thank you very much for making the suggested changes. All of the changes look good.

Upon a second review, I believe we should change a couple more key things before approving: making it a Tip instead of a Warning, and removing the image. Please see my comments below and let me know if you have any questions :)

meng-odoo · 2022-04-26T19:47:24Z

content/applications/productivity/mail_plugins/outlook.rst

      Only a limited amount of *Company Insights* (*Lead Enrichment*) requests are available as a
      trial. This feature requires :ref:`prepaid credits <mail_plugins/pricing>`.

+   .. warning::


Let's change this to a Tip instead of a Warning, because it informs readers about a useful trick, rather than warning them to proceed with caution.

.. tip::

@meng-odoo Speaking about tips, you can click on the "Add a suggestion button" or use ctrl-g to easily make suggestions.

For example:

Suggested change

.. warning::

.. tip::

cc @StraubCreative

meng-odoo · 2022-04-26T20:00:49Z

content/applications/productivity/mail_plugins/outlook.rst

+
+      .. image:: outlook/cookie-fix.png
+         :align: center
+         :alt: Chrome cookie configuration to fix the empty panel issue


Let's delete this image. For platforms outside of Odoo, we want to link to guides from those platforms, rather than walking through the instructions on Odoo's documentation. So what you did here by linking to Google's support page is perfect, and we don't need to include more Google Chrome content in addition to that.

Also, we try not to use too many images. Although your image is helpful, it is not completely necessary for the reader to understand the instructions.

lse-odoo · 2022-04-27T14:47:28Z

@meng-odoo I do think that adding pictures can help customers visualise what to do and if the settings did change with time. But I do understand that it can indeed be confusing for some. I did remove it as you asked (and changed to a tip).
Let me know if you notice something else :)

meng-odoo

@lse-odoo Hi, thanks again for making the suggested changes! Everything looks great. I'll go ahead and move this to the next stage in the review process.

AntoineVDV

@robodoo r+

AntoineVDV · 2022-04-28T07:30:09Z

content/applications/productivity/mail_plugins/outlook.rst

+      If, after a short while, the panel is still empty, it is possible that your browser cookie
+      settings prevented it from loading.
+      Note that these settings also change if you are in "Incognito" mode on your
+      browser.


Nitpicking for your future PRs: It's better not to return to a new line if you don't intend to start a new paragraph. Indeed, single line breaks have no effect on the rendered HTML so it can be confusing for the technical reader to see useless line breaks.

AntoineVDV · 2022-04-28T07:31:53Z

content/applications/productivity/mail_plugins/outlook.rst

+      To fix this issue, configure your browser to always allow cookies on Odoo's plugin page.
+
+      For Google Chrome, you can do so by following the guide at:
+      `https://support.google.com/chrome/answer/95647 <https://support.google.com/chrome/answer/95647#:~:text=Allow%20or%20block%20cookies%20for%20a%20specific%20site>`_


Nitpicking for your future PRs: you can break the line anywhere inside a link label.

Suggested change

`https://support.google.com/chrome/answer/95647 <https://support.google.com/chrome/answer/95647#:~:text=Allow%20or%20block%20cookies%20for%20a%20specific%20site>`_

`https://support.google.com/chrome/answer/95647

<https://support.google.com/chrome/answer/95647#:~:text=Allow%20or%20block%20cookies%20for%20a%20specific%20site>`_

lse-odoo requested a review from AntoineVDV March 1, 2022 16:04

C3POdoo requested a review from a team March 1, 2022 16:29

AntoineVDV removed their request for review March 1, 2022 16:38

meng-odoo suggested changes Apr 21, 2022

View reviewed changes

meng-odoo assigned lse-odoo Apr 22, 2022

lse-odoo force-pushed the 15.0-microsoft_calendar_plugin_cookie_fix-lse branch from 41be2df to 7da13e7 Compare April 26, 2022 11:21

lse-odoo requested a review from meng-odoo April 26, 2022 11:23

meng-odoo suggested changes Apr 26, 2022

View reviewed changes

[IMP] outlook mail_plugin: add solution for cookie issue

3fa47eb

lse-odoo force-pushed the 15.0-microsoft_calendar_plugin_cookie_fix-lse branch from 7da13e7 to 3fa47eb Compare April 27, 2022 14:45

meng-odoo approved these changes Apr 27, 2022

View reviewed changes

meng-odoo requested a review from a team April 27, 2022 17:39

AntoineVDV approved these changes Apr 28, 2022

View reviewed changes

robodoo closed this in 3e25d94 Apr 28, 2022

robodoo temporarily deployed to merge April 28, 2022 09:11 Inactive

fw-bot deleted the 15.0-microsoft_calendar_plugin_cookie_fix-lse branch May 12, 2022 09:46


		To fix this issue, you can configure your browser to always allow cookies on Odoo's plugin page.

		For Chrome in particular you can do so by following the guide at:

	`https://support.google.com/chrome/answer/95647 <https://support.google.com/chrome/answer/95647#:~:text=Allow%20or%20block%20cookies%20for%20a%20specific%20site>`_
	`https://support.google.com/chrome/answer/95647
	<https://support.google.com/chrome/answer/95647#:~:text=Allow%20or%20block%20cookies%20for%20a%20specific%20site>`_

[IMP] outlook mail_plugin: add solution for cookie issue #1645

[IMP] outlook mail_plugin: add solution for cookie issue #1645

Uh oh!

Conversation

lse-odoo commented Mar 1, 2022

Uh oh!

robodoo commented Mar 1, 2022

Uh oh!

lse-odoo commented Mar 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Feyensv commented Mar 1, 2022

Uh oh!

AntoineVDV commented Mar 1, 2022 • edited by Feyensv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meng-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meng-odoo Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meng-odoo Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meng-odoo Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meng-odoo Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robodoo commented Apr 26, 2022

Uh oh!

robodoo commented Apr 26, 2022

Uh oh!

lse-odoo commented Apr 26, 2022

Uh oh!

meng-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lse-odoo commented Apr 27, 2022

Uh oh!

meng-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

AntoineVDV left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lse-odoo commented Mar 1, 2022 •

edited

Loading

AntoineVDV commented Mar 1, 2022 •

edited by Feyensv

Loading

meng-odoo left a comment •

edited

Loading

meng-odoo Apr 21, 2022 •

edited

Loading

meng-odoo Apr 21, 2022 •

edited

Loading

meng-odoo Apr 21, 2022 •

edited

Loading

meng-odoo Apr 21, 2022 •

edited

Loading

meng-odoo left a comment •

edited

Loading