[IMP] accounting: add a warning about invoices in USD in Mexico

[antoine162]

Mexican companies very commonly issue invoices in USD, to be fulfiled
in MXN, at the official exchange rate defined by the Banco de Mexico
on the day of payment.

(Presumably, this is to insure against the volatility of the Mexican
peso.)

Odoo supports this workflow, but only if the payment is registered
directly on the invoice using the 'Register Payment' button.

If the payment is created separately, and then reconciled manually
with the invoice, a whole host of problems occur:

• the payment typically can't be reconciled fully with the invoice,
  (even though that can usually be solved by manually creating
  an exchange move)
• but more problematically, the amounts on the payment CFDI will
  be wrong, and even manually creating an exchange move won't solve
  that.

So, we absolutely need to warn users not to try to do that.

(We've been encountering lots of tickets lately in the tech-support
pipe because of users who tried this and then wonder why it doesn't
work.)

This is currently an issue in 14.0, 15.0 and master.

[robodoo]

Pull request status dashboard.

[antoine162]

@smetl since you're well aware of the technical roots of this issue, could you just please confirm for the marketing team that it is indeed an issue?

[jcs-odoo]

cc @vbe-odoo .

[jcs-odoo]

Thanks for this PR @antoine162 !
I hope it will help reduce the amount of errors and tickets the support gets :)

• I wouldn't put this warning at the beginning of this section as we want to explain the "normal" behaviour first.
• if you want to emphasize something with bold, better put it on relevant information rather than on "must".
• Use the present tense for normal behavior (not the future) see guidelines
• ' doesn't work to highlight a button. prefer using :guilabel: or double backticks `` for "technical" display. (see suggestion)
• 100th characters max per line (see rst guidelines)

cc @vbe-odoo since it's your content.

[jcs-odoo]

Suggested change

	.. warning::
	- When creating a payment in MXN for an invoice in USD, the payment **must** be created using the
	'Register Payment' button on the invoice view and not separately as a payment. Otherwise, the
	payment CFDI will not be correctly generated.
	- As such, a payment in MXN cannot be used to pay multiple invoices in USD. Rather, the payment
	should be separated into multiple payments, and each payment created using the 'Register Payment'
	button on its corresponding invoice.
	.. warning::
	- When making a payment in MXN for an invoice in USD, the payment must be created using the
	:guilabel:`Register Payment` button **on the invoice view** and not separately as a payment.
	Otherwise, the payment CFDI is not correctly generated.
	- As such, a payment in MXN cannot be used to pay multiple invoices in USD. Rather, the payment
	should be separated into multiple payments created using the :guilabel:`Register Payment`
	button on the corresponding invoices.

[vbe-odoo]

Hi, @jcs-odoo @antoine162 many thanks for the PR with the changes and the review.
LGTM in terms of the text and the description of the issue being solved here.
Thanks!
cc' @ren-odoo @fvz-odoo

[jcs-odoo]

@smetl since you're well aware of the technical roots of this issue, could you just please confirm for the marketing team that it is indeed an issue?

@antoine162 We won't check all localizations behaviors, so I assume that it was needed if you made this PR. Let me know once you've updated your commit.

Thanks :)

[smetl]

@antoine162 Yeah ... I confirm I confirm!

[antoine162]

@jcs-odoo all my apologies for my lateness in getting back to this PR, and thank you so much for educating me on good practices! I've changed the wording as you suggested, and put the warning at the end of the section on PUE payments, after the explanation of the normal flow. (The warning applies only to PUE payments, since these are the only payments that require a CFDI.)

[jcs-odoo]

No problem @antoine162 !

Can you just rename the commit message
[IMP] accounting: add a warning about invoices in USD in Mexico

I take the liberty of changing the name of the PR so the reviewer can merge directly and rename the commit based on the PR's title.

[AntoineVDV]

@robodoo r+ squash

[robodoo]

Merge method set to squash

[antoine162]

Merci beaucoup @jcs-odoo @AntoineVDV