Skip to content

Conversation

@lse-odoo
Copy link
Contributor

Because of a recent Chrome security update, a lot of customers using peripheral devices (printers, ...) will have to follow this doc.

Therefore, I followed the doc and did the flow on my side.

I modified 'Copy to file' to 'Export' and 'Trusted Root Certification Authorities' to 'Authorities' in order to have the exact same terms as in Chrome (I guess they updated their terms at some point).

@robodoo
Copy link
Collaborator

robodoo commented Jun 10, 2022

@lse-odoo lse-odoo mentioned this pull request Jun 10, 2022
@C3POdoo C3POdoo requested a review from a team June 10, 2022 10:03
@lse-odoo
Copy link
Contributor Author

@qle-odoo
I did change the branch name for LMA and it looks like it was the issue for the check not being passed. Could you review it please ?

@lse-odoo lse-odoo requested a review from qle-odoo June 10, 2022 10:10
Copy link
Contributor

@qle-odoo qle-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Collaborator

robodoo commented Jun 10, 2022

I'm sorry, @qle-odoo. I'm afraid I can't do that.

@qle-odoo
Copy link
Contributor

@lse-odoo sorry i can't merge documentation
@LoredanaLrpz

@LoredanaLrpz LoredanaLrpz requested review from a team and LoredanaLrpz and removed request for a team June 10, 2022 12:39
Copy link
Collaborator

@Feyensv Feyensv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+
(are you sure this change is not needed in the 13.0 documentation ?)

@Feyensv Feyensv changed the title [FIX] Update epos_ssc.rst [FIX] point_of_sale: use the correct terms in Chrome interface Jun 10, 2022
@Feyensv
Copy link
Collaborator

Feyensv commented Jun 10, 2022

@robodoo squash

@robodoo
Copy link
Collaborator

robodoo commented Jun 10, 2022

Merge method set to squash

@qle-odoo
Copy link
Contributor

@robodoo r+ (are you sure this change is not needed in the 13.0 documentation ?)

No ePos in 13.0 so no doc...

@Feyensv
Copy link
Collaborator

Feyensv commented Jun 10, 2022

@robodoo r-

@Feyensv
Copy link
Collaborator

Feyensv commented Jun 10, 2022

please, wait before merging I approved too fast

If you're speaking of the commit message & title, with the 'squash' method, the merge commit will use the PR title & message ;).

Copy link
Contributor

@LoredanaLrpz LoredanaLrpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @lse-odoo , sorry I approved but didn't check the characters, I've made suggestions then I'll approve that PR :D

Because of a recent Chrome security update, a lot of customers using peripheral devices (printers, ...) will have to follow this doc.

Therefore, I followed the doc and did the flow on my side.

I modified 'Copy to file' to 'Export' and 'Trusted Root Certification Authorities' to 'Authorities' in order to have the exact same terms as in Chrome (I guess they updated their terms at some point).
@lse-odoo lse-odoo force-pushed the 14.0-fix_epos_export_import_self_signed_certificate-lma branch from 227212e to f65d891 Compare June 15, 2022 14:19
@lse-odoo
Copy link
Contributor Author

@LoredanaLrpz Done! Is there something else that you would like me to change ?

Copy link
Contributor

@LoredanaLrpz LoredanaLrpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lse-odoo looks good to me :) ! Thank you =D

@LoredanaLrpz LoredanaLrpz requested a review from a team June 15, 2022 18:15
@Feyensv
Copy link
Collaborator

Feyensv commented Jun 16, 2022

@robodoo r+

robodoo pushed a commit that referenced this pull request Jun 16, 2022
Because of a recent Chrome security update, a lot of customers using peripheral devices (printers, ...) will have to follow this doc.

Therefore, I followed the doc and did the flow on my side.

I modified 'Copy to file' to 'Export' and 'Trusted Root Certification Authorities' to 'Authorities' in order to have the exact same terms as in Chrome (I guess they updated their terms at some point).

closes #2180

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo closed this Jun 16, 2022
@robodoo robodoo temporarily deployed to merge June 16, 2022 10:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants