Skip to content

Conversation

@weka-one
Copy link
Contributor

@weka-one weka-one commented Oct 4, 2022

Replaced the images, and rewrote the content to ensure it's consistent and up to date.

@robodoo
Copy link
Collaborator

robodoo commented Oct 4, 2022

@weka-one weka-one requested a review from mivu-odoo October 4, 2022 21:48
@C3POdoo C3POdoo requested a review from a team October 4, 2022 21:49
Copy link
Contributor

@mivu-odoo mivu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @weka-odoo!

Thank you for your patience on this PR!

I found some edits for details and formatting. Please let me know if you have any questions. When you're ready, please tag me again for another look. Thank you 😸

@weka-one weka-one force-pushed the 15.0-MRP-semifinishededits-weka branch from f16327d to 2329b14 Compare October 6, 2022 15:55
@weka-one
Copy link
Contributor Author

weka-one commented Oct 6, 2022

@mivu-odoo I incorporated the requested changes. Please take another look whenever you get the chance. Thank you!

@weka-one weka-one requested a review from mivu-odoo October 6, 2022 15:59
Copy link
Contributor

@mivu-odoo mivu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @weka-odoo!

Thank you for your revisions! I found a few small edits for language.

Once you push those edits, feel free to go straight to ZST for final technical review, no need to tag me again. Thank you 😸

@weka-one weka-one force-pushed the 15.0-MRP-semifinishededits-weka branch from 2329b14 to 7372427 Compare October 6, 2022 18:14
@weka-one
Copy link
Contributor Author

weka-one commented Oct 6, 2022

@StraubCreative This PR is ready for you to review whenever you get the chance. I rewrote a lot of this content/replaced the images to make sure that it's up to date.

Thank you!

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @weka-odoo

This was a great rewrite!

I have a few suggestions around the following:

  • serif vs. sans-serif apostrophes
  • media file names
  • tag and list formatting

I like what you did to try and help the reader by adding in references to other articles. I offered a couple suggestions there with some options.

Let me know if you have any q's otherwise I'll look forward to the revisions, thanks!

cc: @mivu-odoo

@StraubCreative StraubCreative force-pushed the 15.0-MRP-semifinishededits-weka branch from 7372427 to 220e1c8 Compare December 2, 2022 01:19
@StraubCreative
Copy link
Contributor

@weka-odoo quick follow up— I had to solve a merge conflict that showed up as a result of #2983 which wiped all trailing whitespaces across the entire repo, including this file. You should be all set on 220e1c8, please make sure you git pull --rebase before you start addressing the CR's 👍

@StraubCreative StraubCreative force-pushed the 15.0-MRP-semifinishededits-weka branch from 220e1c8 to 0b0adb4 Compare December 30, 2022 02:51
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All change requests addressed in 0b0adb4. Moving on to DR.

@StraubCreative
Copy link
Contributor

Hi @odoo/doc-review 👋
This article about sub-assemblies is ready for your review.
Thank you 🙂

@StraubCreative StraubCreative requested a review from a team December 30, 2022 02:56
@StraubCreative StraubCreative self-assigned this Dec 30, 2022
@AntoineVDV AntoineVDV removed the request for review from a team January 2, 2023 09:59
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

@StraubCreative StraubCreative force-pushed the 15.0-MRP-semifinishededits-weka branch from 0b0adb4 to ea43afc Compare January 5, 2023 17:34
@StraubCreative
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Jan 5, 2023

I'm sorry, @StraubCreative. I'm afraid I can't do that.

@StraubCreative
Copy link
Contributor

@AntoineVDV should be good to go unless you catch anything else.
Please advise weka-odoo will not be able to FP the chain once the merge command is issued.
Will need you to do it please or can delegate to me or @mivu-odoo if that's possible 🙂

@AntoineVDV
Copy link
Collaborator

Hi @StraubCreative, the r+ is already delegated to you, and so will the forward-port PRs. ;)

Note that the forward-port bot is currently broken (I hope for a fix next week 🤞). It will create the forward-port PRs, but it will also rebase them on a commit from December 2... This highly increases the chances of having a "conflict". If that happens in the fwp PR for saas-15.2, run git fetch origin saas-15.2 <the-fwp-branch> && git switch <the-fwp-branch> && git reset --hard origin/saas-15.2 && git cherry-pick ea43afc792b94de938c0f0cb8546a6a22675a7f1 && git push --force-with-lease to fix it.

@StraubCreative StraubCreative force-pushed the 15.0-MRP-semifinishededits-weka branch from ea43afc to 05d36e6 Compare January 13, 2023 00:30
@StraubCreative
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Jan 13, 2023

I'm sorry, @StraubCreative. I'm afraid I can't do that.

@AntoineVDV
Copy link
Collaborator

AntoineVDV commented Jan 13, 2023

@StraubCreative My bad; I thought you were the author of the PR.

@robodoo r+

PS: The issue with the forward-port bot has been resolved.

@fw-bot
Copy link
Collaborator

fw-bot commented Jan 17, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants