-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[IMP] MRP: edited/updated Semi-Finished products doc v15 #2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mivu-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @weka-odoo!
Thank you for your patience on this PR!
I found some edits for details and formatting. Please let me know if you have any questions. When you're ready, please tag me again for another look. Thank you 😸
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
f16327d to
2329b14
Compare
|
@mivu-odoo I incorporated the requested changes. Please take another look whenever you get the chance. Thank you! |
mivu-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @weka-odoo!
Thank you for your revisions! I found a few small edits for language.
Once you push those edits, feel free to go straight to ZST for final technical review, no need to tag me again. Thank you 😸
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
2329b14 to
7372427
Compare
|
@StraubCreative This PR is ready for you to review whenever you get the chance. I rewrote a lot of this content/replaced the images to make sure that it's up to date. Thank you! |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @weka-odoo
This was a great rewrite!
I have a few suggestions around the following:
- serif vs. sans-serif apostrophes
- media file names
- tag and list formatting
I like what you did to try and help the reader by adding in references to other articles. I offered a couple suggestions there with some options.
Let me know if you have any q's otherwise I'll look forward to the revisions, thanks!
cc: @mivu-odoo
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
7372427 to
220e1c8
Compare
220e1c8 to
0b0adb4
Compare
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All change requests addressed in 0b0adb4. Moving on to DR.
|
Hi @odoo/doc-review 👋 |
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo delegate+
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/sub_assemblies.rst
Outdated
Show resolved
Hide resolved
0b0adb4 to
ea43afc
Compare
|
@robodoo r+ |
|
I'm sorry, @StraubCreative. I'm afraid I can't do that. |
|
@AntoineVDV should be good to go unless you catch anything else. |
|
Hi @StraubCreative, the r+ is already delegated to you, and so will the forward-port PRs. ;) Note that the forward-port bot is currently broken (I hope for a fix next week 🤞). It will create the forward-port PRs, but it will also rebase them on a commit from December 2... This highly increases the chances of having a "conflict". If that happens in the fwp PR for saas-15.2, run |
ea43afc to
05d36e6
Compare
|
@robodoo r+ |
|
I'm sorry, @StraubCreative. I'm afraid I can't do that. |
|
@StraubCreative My bad; I thought you were the author of the PR. @robodoo r+ PS: The issue with the forward-port bot has been resolved. |
closes #2787 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
|
@weka-odoo @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): |
Replaced the images, and rewrote the content to ensure it's consistent and up to date.