Skip to content

[IMP] accounting: Forecasting bills #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] accounting: Forecasting bills #2970

wants to merge 1 commit into from

Conversation

@chiaraprattico
Copy link
Contributor

@chiaraprattico chiaraprattico commented Nov 16, 2022 •
edited by LoredanaLrpz
Loading

taskid: 3069519

@robodoo
Copy link
Collaborator

robodoo commented Nov 16, 2022

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team November 16, 2022 12:01
@chiaraprattico chiaraprattico force-pushed the 14.0-forecastbills-chpr branch from 8aa4542 to 2ee6949 Compare November 16, 2022 12:03
@chiaraprattico chiaraprattico removed the request for review from a team November 16, 2022 12:03
LoredanaLrpz
LoredanaLrpz requested changes Nov 17, 2022
View reviewed changes
@chiaraprattico chiaraprattico force-pushed the 14.0-forecastbills-chpr branch 2 times, most recently from 608e38d to c9a78a7 Compare November 21, 2022 10:41
LoredanaLrpz
LoredanaLrpz requested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@LoredanaLrpz LoredanaLrpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go,
great pr
I still have some suggestions, but almost good for me :)

@chiaraprattico chiaraprattico force-pushed the 14.0-forecastbills-chpr branch from c9a78a7 to 872ccf0 Compare November 21, 2022 15:14
@LoredanaLrpz LoredanaLrpz requested a review from a team November 22, 2022 08:43
xpl-odoo
xpl-odoo requested changes Nov 28, 2022
View reviewed changes
content/applications/finance/accounting/payables/misc/forecast.rst Outdated
Payment terms allow to keep track of the conditions to compute the due
date on an invoice. As an example, a payment term can be:
In order to track the vendor conditions, we use **Payment Terms** in Odoo.
**Payment terms** allow keeping track of due dates on invoices. Examples of **Payment Terms** are:
Copy link
Contributor

@xpl-odoo xpl-odoo Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Payment terms** allow keeping track of due dates on invoices. Examples of **Payment Terms** are:
**Payment Terms** allow keeping track of due dates on invoices. Examples of **Payment Terms** are:

Payment Terms or Payment terms (no capital t)? You seem to use both, I would stick to one version. But in this specific case, you could start the sentence with They to avoid saying Payment Terms three times in quick succession.

Copy link
Contributor Author

@chiaraprattico chiaraprattico Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave" Payment Terms" since in the db it looks like this

content/applications/finance/accounting/payables/misc/forecast.rst Outdated
Comment on lines 17 to 19
To create **Payment terms**, use the :menuselection:`Accounting app --> Configuration -->
Invoicing --> Payment Terms`. By clicking on :guilabel:`Create`, you can add the terms you need as
well as modify existing ones by clicking on it in the Payment Terms list in the same view.
Copy link
Contributor

@xpl-odoo xpl-odoo Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To create **Payment terms**, use the :menuselection:`Accounting app --> Configuration -->
Invoicing --> Payment Terms`. By clicking on :guilabel:`Create`, you can add the terms you need as
well as modify existing ones by clicking on it in the Payment Terms list in the same view.
To create **Payment Terms**, go to :menuselection:`Accounting --> Configuration -->
Invoicing: Payment Terms`. Click on :guilabel:`Create` to add the terms you need or
modify existing ones by clicking on them.
  • You don't really use a menu, I would say go to as usual.
  • No app (my bad for previously suggesting it!)
  • Include the "submenu" Invoicing in the same step as Payment Terms, as here users might think it's a separate step.
  • Suggestion to simplify
  • Could be interesting to present/explain the actual configuration of payment terms?
    image

Copy link
Contributor Author

@chiaraprattico chiaraprattico Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but it looks very different in 15 and 16 so not too sure which one I'd have to put without creating confusion

content/applications/finance/accounting/payables/misc/forecast.rst Outdated
From this screen, you can also switch to the pivot table or the graph
view to get statistics on the amount due over the next month, using the
group by "Due Date" feature.
From this screen, you can also switch to the pivot table or the graph view to get statistics on the
Copy link
Contributor

@xpl-odoo xpl-odoo Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
From this screen, you can also switch to the pivot table or the graph view to get statistics on the
From this screen, you can also switch to the pivot or graph view to get statistics on the

Not from the Vendors --> Bills screen

@chiaraprattico chiaraprattico force-pushed the 14.0-forecastbills-chpr branch from 872ccf0 to e456e86 Compare December 2, 2022 09:02
@chiaraprattico chiaraprattico force-pushed the 14.0-forecastbills-chpr branch 2 times, most recently from 543cc86 to 44b0aa9 Compare December 2, 2022 09:45
@xpl-odoo xpl-odoo force-pushed the 14.0-forecastbills-chpr branch from 44b0aa9 to e2a387d Compare December 5, 2022 11:16
@xpl-odoo xpl-odoo requested a review from a team December 5, 2022 11:27
AntoineVDV
AntoineVDV approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Dec 6, 2022

@chiaraprattico @AntoineVDV staging failed: ci/runbot on c66626c6c919f1392012130230f5cb9c790f2b30 (view more at https://runbot.odoo.com/runbot/build/21623132)

@AntoineVDV
Copy link
Collaborator

AntoineVDV commented Dec 6, 2022

@robodoo retry

robodoo pushed a commit that referenced this pull request Dec 6, 2022
@chiaraprattico @xpl-odoo
[ACC] accounting: Forecasting bills
716d983 
closes #2970

Tasikd: 3069519
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo
Copy link
Collaborator

robodoo commented Dec 6, 2022

@chiaraprattico @AntoineVDV staging failed: ci/runbot on 3176d8fa6856c33b1b9f716cc184379ec3c2f183 (view more at https://runbot.odoo.com/runbot/build/21628808)

@chiaraprattico
Copy link
Contributor Author

chiaraprattico commented Dec 7, 2022

@robodoo retry

robodoo pushed a commit that referenced this pull request Dec 7, 2022
@chiaraprattico @xpl-odoo
[ACC] accounting: Forecasting bills
939d40c 
closes #2970

Tasikd: 3069519
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo robodoo temporarily deployed to merge December 7, 2022 10:27 Inactive
@robodoo robodoo closed this Dec 7, 2022
This was referenced Dec 7, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineVDV AntoineVDV AntoineVDV approved these changes

@xpl-odoo xpl-odoo xpl-odoo approved these changes

@LoredanaLrpz LoredanaLrpz LoredanaLrpz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chiaraprattico @robodoo @AntoineVDV @xpl-odoo @LoredanaLrpz