[IMP] inventory: fix and update lots #3850

brse-odoo · 2023-03-20T14:54:30Z

This PR is targeting Odoo project task #3215736 to make a small fix on the lots doc.

Made small fix, and performed complete rewrite to the document for 14.0 to be fwd-ported (targeted revision for 15.0 and 16.0 to follow).

Completely rewrote the .rst file and added example flows
Replaced and updated all screenshots
Doc is more robust and comprehensive than before

robodoo · 2023-03-20T14:55:21Z

Pull request status dashboard.

brse-odoo · 2023-03-20T15:43:11Z

Hi @jero-odoo and @larm-odoo! Whichever of you two is available to do so, this PR is ready for round one of peer review. Thank you in advance!

jero-odoo

@brse-odoo All set! Let me know if you have any questions 👍

content/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/lots.rst

brse-odoo · 2023-03-29T13:47:38Z

Hi @StraubCreative this PR is ready for your final review.

brse-odoo · 2023-04-17T18:37:53Z

Hi @odoo/us-doc-review, this PR is ready for a content review when one of you has a chance. Thank you!

ksc-odoo

@brse-odoo Just finished reviewing this doc - looks great! If you have any questions, don't hesitate to reach out. Thanks!

content/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/lots.rst

brse-odoo · 2023-05-01T20:16:03Z

@StraubCreative This is ready for final review.

StraubCreative

Hi @brse-odoo
Please fix the 100th char line break issues and tag me again for review.
Thanks

brse-odoo · 2023-05-11T14:51:54Z

@StraubCreative The 100th character line breaks have been fixed. This is ready for final review

StraubCreative

Still seeing 100th char issues here, as well.
cc: @samueljlieber

brse-odoo · 2023-05-15T19:00:55Z

I found two 100th character errors in this doc, fixed it, and pushed up the changes.

@samueljlieber If you could take a look for me and confirm everything looks good, I'd appreciate it. Thank you!

brse-odoo · 2023-05-18T18:36:25Z

@samueljlieber If you have the time this could use one last technical look-over before heading to final review. I just edited and pushed up revisions. Thank you!

samueljlieber

Hi @brse-odoo I have just a couple technical changes throughout the doc, please tag me once more for a review after these changes have been made. Thank you!

content/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/lots.rst

brse-odoo · 2023-05-22T14:56:28Z

@samueljlieber I've implemented the technical changes you suggested and pushed up the revisions. Back to you -- thank you!

samueljlieber

Hi @brse-odoo just two technical corrections I found, please see them below. I am pushing these up as a commit for you after this review since they are minor and I want to get this PR over to final review! Good work with this PR 🙂

samueljlieber · 2023-05-22T15:29:28Z

content/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/lots.rst

closing parenthesis with no opener 😉

Suggested change

:guilabel:`Operations` tab). Clicking that icon reveals a :guilabel:`Detailed Operations` pop-up.

:guilabel:`Operations` tab. Clicking that icon reveals a :guilabel:`Detailed Operations` pop-up.

samueljlieber · 2023-05-22T15:31:55Z

content/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/lots.rst

Icon formatting again

Suggested change

From here, click the :guilabel:`Additional Options` menu, represented by a `hamburger` icon (four

horizontal lines, located to the right of the :guilabel:`Unit of Measure` column in the

:guilabel:`Operations` tab). Clicking that icon reveals a :guilabel:`Detailed Operations` pop-up.

From here, click the :guilabel:`Additional Options` menu, represented by a :guilabel:`hamburger (four horizontal lines)` icon , located to the right of the :guilabel:`Unit of Measure` column in the :guilabel:`Operations` tab. Clicking that icon reveals a :guilabel:`Detailed Operations` pop-up.

samueljlieber · 2023-05-22T15:41:05Z

Implemented minor technical changes in b3ae37e. @StraubCreative this PR is ready for final review! 🙂

StraubCreative

Hi @brse-odoo
Well-written doc 👏
Approving with comments around grammar and wordiness.

@robodoo delegate+

content/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/lots.rst

brse-odoo · 2023-05-24T13:49:00Z

@robodoo r+

closes #3850 Signed-off-by: Brandon Seltenrich (brse) <brse@odoo.com>

brse-odoo self-assigned this Mar 20, 2023

C3POdoo requested a review from a team March 20, 2023 15:11

brse-odoo requested a review from jero-odoo March 23, 2023 13:32

jero-odoo reviewed Mar 23, 2023

View reviewed changes

brse-odoo force-pushed the 14.0-inventory-update-lots-serial-brse branch from cae3fff to 1956572 Compare March 29, 2023 13:32

brse-odoo requested a review from StraubCreative March 29, 2023 13:34

brse-odoo requested a review from a team April 17, 2023 18:37

ksc-odoo reviewed Apr 26, 2023

View reviewed changes

brse-odoo force-pushed the 14.0-inventory-update-lots-serial-brse branch from 1956572 to bf71380 Compare May 1, 2023 20:09

brse-odoo requested review from StraubCreative and removed request for StraubCreative May 1, 2023 20:16

StraubCreative requested changes May 5, 2023

View reviewed changes

StraubCreative added the repeat designation for PRs worth a second look label May 5, 2023

brse-odoo force-pushed the 14.0-inventory-update-lots-serial-brse branch from bf71380 to 80de176 Compare May 8, 2023 14:45

brse-odoo requested a review from StraubCreative May 11, 2023 14:51

StraubCreative requested changes May 15, 2023

View reviewed changes

brse-odoo force-pushed the 14.0-inventory-update-lots-serial-brse branch from 80de176 to 34e5f13 Compare May 15, 2023 18:44

brse-odoo force-pushed the 14.0-inventory-update-lots-serial-brse branch from 34e5f13 to 46d7041 Compare May 18, 2023 18:33

brse-odoo requested a review from samueljlieber May 18, 2023 18:36

samueljlieber requested changes May 19, 2023

View reviewed changes

brse-odoo force-pushed the 14.0-inventory-update-lots-serial-brse branch from 46d7041 to 02337d8 Compare May 22, 2023 14:48

samueljlieber approved these changes May 22, 2023

View reviewed changes

samueljlieber force-pushed the 14.0-inventory-update-lots-serial-brse branch from 02337d8 to b3ae37e Compare May 22, 2023 15:38

samueljlieber requested a review from StraubCreative May 22, 2023 15:41

StraubCreative approved these changes May 23, 2023

View reviewed changes

[IMP] inventory: fix and update lots

f3d4187

brse-odoo force-pushed the 14.0-inventory-update-lots-serial-brse branch from b3ae37e to f3d4187 Compare May 24, 2023 13:38

robodoo pushed a commit that referenced this pull request May 24, 2023

[IMP] inventory: fix and update lots

5bc3b94

closes #3850 Signed-off-by: Brandon Seltenrich (brse) <brse@odoo.com>

robodoo temporarily deployed to merge May 24, 2023 14:58 Inactive

robodoo closed this May 24, 2023

	:guilabel:`Operations` tab). Clicking that icon reveals a :guilabel:`Detailed Operations` pop-up.
	:guilabel:`Operations` tab. Clicking that icon reveals a :guilabel:`Detailed Operations` pop-up.

-From here, click the :guilabel:`Additional Options` menu, represented by a `hamburger` icon (four
-horizontal lines, located to the right of the :guilabel:`Unit of Measure` column in the
-:guilabel:`Operations` tab). Clicking that icon reveals a :guilabel:`Detailed Operations` pop-up.
+From here, click the :guilabel:`Additional Options` menu, represented by a :guilabel:`hamburger (four horizontal lines)` icon , located to the right of the :guilabel:`Unit of Measure` column in the :guilabel:`Operations` tab. Clicking that icon reveals a :guilabel:`Detailed Operations` pop-up.

[IMP] inventory: fix and update lots #3850

[IMP] inventory: fix and update lots #3850

Uh oh!

Conversation

brse-odoo commented Mar 20, 2023

Uh oh!

robodoo commented Mar 20, 2023

Uh oh!

brse-odoo commented Mar 20, 2023

Uh oh!

jero-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brse-odoo commented Mar 29, 2023

Uh oh!

brse-odoo commented Apr 17, 2023

Uh oh!

ksc-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brse-odoo commented May 1, 2023

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

brse-odoo commented May 11, 2023

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

brse-odoo commented May 15, 2023

Uh oh!

brse-odoo commented May 18, 2023

Uh oh!

samueljlieber left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brse-odoo commented May 22, 2023

Uh oh!

samueljlieber left a comment

Choose a reason for hiding this comment

Uh oh!

samueljlieber May 22, 2023

Choose a reason for hiding this comment

Uh oh!

samueljlieber May 22, 2023

Choose a reason for hiding this comment

Uh oh!

samueljlieber commented May 22, 2023

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!