Skip to content

Conversation

@tiku-odoo
Copy link
Contributor

@Abridbus @bouvyd

CC: @alry-odoo

Pull request for two new system parameters in Odoo 16.

Can you confirm whether these parameters need to be added manually or are triggered in some way?

Also- Can you review the added text for accuracy?

  • Is the mail.incoming.limit.alias key specific to all alias (combined) or counted by just one alias?

  • Can you confirm the catchall behavior as noted in Lines 297-Line 301?

Thanks! -Tim

@tiku-odoo tiku-odoo requested review from Abridbus and bouvyd April 26, 2023 13:44
@tiku-odoo tiku-odoo self-assigned this Apr 26, 2023
@robodoo
Copy link
Collaborator

robodoo commented Apr 26, 2023

@C3POdoo C3POdoo requested a review from a team April 26, 2023 13:46
@Abridbus
Copy link
Contributor

Abridbus commented Apr 28, 2023

Can you confirm whether these parameters need to be added manually or are triggered in some way?

(edit) by default they will be existing with the value given (120 & 20) but they can be override and added on the system parameters

I will do the review, no need to ping dbo :)

related opw-3289996

@tiku-odoo
Copy link
Contributor Author

@bouvyd @Abridbus

I created https://edu-spaghettiparm.odoo.com/ (V16) and the two system parameters are not present.

I've also checked RunBot V16.2 / V16.3

  • mail.incoming.limit.period (60 minutes by default)
  • mail.incoming.limit.alias (5 by default)

Can you confirm these system parameters are automatically created?

When you have a moment can you review this addition to the doc:
[content/applications/general/email_communication/email_servers.rst]

Thanks in advance. If it would be easier and you'd like to chat about these new parameters I'm available.

@Abridbus
Copy link
Contributor

@bouvyd @Abridbus

I created https://edu-spaghettiparm.odoo.com/ (V16) and the two system parameters are not present.

I've also checked RunBot V16.2 / V16.3

  • mail.incoming.limit.period (60 minutes by default)
  • mail.incoming.limit.alias (5 by default)

Can you confirm these system parameters are automatically created?

When you have a moment can you review this addition to the doc: [content/applications/general/email_communication/email_servers.rst]

Thanks in advance. If it would be easier and you'd like to chat about these new parameters I'm available.

So I doubled check and no, they are not present by default.
They have default value set (60 and 5) but can be override by creating them in any db.

@tiku-odoo tiku-odoo force-pushed the 16.0-Misc-Add-Sys-Parameters-Email-doc-tiku branch from 0294f8c to 289a2a8 Compare May 16, 2023 14:35
@tiku-odoo
Copy link
Contributor Author

@StraubCreative This doc is ready for your review. The Product technical expert got back to me and it is ready for publication. This is considered a PO fast track doc.

Thanks,
Tim

@tiku-odoo tiku-odoo added the priority Priority lane PRs directly from POs label May 16, 2023
@tiku-odoo tiku-odoo requested a review from StraubCreative May 16, 2023 15:46
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tiku-odoo

Approving with comments, mostly around wording, for your consideration.
I caught a typo too, which we'll want to fix quick.

Can merge whenever you're ready. Passing the torch to you 🔥
@robodoo delegate+

@tiku-odoo tiku-odoo force-pushed the 16.0-Misc-Add-Sys-Parameters-Email-doc-tiku branch from 289a2a8 to bd3de19 Compare May 22, 2023 18:26
@tiku-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request May 22, 2023
closes #4277

Signed-off-by: Timothy Kukulka (tiku) <tiku@odoo.com>
@robodoo robodoo temporarily deployed to merge May 22, 2023 19:57 Inactive
@robodoo robodoo closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority Priority lane PRs directly from POs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants