[IMP] subscriptions: update subscription plans #4343
Conversation
hojo-odoo
left a comment
hojo-odoo
left a comment
There was a problem hiding this comment.
Hey @meng-odoo,
Great job on this! Most of my comments are pretty minor. Make sure to decapitalize all of the words that follow a colon.
Thanks,
hojo
meng-odoo
force-pushed
the
16.0-subscription-plans-meng
branch
from
7cec328 to
ae71a4d
Compare
|
Thanks for your review @hojo-odoo! FYI I followed all of the colons with a complete sentence so that they could properly be in sentence case (have a capitalized first letter). Hi @samueljlieber, this is ready for technical review. |
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
Hi @meng-odoo 👋 I made just a couple of technical suggestion on this PR, please review them below and let me know if you have any questions.
Note on images: Since were improving this doc, can you please resize the images used in plans.rst to be a maximum of 933px wide, ideally 768px wide.
Thank you! 🙏
meng-odoo
force-pushed
the
16.0-subscription-plans-meng
branch
from
ae71a4d to
22d7f20
Compare
|
Thank you @samueljlieber! I incorporated your edits (and added an image while I was at it) in the latest commit. Requesting your review again just in case :) |
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
Hi @meng-odoo! This PR is good to go 🚀 great job! @StraubCreative sending this to you for final review!
StraubCreative
left a comment
StraubCreative
left a comment
There was a problem hiding this comment.
Nice work @meng-odoo 🎉
@robodoo r+
closes #4343 Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
5 participants
Update to the emergency subscriptions update for Odoo 16 (eliminating subscription templates from Odoo 15).
Related to task #3222232