[ADD] accounting: VAT units #4375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
toaa-odoo
force-pushed
the
15.0-vat-units-toaa
branch
from
1855e63 to
bdbd421
Compare
Closed
LoredanaLrpz
requested changes
May 12, 2023
Contributor
There was a problem hiding this comment.
Hey @toaa-odoo , as always, a great doc!
Here are my suggestions on what IMO could be improved.
Also, I think the task ref should be written task-2557013 in the commit msg (the tampermonkey sript works, though)
See you! =D
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
toaa-odoo
force-pushed
the
15.0-vat-units-toaa
branch
2 times, most recently
from
d1d2487 to
9ec43cf
Compare
LoredanaLrpz
approved these changes
May 16, 2023
Contributor
LoredanaLrpz
left a comment
LoredanaLrpz
left a comment
There was a problem hiding this comment.
Hey, I'm approving this but I have one comment that you should take into account before asking be-doc to r+
Have a nice one!
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
toaa-odoo
force-pushed
the
15.0-vat-units-toaa
branch
from
9ec43cf to
3f4703e
Compare
jcs-odoo
requested changes
May 17, 2023
Contributor
jcs-odoo
left a comment
jcs-odoo
left a comment
There was a problem hiding this comment.
I scan-read this PR but from a structure point of view (and considering our restructuration) shouldn't this go to "getting started", @toaa-odoo ? Same as "VAT return" that is in reporting and not in "taxes".
Also, please do not add "vat-unit" as a prefix to all your media files.
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/vat_units.rst
Outdated
Show resolved
Hide resolved
toaa-odoo
force-pushed
the
15.0-vat-units-toaa
branch
2 times, most recently
from
3bcaa46 to
b04a120
Compare
jcs-odoo
approved these changes
May 23, 2023
Contributor
jcs-odoo
left a comment
jcs-odoo
left a comment
There was a problem hiding this comment.
I "scan-reviewed" it since @LoredanaLrpz approved it already. I just have a doubt about a word.
@robodoo delegate+
content/applications/finance/accounting/get_started/vat_units.rst
Outdated
Show resolved
Hide resolved
task-2557013 16.0: Line 36 = "Create" --> "New"
toaa-odoo
force-pushed
the
15.0-vat-units-toaa
branch
from
b04a120 to
0860901
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 23, 2023
task-2557013 16.0: Line 36 = "Create" --> "New" closes #4375 Signed-off-by: Aarab Tom (toaa) <toaa@odoo.com>
This was referenced May 23, 2023
This was referenced May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-2557013
16.0: Line 36 = "Create" --> "New"