Skip to content

[IMP] inventory: update inventory adjustments #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] inventory: update inventory adjustments #4435

wants to merge 1 commit into from

Conversation

@brse-odoo
Copy link
Contributor

@brse-odoo brse-odoo commented May 15, 2023

This PR is an [IMP] targeting the inventory adjustments doc in Odoo's Inventory documentation.

Performed complete rewrite to the document for 15.0 to be fwd-ported (targeted revision for 16.0 to follow).

  • Completely rewrote the .rst file and added example flow instructions
  • Added additional screenshots
  • Rewrote and added to doc to make more robust and comprehensive than before

@robodoo
Copy link
Collaborator

robodoo commented May 15, 2023

Pull request status dashboard.

@brse-odoo brse-odoo self-assigned this May 15, 2023
@C3POdoo C3POdoo requested a review from a team May 15, 2023 16:28
@brse-odoo
Copy link
Contributor Author

brse-odoo commented May 15, 2023

Hi @jero-odoo and @larm-odoo, this new PR is ready for a first round of peer review whenever one of you gets the chance. Thanks very much in advance!

larm-odoo
larm-odoo reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo - tis is a great doc! Also, the first I have reviewed. I admit this was difficult to read and comprehend in just RST- but I tried. I hope I didn't add to many headaches, but I had some questions that popped up as I did this and added those thoughts in here. Any questions, let me know- but this is great!

@brse-odoo brse-odoo force-pushed the 15.0-inventory-adjustments-brse branch from 4ac8dff to dcf4f3b Compare May 17, 2023 14:58
@brse-odoo
Copy link
Contributor Author

brse-odoo commented May 17, 2023

@odoo/us-doc-review This PR is ready for review.

@brse-odoo brse-odoo requested a review from a team May 17, 2023 15:30
ksc-odoo
ksc-odoo reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brse-odoo just finished my peer review of this doc. most adjustments are minor and focused on maintaining present tense (replacing "will" with "is", etc.). If you have any questions or need clarification on anything, don't hesitate to reach out. Great job! 👍

@brse-odoo brse-odoo force-pushed the 15.0-inventory-adjustments-brse branch from dcf4f3b to 6b221ae Compare May 22, 2023 20:26
@brse-odoo
Copy link
Contributor Author

brse-odoo commented May 22, 2023

@samueljlieber This PR has passed two rounds of peer review and is ready for your technical review whenever you have a chance. Thank you in advance!

@brse-odoo brse-odoo requested a review from samueljlieber May 22, 2023 20:33
samueljlieber
samueljlieber requested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo 👋 great job on the improvement of this doc! I have a couple technical changes throughout, please see below and tag me for another review once this PR is ready. Thank you!

@brse-odoo brse-odoo force-pushed the 15.0-inventory-adjustments-brse branch from 6b221ae to 2ccb54e Compare May 25, 2023 14:04
@brse-odoo
Copy link
Contributor Author

brse-odoo commented May 25, 2023

@samueljlieber I made the requested technical changes and pushed up the revisions. Back to you!

@brse-odoo brse-odoo requested a review from samueljlieber May 25, 2023 14:31
samueljlieber
samueljlieber requested changes May 30, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo nice job on the improvements to this doc 👍 I have a few technical changes and two points of discussion for button/icon descriptions. Overall this PR is looking really great! Tag me again for another look once these updates have been made 🙂

@brse-odoo brse-odoo force-pushed the 15.0-inventory-adjustments-brse branch from 2ccb54e to e160dbe Compare May 31, 2023 13:53
@brse-odoo
Copy link
Contributor Author

brse-odoo commented May 31, 2023

@samueljlieber I made the requested technical changes and pushed up the revisions. Back to you!

@brse-odoo brse-odoo requested a review from samueljlieber May 31, 2023 14:09
samueljlieber
samueljlieber approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo great work! This PR looks good to me, moving forward to final review! 🙂

@brse-odoo brse-odoo requested review from StraubCreative and removed request for StraubCreative June 26, 2023 18:25
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Jun 26, 2023

Hi @StraubCreative This PR is ready for final review whenever you have a chance, thank you 👍

@brse-odoo brse-odoo requested a review from a team July 26, 2023 18:03
meng-odoo
meng-odoo suggested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@meng-odoo meng-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @brse-odoo! I've done a final review of this doc. It's super well written, great job! :) I just had very tiny changes/suggestions. Please let me know if you have any questions!

@brse-odoo brse-odoo force-pushed the 15.0-inventory-adjustments-brse branch from e160dbe to 9fbcee4 Compare August 2, 2023 15:28
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Aug 2, 2023

Implemented changes and pushed up revisions from @meng-odoo's final content review - thank you, meng!

@samueljlieber, this PR is ready for your final technical review before sending off to r+. Thank you in advance!

samueljlieber
samueljlieber approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo well done! This PR looks good to me 🙂 moving on to @StraubCreative 👍

StraubCreative
StraubCreative approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with comments
merge whenever you're ready @brse-odoo :)

cc: @samueljlieber there's a comment for you regarding dfn tag. See below.

@robodoo delegate=brse-odoo

@brse-odoo brse-odoo force-pushed the 15.0-inventory-adjustments-brse branch from 9fbcee4 to e4f0560 Compare August 8, 2023 17:59
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Aug 8, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request Aug 8, 2023
@brse-odoo
[IMP] inventory: update inventory adjustments
3da457a 
closes #4435

Signed-off-by: Brandon Seltenrich (brse) <brse@odoo.com>
@robodoo robodoo temporarily deployed to merge August 8, 2023 19:09 Inactive
@robodoo robodoo closed this Aug 8, 2023
This was referenced Aug 8, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueljlieber samueljlieber samueljlieber approved these changes

@larm-odoo larm-odoo larm-odoo left review comments

@StraubCreative StraubCreative StraubCreative approved these changes

+2 more reviewers

@ksc-odoo ksc-odoo ksc-odoo left review comments

@meng-odoo meng-odoo meng-odoo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brse-odoo brse-odoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@brse-odoo @robodoo @StraubCreative @samueljlieber @ksc-odoo @meng-odoo @larm-odoo