Skip to content

Conversation

@toaa-odoo
Copy link
Contributor

Seperating Incoterms section from "Intrastat" doc to make it a stand alone documentation.

task-3305222

@robodoo
Copy link
Collaborator

robodoo commented May 31, 2023

@toaa-odoo toaa-odoo force-pushed the 16.0-incoterms-toaa branch from 3418379 to 98ad344 Compare May 31, 2023 12:50
@toaa-odoo toaa-odoo marked this pull request as ready for review May 31, 2023 13:03
@C3POdoo C3POdoo requested a review from a team May 31, 2023 13:23
@toaa-odoo toaa-odoo force-pushed the 16.0-incoterms-toaa branch from 98ad344 to f3ab3fc Compare May 31, 2023 13:30
@toaa-odoo toaa-odoo removed the request for review from a team May 31, 2023 13:30
@dade-odoo dade-odoo self-requested a review June 1, 2023 08:08
Copy link
Contributor

@dade-odoo dade-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom!

Great PR - I made a few comments about the structure and the need to include instructions on how to create additional Incoterms.

Also, Loredana and I both agree that Reporting isn't the best section for Incoterms. Perhaps Customer invoices instead?

@toaa-odoo toaa-odoo force-pushed the 16.0-incoterms-toaa branch from f3ab3fc to faccfec Compare June 1, 2023 13:08
@toaa-odoo
Copy link
Contributor Author

@dade-odoo Thanks for your review! I addressed the few points you mentioned. As for the location of the doc, Jon put Intrastat here, and since he wanted to split from Incoterms, I figured it should be in the same place

@toaa-odoo toaa-odoo force-pushed the 16.0-incoterms-toaa branch from faccfec to cc5ed78 Compare June 1, 2023 13:13
@toaa-odoo toaa-odoo requested a review from dade-odoo June 1, 2023 13:13
Copy link
Contributor

@dade-odoo dade-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @toaa-odoo :)

@dade-odoo dade-odoo requested a review from a team June 1, 2023 13:57
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

  • change commit message and pr title:

@jcs-odoo
Copy link
Contributor

jcs-odoo commented Jun 1, 2023

UUUh sorry I pressed ctrl+enter by mistake, I just started reviewing :)

@jcs-odoo jcs-odoo self-requested a review June 1, 2023 14:20
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @toaa-odoo and @dade-odoo

Looks good :)
Please change the commit message and pr title: [ADD] accounting: incoterms

Also, now that I read this intro, I don't think it belongs to the reporting section. I guess it is mostly useful for customer invoices to define the responsibility of the customer. wdyt?

Cheers, Jonathan

@toaa-odoo toaa-odoo changed the title [ADD] Incoterms doc [ADD] accounting: incoterms Jun 2, 2023
@toaa-odoo toaa-odoo force-pushed the 16.0-incoterms-toaa branch from cc5ed78 to 6259147 Compare June 2, 2023 07:09
@toaa-odoo toaa-odoo requested a review from jcs-odoo June 2, 2023 07:10
Seperating Incoterms section from "Intrastat" doc to make it a stand
alone documentation.

task-3305222
@jcs-odoo jcs-odoo force-pushed the 16.0-incoterms-toaa branch from 6259147 to 479567f Compare June 2, 2023 08:24
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants