Skip to content

Conversation

@BHanq
Copy link

@BHanq BHanq commented Jun 8, 2023

Preview

image

@BHanq BHanq requested a review from sts-odoo June 8, 2023 13:40
@robodoo
Copy link
Collaborator

robodoo commented Jun 8, 2023

@C3POdoo C3POdoo requested review from a team June 8, 2023 14:02
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, let's switch to a list table as they're easier to maintain and have additional features.

Thanks :)

@BHanq BHanq requested a review from jcs-odoo June 9, 2023 08:57
Add the Upgrade submenu, Fix the Settings submenu to User only in
staging branches and improve the style in order to be similar to
supported versions matrix
(https://www.odoo.com/documentation/16.0/administration/maintain/supported_versions.html)
@lse-odoo
Copy link
Contributor

lse-odoo commented Jun 9, 2023

@jcs-odoo hey :) this is the PR of my newbie, would you mind reviewing it now that he made the change.
I also noticed that the branch name might be wrong, as I'm not used to the documentation conventions, can you confirm to us if it is okay or not please ?

@jcs-odoo jcs-odoo changed the title [IMP] Odoo.sh Settings Collaborators access matrix [IMP] odoo.sh: settings collaborators access matrix Jun 9, 2023
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @BHanq and @lse-odoo

I took the liberty to squash your two commits (because we want to have only one commit) and rebase them (because there was a bug in the documentation build that was solved this morning)

Regarding the name of the commit, you can learn more about it in the commit message template which can also be set up as default commit message in your local environment as described in the contributing documentation.

As for the workflow, I see that you created a fork of the repository, and made your changes directly on the "main" branch 14.0. For Odoo employees, it is possible to work and push on the odoo/documentation repository (also explained in the contributing doc) but then you can't work on the "main" branches and you have to create new working branches. For example, here it could have been 14.0-sh-matrix-beha.

If you want to work more on the documentation, we can discuss this more :) Otherwise, it's all good like this ^^

Thanks and have a good day both of you!

@robodoo r+

@amigrave
Copy link
Member

amigrave commented Jun 9, 2023

@jcs-odoo this does not look right to me, please don't merge

robodoo pushed a commit that referenced this pull request Jun 9, 2023
Add the Upgrade submenu, Fix the Settings submenu to User only in
staging branches and improve the style in order to be similar to
supported versions matrix
(https://www.odoo.com/documentation/16.0/administration/maintain/supported_versions.html)

closes #4663

Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
@amigrave
Copy link
Member

amigrave commented Jun 9, 2023

@jcs-odoo ok my bad, I was thinking about a change that we will do but is not yet even in development so this grid is correct in the current state of the platform, sorry for the noise.

@BHanq
Copy link
Author

BHanq commented Jun 9, 2023

@jcs-odoo Great thanks for the broad explanation !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants