-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[IMP] odoo.sh: settings collaborators access matrix #4663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, let's switch to a list table as they're easier to maintain and have additional features.
Thanks :)
Add the Upgrade submenu, Fix the Settings submenu to User only in staging branches and improve the style in order to be similar to supported versions matrix (https://www.odoo.com/documentation/16.0/administration/maintain/supported_versions.html)
|
@jcs-odoo hey :) this is the PR of my newbie, would you mind reviewing it now that he made the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to squash your two commits (because we want to have only one commit) and rebase them (because there was a bug in the documentation build that was solved this morning)
Regarding the name of the commit, you can learn more about it in the commit message template which can also be set up as default commit message in your local environment as described in the contributing documentation.
As for the workflow, I see that you created a fork of the repository, and made your changes directly on the "main" branch 14.0. For Odoo employees, it is possible to work and push on the odoo/documentation repository (also explained in the contributing doc) but then you can't work on the "main" branches and you have to create new working branches. For example, here it could have been 14.0-sh-matrix-beha.
If you want to work more on the documentation, we can discuss this more :) Otherwise, it's all good like this ^^
Thanks and have a good day both of you!
@robodoo r+
|
@jcs-odoo this does not look right to me, please don't merge |
Add the Upgrade submenu, Fix the Settings submenu to User only in staging branches and improve the style in order to be similar to supported versions matrix (https://www.odoo.com/documentation/16.0/administration/maintain/supported_versions.html) closes #4663 Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
|
@jcs-odoo ok my bad, I was thinking about a change that we will do but is not yet even in development so this grid is correct in the current state of the platform, sorry for the noise. |
|
@jcs-odoo Great thanks for the broad explanation ! |
Preview