[IMP] reference/user_interface: reformat and clarify views reference #5237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
C3POdoo
requested review from
a team,
rco-odoo and
xmo-odoo
and removed request for
a team
AntoineVDV
force-pushed
the
master-ref-views-anv
branch
3 times, most recently
from
f57bcf8 to
55d97c0
Compare
AntoineVDV
changed the title
AntoineVDV
force-pushed
the
master-ref-views-anv
branch
from
55d97c0 to
ccccf49
Compare
AntoineVDV
force-pushed
the
master-ref-views-anv
branch
5 times, most recently
from
504fea3 to
7f375c4
Compare
C3POdoo
requested review from
a team,
ryv-odoo and
xmo-odoo
and removed request for
a team
Feyensv
reviewed
Jan 16, 2024
Collaborator
Feyensv
left a comment
Feyensv
left a comment
There was a problem hiding this comment.
Very nice work already 👍
content/developer/reference/user_interface/view_architectures/button_attribute_name.rst
Outdated
Show resolved
Hide resolved
content/developer/reference/user_interface/view_architectures/button_attribute_type.rst
Outdated
Show resolved
Hide resolved
content/developer/reference/user_interface/view_architectures.rst
Outdated
Show resolved
Hide resolved
content/developer/reference/user_interface/view_architectures.rst
Outdated
Show resolved
Hide resolved
content/developer/reference/user_interface/view_architectures.rst
Outdated
Show resolved
Hide resolved
In particular, the following changes are made: - Use the `class` and `attribute` admonitions along with custom attributes to define classes, views' root attributes, views' components, and attribute values. This allows re-using the responsive design that was made for reference lists, and getting rid of the previous implementation that relied on class attributes, which were not intended for this usage and reduce readability while hindering further contributions due to a lack of flexibility (no admonitions, sub-attributes...) - Use definition lists to define view types to allow for clearer and longer descriptions. - Rewrite and restructure the explanations when there is a lack clarity. - Extract duplicated content to included RST files. - Display SVG images into dedicated admonitions. - Fix RST and English mistakes. - Rename `view_architecture` to `view_architectures`, as it lists all existing architectures and doesn't describe "the architecture of a view". - Replace underscores with hyphens in image file names to improve SEO. task-3458320
AntoineVDV
force-pushed
the
master-ref-views-anv
branch
from
3a72330 to
d36576d
Compare
Collaborator
Author
|
@robodoo r+ |
AntoineVDV
added a commit
that referenced
this pull request
Jan 22, 2024
In particular, the following changes are made: - Use the `class` and `attribute` admonitions along with custom attributes to define classes, views' root attributes, views' components, and attribute values. This allows re-using the responsive design that was made for reference lists, and getting rid of the previous implementation that relied on class attributes, which were not intended for this usage and reduce readability while hindering further contributions due to a lack of flexibility (no admonitions, sub-attributes...) - Use definition lists to define view types to allow for clearer and longer descriptions. - Rewrite and restructure the explanations when there is a lack clarity. - Extract duplicated content to included RST files. - Display SVG images into dedicated admonitions. - Fix RST and English mistakes. - Rename `view_architecture` to `view_architectures`, as it lists all existing architectures and doesn't describe "the architecture of a view". - Replace underscores with hyphens in image file names to improve SEO. task-3458320 closes #5237 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Jan 23, 2024
In particular, the following changes are made: - Use the `class` and `attribute` admonitions along with custom attributes to define classes, views' root attributes, views' components, and attribute values. This allows re-using the responsive design that was made for reference lists, and getting rid of the previous implementation that relied on class attributes, which were not intended for this usage and reduce readability while hindering further contributions due to a lack of flexibility (no admonitions, sub-attributes...) - Use definition lists to define view types to allow for clearer and longer descriptions. - Rewrite and restructure the explanations when there is a lack clarity. - Extract duplicated content to included RST files. - Display SVG images into dedicated admonitions. - Fix RST and English mistakes. - Rename `view_architecture` to `view_architectures`, as it lists all existing architectures and doesn't describe "the architecture of a view". - Replace underscores with hyphens in image file names to improve SEO. task-3458320 closes #5237 closes #7453 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
fw-bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
In particular, the following changes are made: - Use the `class` and `attribute` admonitions along with custom attributes to define classes, views' root attributes, views' components, and attribute values. This allows re-using the responsive design that was made for reference lists, and getting rid of the previous implementation that relied on class attributes, which were not intended for this usage and reduce readability while hindering further contributions due to a lack of flexibility (no admonitions, sub-attributes...) - Use definition lists to define view types to allow for clearer and longer descriptions. - Rewrite and restructure the explanations when there is a lack clarity. - Extract duplicated content to included RST files. - Display SVG images into dedicated admonitions. - Fix RST and English mistakes. - Rename `view_architecture` to `view_architectures`, as it lists all existing architectures and doesn't describe "the architecture of a view". - Replace underscores with hyphens in image file names to improve SEO. task-3458320 closes #5237 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> X-original-commit: a17eaf4
Collaborator
|
@AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): |
robodoo
pushed a commit
that referenced
this pull request
Jan 23, 2024
In particular, the following changes are made: - Use the `class` and `attribute` admonitions along with custom attributes to define classes, views' root attributes, views' components, and attribute values. This allows re-using the responsive design that was made for reference lists, and getting rid of the previous implementation that relied on class attributes, which were not intended for this usage and reduce readability while hindering further contributions due to a lack of flexibility (no admonitions, sub-attributes...) - Use definition lists to define view types to allow for clearer and longer descriptions. - Rewrite and restructure the explanations when there is a lack clarity. - Extract duplicated content to included RST files. - Display SVG images into dedicated admonitions. - Fix RST and English mistakes. - Rename `view_architecture` to `view_architectures`, as it lists all existing architectures and doesn't describe "the architecture of a view". - Replace underscores with hyphens in image file names to improve SEO. task-3458320 closes #5237 closes #7497 X-original-commit: a17eaf4 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the following changes are made:
Use the
classandattributeadmonitions along with custom attributes to define classes, views' root attributes, views' components, and attribute values. This allows re-using the responsive design that was made for reference lists, and getting rid of the previous implementation that relied on class attributes, which were not intended for this usage and reduce readability while hindering further contributions due to a lack of flexibility (no admonitions, sub-attributes...)Use definition lists to define view types to allow for clearer and longer descriptions.
Rewrite and restructure the explanations when there is a lack clarity.
Extract duplicated content to included RST files.
Display SVG images into dedicated admonitions.
Fix RST and English mistakes.
Rename
view_architecturetoview_architectures, as it lists all existing architectures and doesn't describe the "architecture of a view".Replace underscores with hyphens in image file names to improve SEO.
task-3458320