Skip to content

[IMP] barcode: update barcode operations doc #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] barcode: update barcode operations doc #5559

wants to merge 1 commit into from

Conversation

@brse-odoo
Copy link
Contributor

@brse-odoo brse-odoo commented Aug 21, 2023

This PR is an [IMP] targeting the previously-named internal doc in Odoo's Inventory/Barcode documentation.

Performed complete rewrite to the document for 15.0 to be fwd-ported (targeted revision for 16.0 to follow).

  • Completely rewrote the .rst file
  • Replaced/added screenshots where appropriate
  • Rewrote and added to doc to make more robust and comprehensive than before

ALSO performed a [REF] on this doc: renamed to receipts_deliveries to more accurately reflect the content of the doc. Added a redirect in the .txt file to account for this

@brse-odoo brse-odoo self-assigned this Aug 21, 2023
@robodoo
Copy link
Collaborator

robodoo commented Aug 21, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested review from a team August 21, 2023 19:22
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Aug 21, 2023

Hi @odoo/inventory-doc-review this PR is ready for the first round of content peer review when you have a chance. Thanks!

Felicious
Felicious requested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement on this barcode doc!! Your writing is clear and you go into detail explaining many aspects of the UI. The updated screenshots for Odoo 15 is great too 😄

Most of my changes are small: honing in on formatting and ensuring the entire doc follows the US Doc conventions. Since our last meeting about this was back in April, maybe we need to reconvene to make sure we still agree 🤷 As such, my suggestions can be challenged if you disagree! 😉

Shoot me a DM if you need any clarification on comments I made. And as always, this was pleasant to read! 😊

@brse-odoo brse-odoo force-pushed the 15.0-inventory-update-barcode-transfers-brse branch 2 times, most recently from 53cfbae to 90311d4 Compare August 30, 2023 13:59
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Aug 30, 2023

Hi @odoo/crm-doc-review This PR has passed the first round of peer review and is now ready for the second round when one of you has a chance. Thank you!

@brse-odoo brse-odoo requested a review from a team August 30, 2023 14:23
ksc-odoo
ksc-odoo reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brse-odoo Just finished Peer Reviewing this doc. Fantastic job. Only a few minor things to look at. Nice work! 👍

@brse-odoo brse-odoo force-pushed the 15.0-inventory-update-barcode-transfers-brse branch from 90311d4 to 0459c87 Compare September 13, 2023 16:01
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Sep 13, 2023

Hi @odoo/us-doc-review, this PR has passed the first two rounds of content review and is ready for the final round when one of you has a chance. Thank you!

@brse-odoo brse-odoo requested a review from a team September 13, 2023 16:07
@StraubCreative
Copy link
Contributor

StraubCreative commented Sep 13, 2023

Hi @brse-odoo can you take a look at the failed check and fix before we review? Plz/ty!

jcs-odoo
jcs-odoo reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For docs-structure, it seems that the redirection doesn't require an update of a doc link in the product.

cc @xpl-odoo

@brse-odoo brse-odoo force-pushed the 15.0-inventory-update-barcode-transfers-brse branch 2 times, most recently from 547f7f0 to b9a8b75 Compare October 2, 2023 14:02
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Oct 2, 2023

Hi @brse-odoo can you take a look at the failed check and fix before we review? Plz/ty!

Hi @StraubCreative, just fixed the failed check (thank you SALI) and this is now ready for your final review! Thanks

samueljlieber
samueljlieber approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo! Nice job with this PR! I am approving now, however please see the couple suggestions I have below before moving forward. Thank you!

@brse-odoo brse-odoo force-pushed the 15.0-inventory-update-barcode-transfers-brse branch from b9a8b75 to 94d33f9 Compare December 20, 2023 16:20
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Dec 20, 2023

@odoo/us-doc-review This PR has passed the first 2 rounds of peer review, passed technical review by SALI, and is now ready to be reviewed/approved/merged by you. Thank you!

@brse-odoo brse-odoo requested a review from a team December 20, 2023 16:23
@samueljlieber samueljlieber force-pushed the 15.0-inventory-update-barcode-transfers-brse branch from 94d33f9 to 07170fb Compare December 21, 2023 17:00
samueljlieber
samueljlieber approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @brse-odoo! This PR looks great to me, and the redirect looks good 👍

@StraubCreative this PR is good to go!

@StraubCreative
Copy link
Contributor

StraubCreative commented Dec 22, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 22, 2023
@brse-odoo @samueljlieber
[IMP] barcode: update barcode operations doc
0c628f6 
closes #5559

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Dec 22, 2023
@brse-odoo @samueljlieber
[IMP] barcode: update barcode operations doc
170eda0 
closes #5559

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo robodoo closed this Dec 22, 2023
This was referenced Dec 22, 2023
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Dec 26, 2023

@brse-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

This was referenced Dec 26, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcs-odoo jcs-odoo jcs-odoo left review comments

@Felicious Felicious Felicious requested changes

@StraubCreative StraubCreative StraubCreative approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+1 more reviewer

@ksc-odoo ksc-odoo ksc-odoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@brse-odoo brse-odoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@brse-odoo @robodoo @StraubCreative @fw-bot @Felicious @samueljlieber @jcs-odoo @ksc-odoo