Skip to content

Conversation

@nmarotte
Copy link
Contributor

@nmarotte nmarotte commented Sep 8, 2023

Draft PR for pre-reviewed as asked by anv in 3440903

@robodoo
Copy link
Collaborator

robodoo commented Sep 8, 2023

This PR targets the un-managed branch odoo/documentation:staging.16.0, it needs to be retargeted before it can be merged.

@nmarotte nmarotte force-pushed the 16.0-upgrade_doc-nama branch 2 times, most recently from 086f633 to 7b1ca05 Compare September 8, 2023 11:44
@robodoo robodoo force-pushed the staging.16.0 branch 15 times, most recently from c1c09f5 to 81d33ed Compare September 12, 2023 09:14
@nmarotte nmarotte force-pushed the 16.0-upgrade_doc-nama branch from 7b1ca05 to 1d17e5d Compare September 12, 2023 09:35
@nmarotte nmarotte force-pushed the 16.0-upgrade_doc-nama branch from 1d17e5d to 86a2aed Compare September 12, 2023 09:36
@robodoo robodoo force-pushed the staging.16.0 branch 3 times, most recently from fff3876 to 167bb06 Compare September 13, 2023 08:30
@AntoineVDV AntoineVDV changed the base branch from staging.16.0 to 16.0 September 13, 2023 09:18
@robodoo
Copy link
Collaborator

robodoo commented Sep 13, 2023

@nmarotte nmarotte force-pushed the 16.0-upgrade_doc-nama branch from c87f803 to fe8346d Compare September 14, 2023 12:57
@nmarotte nmarotte force-pushed the 16.0-upgrade_doc-nama branch from fe8346d to 7a4af5a Compare September 14, 2023 12:58
@nmarotte nmarotte force-pushed the 16.0-upgrade_doc-nama branch from 31d007d to fdcc7af Compare September 14, 2023 14:36
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

It's great you're dedicated to improve the documentation for the database upgrades, thanks :)

I'd like to discuss this together, to find what's best but I'll already write some things here:

  • In general, I think the content is needlessly long.

    Writing for documentation isn’t the same as writing for a blog or another medium. Readers are more likely to skim read until they’ve found the information they are looking for.

    See content guidelines: writing style
    Most of the time the text is written the same way you would talk to someone, or in a long book, or live presentation.

  • Bad use of the future tense

  • No need to explain again the same thing in all pages. If the info is already written somewhere, it is better to refer to it with custom anchor links or documentation links, rather than rewriting it. Two upsides to this: shorter texts make it easier for readers to find the exact info they need, and it reduces the maintenance of the documentation.

    • For example, re-explaining that Odoo supports the three latest versions --> link to the supported versions page
    • Similarly, I'm not in favor of FAQ sections in the documentation because they duplicate the same content in a different form. Instead, it is best to provide links at the beginning of a page, like a menu ("to do this, consult this")
  • I won't accept to put "Upgrade" at the root level of the documentation like this: upgrading a database would be way too over-represented in the structure.

    • Just so you know, we interrupted a restructuration of this install/maintain section as we currently don't have the time to implement it, but we also considered renaming that section "database management", which you may find more acceptable as a parent category :)
  • "Advanced" categories are to avoid at all costs: that name is barely more helpful than "miscellaneous". Topics shouldn't be categorized per difficulty but per theme.

  • If possible, I suggest the use of group tabs as well for the request processes.

But let's plan a meeting with me and @xpl-odoo to discuss all this (and more), it will be more efficient :)

Again, it's really nice to see your dedication to improving the documentation! 😊

Cheers,
Jonathan

@AntoineVDV AntoineVDV removed their request for review September 18, 2023 15:09
@nmarotte
Copy link
Contributor Author

Hello @jcs-odoo

Thanks for your input :) Actually the documentation is still a work in progress but I was asked by ANV to request review from you, I should have written it was not ready to be fully reviewed yet

I agree with all of your points and will take that into account when working on this. I'm still in the process of rewriting most parts of the text, as the text was first inteded for a smartclass where the context is different

@nmarotte nmarotte force-pushed the 16.0-upgrade_doc-nama branch from 5c99adc to 8eef600 Compare September 21, 2023 06:42
@nmarotte
Copy link
Contributor Author

nmarotte commented Nov 2, 2023

Closing due to #5953 being the main PR, this can still serve as a backup in case I need to copy-paste some stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants