[ADD] Quality: Pass - Fail quality checks #5884
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hojo-odoo
force-pushed
the
16.0-quality-add-pass-fail-check-hojo
branch
from
1918d79 to
4b1510c
Compare
Contributor
|
@odoo/us-doc-review |
hojo-odoo
force-pushed
the
16.0-quality-add-pass-fail-check-hojo
branch
from
4b1510c to
1eeaa7a
Compare
hojo-odoo
force-pushed
the
16.0-quality-add-pass-fail-check-hojo
branch
from
1eeaa7a to
4fa3c4d
Compare
Felicious
approved these changes
Nov 17, 2023
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
This is a really really solid doc, @hojo-odoo 😄
It's concise and really easy to follow. I just had some minor typos I found and a VS Code tip I wanted to share. I think it'll be helpful for you while working on a lot of duplicate content 😊
Go ahead and pass this to the next reviewer after fixing the typos!
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
16.0-quality-add-pass-fail-check-hojo
branch
from
4fa3c4d to
8f48fd9
Compare
ksc-odoo
approved these changes
Nov 17, 2023
Contributor
ksc-odoo
left a comment
ksc-odoo
left a comment
There was a problem hiding this comment.
@hojo-odoo great work on this doc! once you give these suggested edits a look, and implement the necessary adjustments, I think this one will be ready for the next stage. nicely done 👍
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
16.0-quality-add-pass-fail-check-hojo
branch
from
8f48fd9 to
81a1770
Compare
samueljlieber
requested changes
Nov 20, 2023
Contributor
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
Hi @hojo-odoo! Nice work on this PR 🙂 I have only one small change after my technical review. I will push up this change after this review to move this PR forward!
Thank you!
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
samueljlieber
force-pushed
the
16.0-quality-add-pass-fail-check-hojo
branch
from
81a1770 to
d2a4caa
Compare
Contributor
|
Implemented my change in d2a4caa. This PR is all set @StraubCreative 👍 |
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 21, 2023
closes #5884 Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new doc detailing how to create and process Pass - Fail quality checks.
NOTE: One of the checks is failing because the PR contains a reference to the "Quality checks" doc, which is not yet live. That doc should be live before this one, at which point the ref tags in this doc will work as intended.