Skip to content

Conversation

@brse-odoo
Copy link
Contributor

This PR is an [IMP] targeting the transfers_scratch doc in Odoo's Inventory/Barcode documentation.

Performed complete rewrite to the document for 15.0 to be fwd-ported (targeted revision for 16.0 to follow).

  • Completely rewrote the .rst file
  • Replaced/added screenshots where appropriate
  • Rewrote and added to doc to make more robust and comprehensive than before

@brse-odoo brse-odoo self-assigned this Oct 9, 2023
@brse-odoo brse-odoo requested a review from a team October 9, 2023 18:28
@robodoo
Copy link
Collaborator

robodoo commented Oct 9, 2023

@brse-odoo
Copy link
Contributor Author

@odoo/inventory-doc-review This PR is ready for the first round of content peer review!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo!

Amazing job on the rewrite of the doc, as usual! 😊 This doc has sooo much more detailed info now, and I can't wait for it be published. I only had a few optional wording suggestions to beef the doc up with even more knowledge. I also had some thoughts about adding some details about the "receive in 2 or 3 steps" flow, but I'm wondering if it's too nitty gritty. All up to you to decide!

It's getting late so I'm submitting suggestions for the first half of the doc; I'll get to the other half soon 😄 Talk to you more tomorrow~

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @brse-odoo ! Just finished my review of the doc and it's really good at explaining how Inventory integrates with Barcode, and combining the irl elements of barcode scanning to update the info in the database ☺️

Most of my feedback is optional wording suggestions. I just pointed out a few minor errors about the default source location in a barcode operation, which is super minor in the grand scheme of things. Let me know if you have any questions about my info/idea dumps. I'm quite sure we can move this to the next stage after my second look, so let me know when it's ready 😄

@brse-odoo brse-odoo force-pushed the 15.0-barcode-update-transfer-scratch-brse branch from 8c07873 to a1f3e43 Compare October 11, 2023 14:52
@brse-odoo
Copy link
Contributor Author

@Felicious Thanks for looking this over! I've pushed up a revised version of this if you want to take a second look 👍

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo 😄
The doc looks great and it's ready to move onto the next stage of review ✨

I had a very minor thing to add to the last section, because I realized that there are multiple ways to navigate to the "create transfers from scratch" screen, so I wanted to tell you about it. Feel free to choose how much (if at all 😂) of that input you implement. If anything, it seems like it would be good for you know 😊

Most of my feedback is because I was able to work/test with a Zebra scanner, and your doc encompasses how Odoo Barcode is used as a smartphone mobile scanner. So, it's really cool to see you consolidate the two different ways of using the app in a single doc 💟 Again, amazing job on the doc!

@brse-odoo brse-odoo force-pushed the 15.0-barcode-update-transfer-scratch-brse branch from a1f3e43 to 74b8613 Compare December 11, 2023 18:10
@brse-odoo
Copy link
Contributor Author

Hi @odoo/crm-doc-review, this PR has passed the first round of content review, and is now ready for the second round. Thank you in advance!

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brse-odoo great job on this doc. Just a few minor suggestions that need your attention, and once those are addressed, this should be ready to move on to the next stage. 👍

@brse-odoo brse-odoo force-pushed the 15.0-barcode-update-transfer-scratch-brse branch from 74b8613 to b969414 Compare December 20, 2023 15:34
@brse-odoo
Copy link
Contributor Author

@odoo/us-doc-review This PR has passed the first 2 rounds of content review, and is now ready for final review. Thank you!

@brse-odoo brse-odoo requested a review from a team December 20, 2023 15:54
@samueljlieber samueljlieber force-pushed the 15.0-barcode-update-transfer-scratch-brse branch from b969414 to 10b42b0 Compare December 21, 2023 16:40
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo nice job on this PR! Everything looks good to me! I pushed up a commit updating an image since even though it was compressed, its filesize was very large. I retook the screenshot and recompressed. Approving now!

@StraubCreative this PR is good to go! 👍

@StraubCreative
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 22, 2023
closes #6077

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Dec 22, 2023
closes #6077

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo robodoo closed this Dec 22, 2023
@fw-bot
Copy link
Collaborator

fw-bot commented Dec 26, 2023

@brse-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants