Skip to content

[FW][IMP] barcode: split docs + hone in on language #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FW][IMP] barcode: split docs + hone in on language #6520

wants to merge 1 commit into from

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 17, 2023

Summary

Improve wording about GS1 barcode concepts.

  • Received feedback from CRU about barcode conceptual accuracy and changed the wording to reflect it
  • Created scannable 2D matrix barcodes (they look like QR codes) for readers to try scanning!
  • Received feedback from hojo to split the docs into two so it's easier for readers to search for GS1 nomenclature (setup) vs. using GS1 barcodes in their warehouse workflow.
  • Received feedback from ZST about honing in on language surrounding creating GS1 barcodes. Need to make it very clear that Odoo doesn't generate GS1 barcodes for users! We just take in their inputs. Can reviewers make sure that my doc makes this very clear? (:

Thanks 😸

Forward-Port-Of: #6492
Forward-Port-Of: #5592

@Felicious @samueljlieber
@brse-odoo @StraubCreative
[IMP] barcode: split docs + hone in on language
8ff8a6b 
X-original-commit: 9081e45
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
Co-authored-by: brse-odoo <brse@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
@robodoo
Copy link
Collaborator

robodoo commented Nov 17, 2023

Pull request status dashboard.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 17, 2023

@Felicious @StraubCreative this PR targets master and is the last of the forward-port chain containing:

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@StraubCreative
Copy link
Contributor

StraubCreative commented Nov 17, 2023

@fw-bot r+

robodoo pushed a commit that referenced this pull request Nov 18, 2023
@Felicious @samueljlieber
@brse-odoo @StraubCreative
[IMP] barcode: split docs + hone in on language
f101ba0 
closes #6520

X-original-commit: 9081e45
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
Co-authored-by: brse-odoo <brse@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
@robodoo
Copy link
Collaborator

robodoo commented Nov 18, 2023

@Felicious @StraubCreative staging failed: ci/runbot on eb5262f5c2efd4c579e790b0983b53b8d9caf722 (view more at https://runbot.odoo.com/runbot/build/53890752)

@StraubCreative
Copy link
Contributor

StraubCreative commented Nov 18, 2023

@robodoo retry

@robodoo
Copy link
Collaborator

robodoo commented Nov 18, 2023

@Felicious @StraubCreative staging failed: ci/runbot on b0726422a9ed3840710ccf78660f9ca9b9c51102 (view more at https://runbot.odoo.com/runbot/build/53893771)

@StraubCreative
Copy link
Contributor

StraubCreative commented Nov 18, 2023

@robodoo retry

robodoo pushed a commit that referenced this pull request Nov 18, 2023
@Felicious @samueljlieber
@brse-odoo @StraubCreative
[IMP] barcode: split docs + hone in on language
4229c61 
closes #6520

X-original-commit: 9081e45
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
Co-authored-by: brse-odoo <brse@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
@robodoo
Copy link
Collaborator

robodoo commented Nov 18, 2023

@Felicious @StraubCreative staging failed: ci/runbot on bfff45b673c27246699dd9505455d3f6cc39920e (view more at https://runbot.odoo.com/runbot/build/53920247)

@d-fence
Copy link
Contributor

d-fence commented Nov 19, 2023

robodoo retry
Failing test deactivated

robodoo pushed a commit that referenced this pull request Nov 20, 2023
@Felicious @samueljlieber
@brse-odoo @StraubCreative
[IMP] barcode: split docs + hone in on language
246450c 
closes #6520

X-original-commit: 9081e45
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
Co-authored-by: brse-odoo <brse@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
@robodoo robodoo closed this Nov 20, 2023
@robodoo robodoo added the 17.1 label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

17.1 forwardport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fw-bot @robodoo @StraubCreative @d-fence @Felicious