Skip to content

[IMP] MRP: Update Manufacturing step docs for Shop Floor #6747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] MRP: Update Manufacturing step docs for Shop Floor #6747

wants to merge 1 commit into from

Conversation

@hojo-odoo
Copy link
Contributor

@hojo-odoo hojo-odoo commented Dec 1, 2023

This PR replaces the tablet view workflow in the One, Two, and Three-step manufacturing docs with a new section detailing the workflow for the Shop Floor module.

@robodoo
Copy link
Collaborator

robodoo commented Dec 1, 2023

Pull request status dashboard.

@samueljlieber samueljlieber force-pushed the 16.4-mrp-update-one-two-three-step-hojo branch from b6c75eb to 4efc6d2 Compare December 5, 2023 18:10
@samueljlieber
Copy link
Contributor

samueljlieber commented Dec 5, 2023

Rebased to latest in 4efc6d2

@samueljlieber samueljlieber changed the base branch from saas-16.4 to 16.0 December 5, 2023 18:15
@samueljlieber samueljlieber changed the base branch from 16.0 to saas-16.4 December 5, 2023 18:15
@C3POdoo C3POdoo requested a review from a team December 5, 2023 18:16
Felicious
Felicious approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with updating these manufacturing docs with the newest Shop Floor workflow, @hojo-odoo !

It's clear and easy to follow, and I like how you explained the behavior of the pop-ups and steps so thoroughly 😊

I just reviewed the Shop Floor workflow for the one-step manufacturing doc, like you suggested. Let me know if I missed anything!

I just had a few minor nitpicks about formatting. Feel free to contest these suggestions, especially if you think I'm wrong. I want to be aligned on the guilabel, etc usage as a team 😄

@hojo-odoo hojo-odoo force-pushed the 16.4-mrp-update-one-two-three-step-hojo branch from 4efc6d2 to 6fe545b Compare December 27, 2023 17:49
@hojo-odoo hojo-odoo requested a review from ksc-odoo December 27, 2023 17:56
ksc-odoo
ksc-odoo approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hojo-odoo Just finished my Peer Review. Awesome work (as always) 👍 Once these minor comments are addressed, this should be ready for the next stage!

@hojo-odoo hojo-odoo force-pushed the 16.4-mrp-update-one-two-three-step-hojo branch from 6fe545b to 055ca18 Compare January 16, 2024 17:46
@hojo-odoo hojo-odoo requested review from a team and ksc-odoo January 16, 2024 17:48
@StraubCreative
Copy link
Contributor

StraubCreative commented Jan 17, 2024

Hi @ksc-odoo please approve or request changes here and I can do final review, thanks!

ksc-odoo
ksc-odoo approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hojo-odoo Great work on this doc. Just a few, super-minor suggestions that need your attention. Once those are done, I think this one can be passed along to @StraubCreative

@hojo-odoo hojo-odoo force-pushed the 16.4-mrp-update-one-two-three-step-hojo branch from 055ca18 to 3b200c9 Compare January 17, 2024 20:39
@hojo-odoo hojo-odoo requested a review from a team January 17, 2024 20:42
samueljlieber
samueljlieber reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo 👋 this is a great PR! I only have a small change on each of the modified files, please see below.

Edit: I misunderstood a previous comment from ZST on "checkbox" vs "check box". Please ignore my comments regarding this. I am updating the Vale linter :)

Also, I think the [IMP] commit tag would be more fitting for this PR since no docs are being added.

Tag me once more after making these edits and I can move this PR forward. Thank you!

Please note there a few uncompressed images listed below that must have been missed in a previous PR. Can you please make a [FIX] pr to compress these all of these in another PR targeting the base branch (16.0 I believe) where these images were introduced?

one_step_manufacturing/start-button.png
two_step_manufacturing/manufacturing-type.png
two_step_manufacturing/start-button.png
two_step_manufacturing/mo-bread-crumb.png
three_step_manufacturing/manufacturing-type.png
three_step_manufacturing/mo-bread-crumb.png

Reminder you can run make review on an image directory to check for compression :)

@hojo-odoo
Copy link
Contributor Author

hojo-odoo commented Jan 18, 2024

@StraubCreative This is ready for merge.

samueljlieber
samueljlieber approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @hojo-odoo 👍

@StraubCreative StraubCreative changed the title [ADD] MRP: Update Manufacturing step docs for Shop Floor [IMP] MRP: Update Manufacturing step docs for Shop Floor Jan 23, 2024
@StraubCreative StraubCreative force-pushed the 16.4-mrp-update-one-two-three-step-hojo branch from 3b200c9 to b461287 Compare January 23, 2024 01:55
@StraubCreative
Copy link
Contributor

StraubCreative commented Jan 23, 2024

b461287: corrected commit tag.

StraubCreative
StraubCreative approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thanks @hojo-odoo

To consider:

  • adjust docs and screenshots in 17.0 as well since the Open Shop Floor button is no longer present.
  • talking to RD or PO regarding the button being missing (was this a feature or a bug?)

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 23, 2024
@StraubCreative
[IMP] MRP: Update Manufacturing step docs for Shop Floor
71a9b4e 
closes #6747

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo robodoo closed this Jan 23, 2024
This was referenced Jan 23, 2024
Closed
Closed
@fw-bot fw-bot mentioned this pull request Jan 23, 2024
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Jan 26, 2024

@hojo-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@Felicious Felicious Felicious approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+1 more reviewer

@ksc-odoo ksc-odoo ksc-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hojo-odoo @robodoo @samueljlieber @StraubCreative @fw-bot @Felicious @ksc-odoo