Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 15, 2024

Several related changes in separate commits:

  • updated spanish translation of Enterprise contract to v10a (Partnership was already up-to-date
  • spellchecking + proper emphasis of some important terms in ES Enterprise contract, e.g. the disambiguation of "Extra Covered Modules" and "Bug" translations
  • removed the "not legally binding" warning in both contracts, as Odoo now has official establishments in countries when Spanish contracts are mandatory and need to be binding. More careful reviews of the Spanish translations will be necessary from now on.
  • special case alt lang links for legal terms: adapts the generation of alternative languages links for each "legal terms page", so that it targets the correct i18n link, or goes back to the EN one, depending on the target language

Forward-Port-Of: #7382

@robodoo
Copy link
Collaborator

robodoo commented Jan 15, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 15, 2024

@odony cherrypicking of pull request #7382 failed.

stderr:

02:31:53.363940 git.c:463               trace: built-in: git cherry-pick 5de20f89bae26227d1009402f1e12cd25f88a24d
error: Cherry-picking is not possible because you have unmerged files.
hint: Fix them up in the work tree, and then use 'git add/rm <file>'
hint: as appropriate to mark resolution and make a commit.
fatal: cherry-pick failed
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

odony added 3 commits January 15, 2024 09:38
Including spellchecking and proper emphasis of some important terms, and
the disambiguation of "Extra Covered Modules" and "Bug"

Removed the "not legally binding" warning, as Odoo now has official
establishments in countries when Spanish contracts are mandatory and
need to be binding. More careful reviews of the Spanish translations
will be necessary from now on.

Part-of: #7382
Removed the "not legally binding" warning, as Odoo now has official
establishments in countries when Spanish contracts are mandatory and
need to be binding. More careful reviews of the Spanish translations
will be necessary from now on.

UPDATE for forward-port: also updated the partnership text to version 11

Part-of: #7382
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
@odony odony force-pushed the saas-15.2-14.0-terms-es-update-4zzE-fw branch from 5277516 to 0376279 Compare January 15, 2024 08:49
@C3POdoo C3POdoo requested review from a team January 15, 2024 08:50
@odony
Copy link
Contributor

odony commented Jan 15, 2024

@robodoo r+ rebase-ff

The saas-15.2 branch had an outdated partnership contract (ES), which explains the conflict. I guess we'll get the conflict in the other direction for the 16.0 branch.

@robodoo
Copy link
Collaborator

robodoo commented Jan 15, 2024

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Jan 15, 2024
Including spellchecking and proper emphasis of some important terms, and
the disambiguation of "Extra Covered Modules" and "Bug"

Removed the "not legally binding" warning, as Odoo now has official
establishments in countries when Spanish contracts are mandatory and
need to be binding. More careful reviews of the Spanish translations
will be necessary from now on.

Part-of: #7384
robodoo pushed a commit that referenced this pull request Jan 15, 2024
Removed the "not legally binding" warning, as Odoo now has official
establishments in countries when Spanish contracts are mandatory and
need to be binding. More careful reviews of the Spanish translations
will be necessary from now on.

UPDATE for forward-port: also updated the partnership text to version 11

Part-of: #7384
robodoo pushed a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
@robodoo robodoo closed this Jan 15, 2024
odony added a commit that referenced this pull request Jan 15, 2024
Including spellchecking and proper emphasis of some important terms, and
the disambiguation of "Extra Covered Modules" and "Bug"

Removed the "not legally binding" warning, as Odoo now has official
establishments in countries when Spanish contracts are mandatory and
need to be binding. More careful reviews of the Spanish translations
will be necessary from now on.

Part-of: #7384
odony added a commit that referenced this pull request Jan 15, 2024
Removed the "not legally binding" warning, as Odoo now has official
establishments in countries when Spanish contracts are mandatory and
need to be binding. More careful reviews of the Spanish translations
will be necessary from now on.

Part-of: #7384
odony added a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
robodoo pushed a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

closes #7387

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
odony added a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

closes #7387

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
odony added a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

closes #7387

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
odony added a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

closes #7387

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
odony added a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

closes #7387

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
odony added a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

closes #7387

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
odony added a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

closes #7387

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
odony added a commit that referenced this pull request Jan 15, 2024
Legal terms live under specific URL as their translations are not
managed in the same manner.

Layout is like this:
  /terms/enterprise.html (EN)
  /terms/i18n/enterprise_fr.html (FR)

This commit adapts the generation of alternative languages links for each
"legal terms page", so that it targets the correct i18n link, or goes
back to the canonical EN one, depending on the target language.

closes #7382

closes #7384

closes #7387

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants