-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[REM] VoIP: Remove Asterisk Documentation #7426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@StraubCreative Set as a priority (high) per Damien. |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @tiku-odoo -- so, this seems like a pretty straightforward PR. Looks like you adequately deleted the necessary Asterisk mentions, per the request you were tagged in. I believe the tag on this PR should be [REM] not [RMV], though. So you may want to change that before moving this to tech review. Also, there's a slight adjustment needed in the 9th line of the axivox.rst that needs your attention. But other than that, I think this is good to go. Let me know if you have any questions. Thanks!
|
@tiku-odoo muchas gracias for your reactivity! |
7a58cf0 to
af318ae
Compare
|
This PR is ready for your review. Simple removal of Asterisk doc |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR @tiku-odoo, the changes look good to me.
I am approving now, and just confirming that I don't believe a redirect rule is necessary for this change since there is not an alternative for this removed doc, see the rule here:
No redirect rule should be created when you delete a source file for which there is no alternative.
@StraubCreative this PR is good to go 👍
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks all!
|
@robodoo r+ |
closes #7426 Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Task per @bouvyd
https://www.odoo.com/web#id=3679018&cids=3&model=project.task&view_type=form