Skip to content

Conversation

@tiku-odoo
Copy link
Contributor

@tiku-odoo tiku-odoo self-assigned this Jan 17, 2024
@tiku-odoo tiku-odoo added the priority Priority lane PRs directly from POs label Jan 17, 2024
@robodoo
Copy link
Collaborator

robodoo commented Jan 17, 2024

@C3POdoo C3POdoo requested a review from a team January 17, 2024 15:33
@tiku-odoo
Copy link
Contributor Author

@StraubCreative
This change is ready for your review. This removes the Asterisk docs from versions 15-17, per Damien.

Set as a priority (high) per Damien.

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @tiku-odoo -- so, this seems like a pretty straightforward PR. Looks like you adequately deleted the necessary Asterisk mentions, per the request you were tagged in. I believe the tag on this PR should be [REM] not [RMV], though. So you may want to change that before moving this to tech review. Also, there's a slight adjustment needed in the 9th line of the axivox.rst that needs your attention. But other than that, I think this is good to go. Let me know if you have any questions. Thanks!

@tiku-odoo tiku-odoo changed the title [RMV] VoIP: Remove Asterisk Documentation [REM] VoIP: Remove Asterisk Documentation Jan 17, 2024
@bouvyd
Copy link
Contributor

bouvyd commented Jan 18, 2024

@tiku-odoo muchas gracias for your reactivity!

@tiku-odoo tiku-odoo force-pushed the 15.0-Productivity-VOIP-Remove-Asterisk-doc-tiku branch from 7a58cf0 to af318ae Compare January 18, 2024 13:03
@tiku-odoo
Copy link
Contributor Author

@samueljlieber

This PR is ready for your review.

Simple removal of Asterisk doc

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR @tiku-odoo, the changes look good to me.

I am approving now, and just confirming that I don't believe a redirect rule is necessary for this change since there is not an alternative for this removed doc, see the rule here:

No redirect rule should be created when you delete a source file for which there is no alternative.

@StraubCreative this PR is good to go 👍

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks all!

@StraubCreative
Copy link
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

15.0 16.0 17.0 priority Priority lane PRs directly from POs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants