Skip to content

Conversation

@ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented Jan 23, 2024

PROJECT TASK: https://www.odoo.com/web#id=3699244&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

Complete update of the Email Marketing doc.
Updated toctree slightly, so the Email Marketing Essentials (formerly Email Marketing) appears beneath the category selection.
Added a link to tutorial on the 'Email Marketing' category page

@ksc-odoo ksc-odoo self-assigned this Jan 23, 2024
@robodoo
Copy link
Collaborator

robodoo commented Jan 23, 2024

@C3POdoo C3POdoo requested a review from a team January 23, 2024 22:15
@ksc-odoo ksc-odoo removed the request for review from a team January 24, 2024 17:16
@ksc-odoo ksc-odoo force-pushed the 17.0-email-marketing-update-essentials-ksc branch 2 times, most recently from efcc8b8 to a25d2c8 Compare January 25, 2024 17:49
@ksc-odoo
Copy link
Contributor Author

@meng-odoo This one is ready for its first round of Peer Review, whenever you get a chance! Thanks! 👍

@ksc-odoo ksc-odoo requested a review from meng-odoo January 25, 2024 17:53
Copy link
Contributor

@meng-odoo meng-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo, great job on this doc, it's very detailed! I had a bunch of tiny wording suggestions/typo fixes for you, then it will be good to go :)

@ksc-odoo ksc-odoo force-pushed the 17.0-email-marketing-update-essentials-ksc branch from a25d2c8 to 1471583 Compare February 14, 2024 17:25
@ksc-odoo
Copy link
Contributor Author

Thanks for the super-detailed feedback, @meng-odoo -- I really appreciate it. 🙏 I made all those suggested edits, and believe this one is now ready for Tech Review from you, @samueljlieber ! Thanks! 👍

@samueljlieber samueljlieber force-pushed the 17.0-email-marketing-update-essentials-ksc branch from 1471583 to a2af7d8 Compare February 14, 2024 20:12
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo, awesome job updating the content of email_marketing.rst. There is a lot of good information here, and I think you covered the content very well. On the technical end of things, the doc looks pretty great! I only have a small handful of corrections, please see below.

Tag me for another look once these are addressed, thank you!

@ksc-odoo ksc-odoo force-pushed the 17.0-email-marketing-update-essentials-ksc branch from a2af7d8 to 758a2f7 Compare February 15, 2024 15:44
@ksc-odoo
Copy link
Contributor Author

Thanks for the always-helpful feedback, @samueljlieber 🙏 I made all the suggested edits, and believe this one is ready for another quick look from you, whenever you get a chance. Thanks! 👍

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo, thank you for implementing my changes. I caught just a few more technical corrections, please see below. Please tag me for one more quick look once these are addressed, thank you!

@ksc-odoo ksc-odoo force-pushed the 17.0-email-marketing-update-essentials-ksc branch from 758a2f7 to a090277 Compare February 15, 2024 21:01
@ksc-odoo
Copy link
Contributor Author

Alrighty @samueljlieber -- i made all those suggested edits. if you could add some clarification re: using a GUI for an app name in the corner of the UI, as opposed to the previously-used italics, that would be super helpful. Thanks! 👍

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ksc-odoo, this PR looks good to me! Nice job on this one!

@StraubCreative this PR is good to go 👍

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo
Very detailed form coverage, I love it!
Going to pause momentarily as I'm catching some high-level details that could use your attention around framing and emoji use. Can you take a look at these please and then tag @samueljlieber again for another review? Thanks!

@ksc-odoo ksc-odoo force-pushed the 17.0-email-marketing-update-essentials-ksc branch from a090277 to 02ed5b5 Compare March 12, 2024 15:40
@ksc-odoo
Copy link
Contributor Author

Thanks for all the super-helpful feedback, @StraubCreative -- made all those suggested edits, and now, believe it's ready for another look. So, @samueljlieber -- this one's ready for ya whenever you get a chance. Thanks!

@ksc-odoo ksc-odoo requested a review from samueljlieber March 12, 2024 15:42
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo! I gave this PR another look and found a few more corrections and suggestions. I am approving now, but please address these before moving the PR along. Other than these points this doc looks great, nice job 🙂

@ksc-odoo ksc-odoo force-pushed the 17.0-email-marketing-update-essentials-ksc branch from 02ed5b5 to 0767ff9 Compare March 29, 2024 22:02
@ksc-odoo
Copy link
Contributor Author

Thanks for the helpful feedback, @samueljlieber -- made all the necessary adjustments, so I think this one is ready for you to officially merge it!

@ksc-odoo ksc-odoo requested a review from samueljlieber March 29, 2024 22:07
@samueljlieber samueljlieber force-pushed the 17.0-email-marketing-update-essentials-ksc branch from 0767ff9 to 474a8bd Compare April 1, 2024 18:45
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ksc-odoo! During my review I quickly resolved a merge conflict in 474a8bd due to the Lost Leads PR that was merged over the weekend. Thank you for implementing my changes, this PR looks good to me! Approving 👍
...
@robodoo r+

@fw-bot
Copy link
Collaborator

fw-bot commented Apr 5, 2024

@ksc-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

@ksc-odoo ksc-odoo added 5 and removed 3 labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants