Skip to content

[IMP] mail: add documentation about the SSL SMTP authentication #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
std-odoo wants to merge 1 commit into from
Closed

[IMP] mail: add documentation about the SSL SMTP authentication #973

std-odoo wants to merge 1 commit into from

Conversation

@std-odoo
Copy link
Contributor

@std-odoo std-odoo commented May 17, 2021

Purpose

Add the documentation about the SSL SMTP authentication
(2 new binary arguments) and also about the new from
filter binary argument.

The goal of those new arguments is to improve the score
of the emails sent by Odoo.

Task 2367946
See odoo/odoo/pull/61853
See odoo/upgrade/pull/1903

@AntoineVDV AntoineVDV marked this pull request as draft May 25, 2021 12:55
@AntoineVDV
Copy link
Collaborator

AntoineVDV commented May 25, 2021

@std-odoo Converted to draft until that odoo/odoo#61853 is merged ;)

@AntoineVDV AntoineVDV added this to the 15.0 milestone May 25, 2021
@std-odoo std-odoo force-pushed the master-mail-2020-std branch from f21845d to 209ae59 Compare June 10, 2021 07:15
@jcs-odoo
Copy link
Contributor

jcs-odoo commented Dec 9, 2021

Hello!
Just checking if this can go forward.

tiku-odoo
tiku-odoo reviewed Apr 21, 2022
View reviewed changes
tiku-odoo
tiku-odoo reviewed Apr 21, 2022
View reviewed changes
tiku-odoo
tiku-odoo suggested changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@tiku-odoo tiku-odoo left a comment •
edited by StraubCreative
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @std-odoo -- a few changes for you to review :) Thanks, Tim

std-odoo
std-odoo commented Apr 25, 2022
View reviewed changes
Copy link
Contributor Author

@std-odoo std-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about from_filter :)

tiku-odoo
tiku-odoo reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @std-odoo -- I've made some changes that should align closer with your from-filter development. Can you take a look? :)

tiku-odoo
tiku-odoo reviewed Jun 1, 2022
View reviewed changes
Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See updates in most current comment. Thanks for your help on this :)

@std-odoo std-odoo force-pushed the master-mail-2020-std branch from 209ae59 to c02a4e2 Compare June 9, 2022 09:58
@robodoo
Copy link
Collaborator

robodoo commented Jun 9, 2022

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

@robodoo
Copy link
Collaborator

robodoo commented Jun 9, 2022

Pull request status dashboard.

@std-odoo std-odoo force-pushed the master-mail-2020-std branch 2 times, most recently from d426a7b to 2d7b056 Compare June 9, 2022 10:02
@std-odoo
Copy link
Contributor Author

std-odoo commented Jun 9, 2022

@tiku-odoo I updated the rst :)

(sorry I didn't noticed it was my old branch, look like we already merged some doc about the SMTP config...)

@tiku-odoo tiku-odoo requested review from a team and mivu-odoo and removed request for mivu-odoo June 9, 2022 15:51
@tiku-odoo
Copy link
Contributor

tiku-odoo commented Jun 15, 2022

@odoo/doc-review When you have a moment can you review this change?

1 similar comment
@tiku-odoo
Copy link
Contributor

tiku-odoo commented Jun 15, 2022

@odoo/doc-review When you have a moment can you review this change?

@Feyensv
Copy link
Collaborator

Feyensv commented Jun 16, 2022

@odoo/doc-review When you have a moment can you review this change?

When a PR is ready for review, just hit the "Ready for review" button and the responsible teams will be automatically pinged ;).

@Feyensv Feyensv marked this pull request as ready for review June 16, 2022 09:20
Feyensv
Feyensv reviewed Jun 16, 2022
View reviewed changes
@std-odoo std-odoo force-pushed the master-mail-2020-std branch from 2d7b056 to 7b97e12 Compare June 22, 2022 06:46
@std-odoo
Copy link
Contributor Author

std-odoo commented Jun 22, 2022

@tiku-odoo Hope it's last changes :)

@std-odoo std-odoo force-pushed the master-mail-2020-std branch from 7b97e12 to 31b0f2a Compare June 22, 2022 06:48
@samueljlieber samueljlieber self-assigned this Aug 24, 2022
@AntoineVDV AntoineVDV removed the request for review from a team August 25, 2022 07:53
tiku-odoo
tiku-odoo approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is good to go. @mivu-odoo Can you give this PR a final review?

mivu-odoo
mivu-odoo suggested changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@mivu-odoo mivu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tiku-odoo and @samueljlieber! Thank you for your hard work on this!

I just reviewed the changed lines. I had small changes on sentence structure and wording. Once these are addressed, I can approve this PR and this can go to technical review. Let me know when you're ready, thank you 😸

@samueljlieber
Copy link
Contributor

samueljlieber commented Aug 26, 2022

Hi @mivu-odoo 👋
I updated the document per your changes, ready for your review!
Thanks :)

cc: @tiku-odoo

mivu-odoo
mivu-odoo approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@mivu-odoo mivu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samueljlieber and @tiku-odoo! This is good to move forward to ZST for final technical review. Thank you for your work on this 😸

StraubCreative
StraubCreative requested changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small changes:

  • start line break earlier on block starting at 295
  • add backticks pre formatting to code-related items.

For later @samueljlieber, let's add a Task to clean up the RST in the whole doc. Quick glance I saw some spots where line breaks + formatting could be cleaned up and we'll want to run tests on links and such just to be sure everything's still kosher 😉

@samueljlieber
Copy link
Contributor

samueljlieber commented Sep 9, 2022

Hi @StraubCreative, I made your suggestions to the document as well as created a task for the future cleanup #2978985 👍

StraubCreative
StraubCreative approved these changes Sep 10, 2022
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
On to @odoo/doc-review for final approval.

@StraubCreative StraubCreative requested a review from a team September 10, 2022 20:09
@std-odoo @Feyensv
[IMP] mail: add documentation about the SSL SMTP authentication
cdbc668 
Purpose
=======
Add the documentation about the SSL SMTP authentication
(2 new binary arguments) and also about the new from
filter binary argument.

The goal of those new arguments is to improve the score
of the emails sent by Odoo.

Task 2367946
See odoo/odoo/pull/61853
See odoo/upgrade/pull/1903
@Feyensv Feyensv changed the base branch from master to 15.0 September 12, 2022 08:50
@Feyensv Feyensv force-pushed the master-mail-2020-std branch from fd28daf to cdbc668 Compare September 12, 2022 08:50
Feyensv
Feyensv approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@Feyensv Feyensv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

retargeted to 15.0, since it's the version where the linked odoo PR was merged.

@robodoo robodoo closed this in 2a01b21 Sep 12, 2022
@fw-bot fw-bot mentioned this pull request Sep 12, 2022
Closed
@robodoo robodoo temporarily deployed to merge September 12, 2022 13:15 Inactive
This was referenced Sep 12, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@Feyensv Feyensv Feyensv approved these changes

+2 more reviewers

@tiku-odoo tiku-odoo tiku-odoo approved these changes

@mivu-odoo mivu-odoo mivu-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samueljlieber samueljlieber

@std-odoo std-odoo

Labels

None yet

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

9 participants

@std-odoo @AntoineVDV @jcs-odoo @robodoo @tiku-odoo @Feyensv @samueljlieber @StraubCreative @mivu-odoo