l10n_fr_fec_import: Accounting FEC import documentation #979

lordkrandel · 2021-05-20T10:58:09Z

Updating the France Fiscal Localization documentation for the task: https://www.odoo.com/web#id=2515785&model=project.task

task-2573140

AntoineVDV · 2021-05-25T12:49:18Z

@lordkrandel Converted to draft until that https://github.com/odoo/enterprise/pull/16704 is merged ;)

A FEC file (Fichier des Ecritures Comptables) contains all the accounting data and entries recorded in all the accounting journals for a financial year. In order to make the onboarding of new users easier, Odoo Enterprise's French fiscal localization includes access to the ``l10n_fr_fec_import`` module, that enables the import of existing FEC files from older software to the Odoo database. The imported data are: * accounts * journals * partners * journal entries Every entity is imported with a generator that reads the values from each line, ready to be loaded. The entity (only accounts for the moment) is then completed with data from the CoA's templates and imported in the database. Journal entries are posted and reconciled. The Odoo branch implements the install checkbox in the Settings > Accounting page for an easy install. Task 2515785: https://www.odoo.com/web#id=2515785model=project.task Documentation PR: odoo/documentation#979

A FEC file (Fichier des Ecritures Comptables) contains all the accounting data and entries recorded in all the accounting journals for a financial year. In order to make the onboarding of new users easier, Odoo Enterprise's French fiscal localization includes access to the ``l10n_fr_fec_import`` module, that enables the import of existing FEC files from older software to the Odoo database. The imported data are: * accounts * journals * partners * journal entries Every entity is imported with a generator that reads the values from each line, ready to be loaded. The entity (only accounts for the moment) is then completed with data from the CoA's templates and imported in the database. Journal entries are posted and reconciled. The Odoo branch implements the install checkbox in the Settings > Accounting page for an easy install. Task 2515785: https://www.odoo.com/web#id=2515785model=project.task Documentation PR: odoo/documentation#979 closes #71290 Related: odoo/enterprise#16704 Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

lordkrandel · 2021-06-15T13:52:58Z

@AntoineVDV odoo/enterprise#16704 is merged ! 👍🏻

AntoineVDV · 2021-06-16T08:08:55Z

I created task 2573140 in the project Documentation to request a proofreading review ;)

jcs-odoo

Hello @lordkrandel !

Thanks for your work :)
I haven't reviewed it fully in-depth yet, but I already post a few comments + the following general comments to apply to the whole doc:

break the line at the 100th character max (see RST guidelines: Start a new line before the 100th character) (excepted for the table, of course :) )
fix the indentations (see RST guidelines: Be consistent with indentation)
prefer using the present tense, rather than future (see Content guidelines: grammatical tenses)

I'll review more in-depth after these changes are done.
Thanks for your work :)

Jonathan

content/applications/finance/accounting/fiscal_localizations/localizations/france.rst

lordkrandel · 2021-06-21T13:30:54Z

I've tried to adapt the PR to what's requested, please check if it fits.

robodoo · 2021-12-10T12:16:05Z

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

robodoo · 2021-12-10T12:16:06Z

Pull request status dashboard.

jcs-odoo

make sure to break the line at the 100th character (see RST guidelines)

I made an additional commit that includes the following suggestions, but not all of them are written here on GitHub.

If you agree with it, then could you please squash all your commits.

Also, use this commit message, or similar, which follows our guidelines

`[IMP] accounting: add FEC import section to l10n/france

task-id 2573140`

My deepest and sincerest apologies for the really long time it took to do this review.

content/applications/finance/accounting/fiscal_localizations/localizations/france.rst

jcs-odoo · 2021-06-29T15:24:49Z

content/applications/finance/accounting/fiscal_localizations/localizations/france.rst

+In order to make the onboarding of new users easier, Odoo Enterprise's French fiscal localization
+includes access to the ``l10n_fr_fec_import`` module, that enables the import of existing FEC files
+from older software.


Improvement suggestion

Suggested change

In order to make the onboarding of new users easier, Odoo Enterprise's French fiscal localization

includes access to the ``l10n_fr_fec_import`` module, that enables the import of existing FEC files

from older software.

To make the onboarding of new users easier, Odoo Enterprise's French :doc:`fiscal localization

<../overview/fiscal_localization_package>` includes the **FEC Import** feature (module name:

``l10n_fr_fec_import``), that enables the import of existing FEC files from older software.

content/applications/finance/accounting/fiscal_localizations/localizations/france.rst

jcs-odoo

I took the liberty to squash the commits.

content/applications/finance/accounting/fiscal_localizations/localizations/france.rst

AntoineVDV · 2021-12-10T13:17:25Z

content/applications/finance/accounting/fiscal_localizations/localizations/france.rst

+   - `Official Technical Specification (fr) <https://www.legifrance.gouv.fr/codes/article_lc/LEGIARTI000027804775>`_
+   - `Test-Compta-Demat (Official FEC Testing tool) <https://github.com/DGFiP/Test-Compta-Demat>`_


Suggested change

- `Official Technical Specification (fr) <https://www.legifrance.gouv.fr/codes/article_lc/LEGIARTI000027804775>`_

- `Test-Compta-Demat (Official FEC Testing tool) <https://github.com/DGFiP/Test-Compta-Demat>`_

- `Official Technical Specification (fr)

<https://www.legifrance.gouv.fr/codes/article_lc/LEGIARTI000027804775>`_

- `Test-Compta-Demat (Official FEC Testing tool)

<https://github.com/DGFiP/Test-Compta-Demat>`_

lordkrandel · 2021-12-15T15:52:17Z

@AntoineVDV @jcs-odoo
I've tried to follow your instructions and also did some improvement here and there.
Can you have another look?

AntoineVDV · 2021-12-16T08:22:03Z

content/applications/finance/accounting/fiscal_localizations/localizations/france.rst

+FEC - Fichier des Écritures Comptables
+======================================
+
+An :dfn:`Fichier des Écritures Comptables` audit file contains all the accounting data and entries


You lost some parts along the way.

Suggested change

An :dfn:`Fichier des Écritures Comptables` audit file contains all the accounting data and entries

An FEC :dfn:`Fichier des Écritures Comptables` audit file contains all the accounting data and entries

Whoops. Mended.

But can I ask why "An FEC audit file" instead of "A FEC audit file"?
"A Fichier des Écritures Comptables" sounds much better to me, but maybe I'm wrong and I'm ignoring some rule 🤔

@jcs-odoo will probably explain that better than me. In the meantime, it's r+'ed!

A and An actually depends on the sound of the sentence, and not the main word.

So indeed, it's A file. But AN "èff-euh-cé" (FEC) file.

Weird, I know ^^

@lordkrandel @AntoineVDV

So indeed "A fichier des écritures comptables", and "AN FEC" because of the letters said out loud.

content/applications/finance/accounting/fiscal_localizations/localizations/france.rst

AntoineVDV

@robodoo r+

robodoo · 2021-12-17T12:00:36Z

Because this PR has multiple commits, I need to know how to merge it:

merge to merge directly, using the PR as merge commit message
rebase-merge to rebase and merge, using the PR as merge commit message
rebase-ff to rebase and fast-forward

lordkrandel · 2021-12-17T12:11:39Z

I'm squashing.

task-id 2573140

lordkrandel · 2021-12-17T12:20:30Z

Squashing done. @jcs-odoo @AntoineVDV
And here is the requested 15.0 port: #1435

AntoineVDV · 2021-12-21T11:08:31Z

@robodoo r+

task-id 2573140 closes #979 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

AntoineVDV marked this pull request as draft May 25, 2021 12:49

AntoineVDV added the content improvement label May 25, 2021

AntoineVDV added this to the 15.0 milestone May 25, 2021

lordkrandel force-pushed the master-account-fec-import-pgi branch from fc130d7 to 7b23c7d Compare May 25, 2021 14:17

lordkrandel mentioned this pull request May 26, 2021

[ADD] l10n_fr_fec_import: added a module for import data from FEC odoo/odoo#71290

Closed

lordkrandel force-pushed the master-account-fec-import-pgi branch from 7b23c7d to 731b1e5 Compare May 28, 2021 08:49

lordkrandel changed the title ~~Account FEC import documentation~~ l10n_fr_fec_import: Accounting FEC import documentation May 28, 2021

lordkrandel marked this pull request as ready for review May 31, 2021 16:14

lordkrandel force-pushed the master-account-fec-import-pgi branch from 731b1e5 to c481c1b Compare June 15, 2021 13:51

jcs-odoo requested changes Jun 17, 2021

View reviewed changes

lordkrandel force-pushed the master-account-fec-import-pgi branch from 9bb0668 to d8b6018 Compare July 13, 2021 23:05

AntoineVDV requested a review from a team December 9, 2021 13:02

jcs-odoo requested changes Dec 10, 2021

View reviewed changes

jcs-odoo force-pushed the master-account-fec-import-pgi branch from 2450d19 to 7b5b187 Compare December 10, 2021 12:39

jcs-odoo approved these changes Dec 10, 2021

View reviewed changes

jcs-odoo requested a review from a team December 10, 2021 12:40

jcs-odoo force-pushed the master-account-fec-import-pgi branch from 7b5b187 to 14ff94b Compare December 10, 2021 12:54

AntoineVDV requested changes Dec 10, 2021

View reviewed changes

lordkrandel force-pushed the master-account-fec-import-pgi branch 8 times, most recently from f4d1403 to b7908cf Compare December 15, 2021 15:49

AntoineVDV requested changes Dec 16, 2021

View reviewed changes

lordkrandel force-pushed the master-account-fec-import-pgi branch from b7908cf to 3f3f113 Compare December 16, 2021 20:41

AntoineVDV approved these changes Dec 17, 2021

View reviewed changes

[IMP] accounting: add FEC import section to l10n/france

6f6589c

task-id 2573140

lordkrandel force-pushed the master-account-fec-import-pgi branch from 3f3f113 to 6f6589c Compare December 17, 2021 12:13

robodoo pushed a commit that referenced this pull request Dec 21, 2021

[IMP] accounting: add FEC import section to l10n/france

b8f59ad

task-id 2573140 closes #979 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

AntoineVDV mentioned this pull request Dec 21, 2021

l10n_fr_fec_import: Accounting FEC import documentation #1435

Closed

robodoo added the 15.2 label Dec 21, 2021

robodoo closed this Dec 21, 2021

robodoo temporarily deployed to merge December 21, 2021 11:13 Inactive

fw-bot deleted the master-account-fec-import-pgi branch January 4, 2022 11:47

		- `Official Technical Specification (fr) <https://www.legifrance.gouv.fr/codes/article_lc/LEGIARTI000027804775>`_
		- `Test-Compta-Demat (Official FEC Testing tool) <https://github.com/DGFiP/Test-Compta-Demat>`_

	An :dfn:`Fichier des Écritures Comptables` audit file contains all the accounting data and entries
	An FEC :dfn:`Fichier des Écritures Comptables` audit file contains all the accounting data and entries

l10n_fr_fec_import: Accounting FEC import documentation #979

l10n_fr_fec_import: Accounting FEC import documentation #979

Uh oh!

Conversation

lordkrandel commented May 20, 2021 • edited by AntoineVDV Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AntoineVDV commented May 25, 2021

Uh oh!

lordkrandel commented Jun 15, 2021

Uh oh!

AntoineVDV commented Jun 16, 2021

Uh oh!

jcs-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lordkrandel commented Jun 21, 2021

Uh oh!

robodoo commented Dec 10, 2021

Uh oh!

robodoo commented Dec 10, 2021

Uh oh!

jcs-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jcs-odoo Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jcs-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AntoineVDV Dec 10, 2021

Choose a reason for hiding this comment

Uh oh!

lordkrandel commented Dec 15, 2021

Uh oh!

AntoineVDV Dec 16, 2021

Choose a reason for hiding this comment

Uh oh!

lordkrandel Dec 16, 2021

Choose a reason for hiding this comment

Uh oh!

AntoineVDV Dec 17, 2021

Choose a reason for hiding this comment

Uh oh!

jcs-odoo Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

jcs-odoo Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AntoineVDV left a comment

Choose a reason for hiding this comment

Uh oh!

robodoo commented Dec 17, 2021

Uh oh!

lordkrandel commented May 20, 2021 •

edited by AntoineVDV

Loading

lordkrandel commented Dec 17, 2021 •

edited

Loading