Skip to content

Conversation

@Florimond
Copy link
Contributor

@Florimond Florimond commented Dec 22, 2020

[FIX] Outlook: prevent displaying same leads multiple times

To reproduce, log in, display the extension with a client that has
at least one opportunity, log out, login again.
The same opportunity is now displayed several times.

Bug reported in the notes of the task 2376540.

[IMP] Outlook: add tooltip on button to log email button

Without a tooltip, it wasn't clear what this button was doing.

Asked in the notes of the task 2376540.

Copy link
Collaborator

@tde-banana-odoo tde-banana-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming here to have a look ... content seems ok for what I can review.

Concerning commit messages, even if we are outside of main odoo repositories, we should follow commit guidelines: application name, a title that should make a valid sentence when concatenated with "if applied, this commit will ..", clear explanation of why we do the change, and PR and task numbers.

Thanks !


<div className='logicon' onClick={() => {this.props.log(lead.id)}}>
{lead.logged ? <FontAwesomeIcon icon={faCheck}/> : <FontAwesomeIcon icon={faReply} flip='horizontal'/>}
{lead.logged ? <FontAwesomeIcon title='Logged!' icon={faCheck}/> : <FontAwesomeIcon title='Log mail in Odoo' icon={faReply} flip='horizontal'/>}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With an "!" ?

@Florimond Florimond force-pushed the fix-various-2376540-fhu branch from b62e69f to fd5a71e Compare January 13, 2021 09:54
To reproduce, log in, display the extension with a client that has
at least one opportunity, log out, login again.
The same opportunity is now displayed several times.

Bug reported in the notes of the task 2376540.
Without a tooltip, it wasn't clear what this button was doing.

Asked in the notes of the task 2376540.
@Florimond Florimond force-pushed the fix-various-2376540-fhu branch from fd5a71e to 4a97a3e Compare January 13, 2021 10:17
tde-banana-odoo pushed a commit that referenced this pull request Jan 14, 2021
To reproduce

  * log in
  * display extension with a client that has at least one opportunity
  * log out, login again;
  -> same opportunity is now displayed several times

This commit fixes that behavior.

Task ID-2376540
PR #2
tde-banana-odoo pushed a commit that referenced this pull request Jan 14, 2021
Purpose is to ease user experience by clearly displaying purpose of available
buttons. Without a tooltip, it wasn't clear what this button was doing.

Task ID-2376540
PR #2
@tde-banana-odoo
Copy link
Collaborator

Merged (see links hereabove). Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants