Fix various 2376540 fhu #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tde-banana-odoo
left a comment
tde-banana-odoo
left a comment
There was a problem hiding this comment.
Coming here to have a look ... content seems ok for what I can review.
Concerning commit messages, even if we are outside of main odoo repositories, we should follow commit guidelines: application name, a title that should make a valid sentence when concatenated with "if applied, this commit will ..", clear explanation of why we do the change, and PR and task numbers.
Thanks !
|
|
||
| <div className='logicon' onClick={() => {this.props.log(lead.id)}}> | ||
| {lead.logged ? <FontAwesomeIcon icon={faCheck}/> : <FontAwesomeIcon icon={faReply} flip='horizontal'/>} | ||
| {lead.logged ? <FontAwesomeIcon title='Logged!' icon={faCheck}/> : <FontAwesomeIcon title='Log mail in Odoo' icon={faReply} flip='horizontal'/>} |
Florimond
force-pushed
the
fix-various-2376540-fhu
branch
from
b62e69f to
fd5a71e
Compare
To reproduce, log in, display the extension with a client that has at least one opportunity, log out, login again. The same opportunity is now displayed several times. Bug reported in the notes of the task 2376540.
Without a tooltip, it wasn't clear what this button was doing. Asked in the notes of the task 2376540.
Florimond
force-pushed
the
fix-various-2376540-fhu
branch
from
fd5a71e to
4a97a3e
Compare
tde-banana-odoo
pushed a commit
that referenced
this pull request
Jan 14, 2021
To reproduce * log in * display extension with a client that has at least one opportunity * log out, login again; -> same opportunity is now displayed several times This commit fixes that behavior. Task ID-2376540 PR #2
tde-banana-odoo
pushed a commit
that referenced
this pull request
Jan 14, 2021
Purpose is to ease user experience by clearly displaying purpose of available buttons. Without a tooltip, it wasn't clear what this button was doing. Task ID-2376540 PR #2
Collaborator
|
Merged (see links hereabove). Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] Outlook: prevent displaying same leads multiple times
To reproduce, log in, display the extension with a client that has
at least one opportunity, log out, login again.
The same opportunity is now displayed several times.
Bug reported in the notes of the task 2376540.
[IMP] Outlook: add tooltip on button to log email button
Without a tooltip, it wasn't clear what this button was doing.
Asked in the notes of the task 2376540.