[FIX] table: "delete table" menu item does not always work

The menu item "delete table" was not working if a table was in the
selection but not on the active cell.

This commit changes it to be consistent with "Edit table", it will now
delete the first table in the selection.

closes #8827

Task: 6247743
X-original-commit: 9d39f5d
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>

Author: hokolomopo

src/actions/menu_items_actions.ts

@@ -631,13 +631,12 @@ export const INSERT_TABLE = (env: SpreadsheetChildEnv) => {
 };
 
 export const DELETE_SELECTED_TABLE = (env: SpreadsheetChildEnv) => {
-  const position = env.model.getters.getActivePosition();
-  const table = env.model.getters.getTable(position);
+  const table = env.model.getters.getFirstTableInSelection();
   if (!table) {
     return;
   }
   env.model.dispatch("REMOVE_TABLE", {
-    sheetId: position.sheetId,
+    sheetId: env.model.getters.getActiveSheetId(),
     target: [table.range.zone],
   });
 };

tests/menus/menu_items_registry.test.ts

@@ -1773,6 +1773,15 @@ describe("Menu Item actions", () => {
         expect(model.getters.getTable({ sheetId, row: 0, col: 0 })).toBeUndefined();
       });
 
+      test("Delete table (cellRegistry) works with a table in the selection but not on the active cell", async () => {
+        createTable(model, "A2:A5");
+        expect(model.getters.getTable({ sheetId, row: 1, col: 0 })).toBeDefined();
+
+        setSelection(model, ["A1:A2"], { anchor: "A1" });
+        await doAction(["delete_table"], env, cellMenuRegistry);
+        expect(model.getters.getTable({ sheetId, row: 1, col: 0 })).toBeUndefined();
+      });
+
       test("Delete table (cellRegistry) on a dynamic table", async () => {
         setCellContent(model, "A1", "=MUNIT(5)");
         createDynamicTable(model, "A1");