[FIX] pivot: unused pivot detection with calculated measure

If a pivot has a calculated measure that refers to a second pivot,
the second pivot is not detected as used. This commit fixes that.

Note: the fix does not fix 100% of the issues. A pivot only referenced
in other places (eg. in a CF rule formula) will still not be
detected as used. But checking every other place the pivot can be
referenced is expensive and error-prone. That may be done in master.

Task: 6105894
X-original-commit: 3ae4353
Part-of: #8739
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>

Author: hokolomopo

src/plugins/ui_core_views/pivot_ui.ts

@@ -20,6 +20,7 @@ import {
   FunctionResultObject,
   PivotCoreMeasure,
   PivotTableCell,
+  RangeCompiledFormula,
   UID,
   UpdatePivotCommand,
   invalidateEvaluationCommands,
@@ -127,14 +128,16 @@ export class PivotUIPlugin extends CoreViewPlugin {
   getPivotIdFromPosition(position: CellPosition) {
     const cell = this.getters.getCorrespondingFormulaCell(position);
     if (cell && cell.isFormula) {
-      const pivotFunction = this.getFirstPivotFunction(
-        position.sheetId,
-        cell.compiledFormula.tokens
-      );
-      if (pivotFunction) {
-        const pivotId = pivotFunction.args[0]?.toString();
-        return pivotId && this.getters.getPivotId(pivotId);
-      }
+      return this.getPivotIdFromFormula(position.sheetId, cell.compiledFormula);
+    }
+    return undefined;
+  }
+
+  private getPivotIdFromFormula(sheetId: UID, formula: RangeCompiledFormula) {
+    const pivotFunction = this.getFirstPivotFunction(sheetId, formula.tokens);
+    if (pivotFunction) {
+      const pivotId = pivotFunction.args[0]?.toString();
+      return pivotId && this.getters.getPivotId(pivotId);
     }
     return undefined;
   }
@@ -325,6 +328,25 @@ export class PivotUIPlugin extends CoreViewPlugin {
         }
       }
     }
+
+    for (const pivotId of this.getters.getPivotIds()) {
+      const pivot = this.getters.getPivot(pivotId);
+      for (const measure of pivot.definition.measures) {
+        if (measure.computedBy) {
+          const { sheetId } = measure.computedBy;
+          const formula = this.getters.getMeasureCompiledFormula(pivotId, measure);
+          const relatedPivotId = this.getPivotIdFromFormula(sheetId, formula);
+          if (relatedPivotId) {
+            unusedPivots.delete(relatedPivotId);
+            if (!unusedPivots.size) {
+              this.unusedPivots = [];
+              return [];
+            }
+          }
+        }
+      }
+    }
+
     this.unusedPivots = [...unusedPivots];
     return this.unusedPivots;
   }

tests/pivots/pivot_plugin.test.ts

@@ -405,4 +405,36 @@ describe("Pivot plugin", () => {
       EMPTY_PIVOT_CELL
     );
   });
+
+  describe("isPivotUnused getter", () => {
+    test("Can use getter to detect unused pivot", () => {
+      const model = createModelWithPivot("A1:I5");
+      setCellContent(model, "A40", "=PIVOT(1)");
+      addPivot(model, "A1:I5", { name: "Unused Pivot" }, "2");
+      expect(model.getters.isPivotUnused("1")).toBe(false);
+      expect(model.getters.isPivotUnused("2")).toBe(true);
+    });
+
+    test("Pivot used in another pivot calculated measure is marked as used", () => {
+      const model = createModelWithPivot("A1:I5");
+      setCellContent(model, "A40", "=PIVOT(1)");
+      addPivot(model, "A1:I5", { name: "Unused Pivot" }, "2");
+      updatePivot(model, "1", {
+        measures: [
+          {
+            id: "Calculated",
+            fieldName: "Calculated",
+            aggregator: "sum",
+            computedBy: {
+              formula: "=PIVOT(2)",
+              sheetId: model.getters.getActiveSheetId(),
+            },
+          },
+        ],
+      });
+
+      expect(model.getters.isPivotUnused("1")).toBe(false);
+      expect(model.getters.isPivotUnused("2")).toBe(false);
+    });
+  });
 });