[FIX] charts: correctly humanize decimal numbers

We have an `humanizeNumbers` option for the chart to make large
numbers more readable. The option is enabled by default on every chart,
but it was not correctly handling decimal numbers. The function
was always rounding them to the nearest integer, which does not make
sense for small numbers (eg. 0.15 should not be displayed as 0).

Task: 5155591
Part-of: #7368
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>

Author: hokolomopo

packages/o-spreadsheet-engine/src/helpers/format/format.ts

@@ -1,4 +1,4 @@
-import { toNumber } from "../../functions/helpers";
+import { toNumber, tryToNumber } from "../../functions/helpers";
 import { _t } from "../../translation";
 import { CellValue } from "../../types/cells";
 import { Currency } from "../../types/currency";
@@ -708,14 +708,18 @@ function _roundFormat<T extends InternalFormat>(internalFormat: T): T {
 }
 
 export function humanizeNumber({ value, format }: FunctionResultObject, locale: Locale): string {
-  const numberFormat = formatLargeNumber(
-    {
-      value,
-      format,
-    },
-    undefined,
-    locale
-  );
+  const numberValue = tryToNumber(value, locale);
+  if (numberValue === undefined) {
+    return "";
+  }
+  let numberFormat: Format | undefined = format;
+  if (Math.abs(numberValue) < 1000) {
+    const hasDecimal = numberValue % 1 !== 0;
+    numberFormat = !format && hasDecimal ? "0.####" : format;
+  } else {
+    numberFormat = formatLargeNumber({ value, format }, undefined, locale);
+  }
+
   return formatValue(value, { format: numberFormat, locale });
 }
 

tests/figures/chart/chart_plugin.test.ts

@@ -3998,12 +3998,12 @@ describe("Can make numbers human-readable", () => {
         "1"
       );
       let axis = getChartConfiguration(model, "1").options.scales.y;
-      const valuesBefore = [1e3, 1e6].map(axis.ticks.callback);
-      expect(valuesBefore).toEqual(["1,000", "1,000,000"]);
+      const valuesBefore = [1e3, 1e6, 0.1, 0.123456789].map(axis.ticks.callback);
+      expect(valuesBefore).toEqual(["1,000", "1,000,000", "0.1", "0.123456789"]);
       updateChart(model, "1", { humanize: true });
       axis = getChartConfiguration(model, "1").options.scales.y;
-      const valuesAfter = [1e3, 1e6].map(axis.ticks.callback);
-      expect(valuesAfter).toEqual(["1,000", "1,000k"]);
+      const valuesAfter = [1e3, 1e6, 0.1, 0.123456789].map(axis.ticks.callback);
+      expect(valuesAfter).toEqual(["1,000", "1,000k", "0.1", "0.1235"]);
     }
   );