[REF] tests: remove chart snapshot tests

There were a dozen chart snapshot tests in `chart_plugin.test.ts`.
Some tests were relying exclusively on snapshots.

The main issue is that snapshots don't actually test a feature.
Reading the test provides no insight on what is actually tested,
and after years of snapshot updates, who's to say that the relevant
part of the snapshot hasn't changed ? Or that the 400 lines of
snapshot for a new test were ever fully reviewed ?

Snapshots shouldn't be the main way a feature is tested. This commit
removes most snapshot tests, and replaces them with more explicit
`expect` matchers.

Some snapshots were kept because a snapshot test is still useful as an
alarm bell for the coder/reviewer (eg. "why has this pie bar fix
changed snapshots of bar charts ?"). But having a dozen snapshot
is pointless, making it more likely that the changes are never
reviewed.

closes #7313

Task: 5160031
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Author: hokolomopo

packages/o-spreadsheet-engine/src/types/chart/bar_chart.ts

@@ -10,7 +10,7 @@ export interface BarChartDefinition extends CommonChartDefinition {
 }
 
 export type BarChartRuntime = {
-  chartJsConfig: ChartConfiguration;
-  masterChartConfig?: ChartConfiguration;
+  chartJsConfig: ChartConfiguration<"bar" | "line">;
+  masterChartConfig?: ChartConfiguration<"bar">;
   background: Color;
 };

packages/o-spreadsheet-engine/src/types/chart/line_chart.ts

@@ -14,7 +14,7 @@ export interface LineChartDefinition extends CommonChartDefinition {
 }
 
 export type LineChartRuntime = {
-  chartJsConfig: ChartConfiguration;
-  masterChartConfig?: ChartConfiguration;
+  chartJsConfig: ChartConfiguration<"line">;
+  masterChartConfig?: ChartConfiguration<"line">;
   background: Color;
 };

src/helpers/figures/charts/bar_chart.ts

@@ -224,7 +224,7 @@ export function createBarChartRuntime(chart: BarChart, getters: Getters): BarCha
   const definition = chart.getDefinition();
   const chartData = getBarChartData(definition, chart.dataSets, chart.labelRange, getters);
 
-  const config: ChartConfiguration = {
+  const config: ChartConfiguration<"bar" | "line"> = {
     type: "bar",
     data: {
       labels: chartData.labels,

src/helpers/figures/charts/runtime/chartjs_scales.ts

@@ -50,8 +50,8 @@ type GeoChartScales = DeepPartial<ScaleChartOptions<"choropleth">["scales"]>;
 export function getBarChartScales(
   definition: GenericDefinition<BarChartDefinition>,
   args: ChartRuntimeGenerationArgs
-): ChartScales {
-  let scales: ChartScales = {};
+): DeepPartial<ScaleChartOptions<"line" | "bar">["scales"]> {
+  let scales: DeepPartial<ScaleChartOptions<"line" | "bar">["scales"]> = {};
   const { trendDataSetsValues: trendDatasets, locale, axisFormats } = args;
   const options = { stacked: definition.stacked, locale: locale };
   if (definition.horizontal) {
@@ -90,12 +90,12 @@ export function getBarChartScales(
 export function getLineChartScales(
   definition: GenericDefinition<LineChartDefinition>,
   args: ChartRuntimeGenerationArgs
-): ChartScales {
+): DeepPartial<ScaleChartOptions<"line">["scales"]> {
   const { locale, axisType, trendDataSetsValues: trendDatasets, labels, axisFormats } = args;
   const labelFormat = axisFormats?.x;
   const stacked = definition.stacked;
 
-  let scales: ChartScales = {
+  let scales: DeepPartial<ScaleChartOptions<"line">["scales"]> = {
     x: getChartAxis(definition, "bottom", "labels", { locale }),
     y: getChartAxis(definition, "left", "values", { locale, stacked, format: axisFormats?.y }),
     y1: getChartAxis(definition, "right", "values", { locale, stacked, format: axisFormats?.y1 }),

src/helpers/figures/charts/scatter_chart.ts

@@ -234,7 +234,7 @@ export function createScatterChartRuntime(
   const definition = chart.getDefinition();
   const chartData = getLineChartData(definition, chart.dataSets, chart.labelRange, getters);
 
-  const config: ChartConfiguration = {
+  const config: ChartConfiguration<"line"> = {
     // use chartJS line chart and disable the lines instead of chartJS scatter chart. This is because the scatter chart
     // have less options than the line chart (it only works with linear labels)
     type: "line",