[FIX] headers_overlay: disable interaction in read-only mode

The drag & drop to move headers, and the handle to resize headers
were both enabled in read-only mode. This commit disable those.

closes #7512

Task: 5182854
X-original-commit: 948c51e
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>

Author: hokolomopo

src/components/headers_overlay/headers_overlay.ts

@@ -150,14 +150,17 @@ abstract class AbstractResizer extends Component<ResizerProps, SpreadsheetChildE
     this.state.waitingForMove = false;
   }
 
-  onMouseMove(ev: PointerEvent) {
-    if (this.env.isMobile()) {
+  onMouseMove(ev: MouseEvent) {
+    if (
+      this.env.isMobile() ||
+      this.env.model.getters.isReadonly() ||
+      this.state.isResizing ||
+      this.state.isMoving ||
+      this.state.isSelecting
+    ) {
       return;
     }
     const zoomedMouseEvent = withZoom(this.env, ev);
-    if (this.state.isResizing || this.state.isMoving || this.state.isSelecting) {
-      return;
-    }
     this._computeHandleDisplay(zoomedMouseEvent);
     this._computeGrabDisplay(zoomedMouseEvent);
   }
@@ -232,6 +235,10 @@ abstract class AbstractResizer extends Component<ResizerProps, SpreadsheetChildE
     if (index < 0) {
       return;
     }
+    if (this.env.model.getters.isReadonly()) {
+      this._selectElement(index, false);
+      return;
+    }
     if (this.state.waitingForMove) {
       if (!this.env.model.getters.isGridSelectionActive()) {
         this._selectElement(index, false);

tests/grid/grid_overlay_component.test.ts

@@ -31,6 +31,7 @@ import {
   click,
   edgeScrollDelay,
   selectColumnByClicking,
+  simulateClick,
   triggerMouseEvent,
 } from "../test_helpers/dom_helper";
 import { getEvaluatedCell, getSelectionAnchorCellXc } from "../test_helpers/getters_helpers";
@@ -656,6 +657,20 @@ describe("Resizer component", () => {
     await nextTick();
     expect(fixture.querySelector(".o-context-menu")).toBeFalsy();
   });
+
+  test("Can open context menu in readonly", async () => {
+    model.updateMode("readonly");
+    triggerMouseEvent(".o-overlay .o-col-resizer", "contextmenu", 10, 10);
+    await nextTick();
+    expect(fixture.querySelector(".o-menu")).toBeTruthy();
+  });
+
+  test("Cannot resize a column in readonly", async () => {
+    model.updateMode("readonly");
+    triggerMouseEvent(".o-overlay .o-col-resizer", "mousemove", DEFAULT_CELL_WIDTH, 10);
+    await nextTick();
+    expect(fixture.querySelector(".o-overlay .o-col-resizer .o-handle")).toBeNull();
+  });
 });
 
 describe("Hide/show columns", () => {
@@ -1116,6 +1131,15 @@ describe("move selected element(s)", () => {
       expect(getEvaluatedCell(model, "C1").value).toBe("c1");
       expect(getEvaluatedCell(model, "D1").value).toBe("d1");
     });
+
+    test("Can select a column but not move it in readonly", async () => {
+      model.updateMode("readonly");
+      await selectColumnByClicking(model, "A", {});
+      expect(model.getters.getActiveCols()).toEqual(new Set([0]));
+
+      await simulateClick(".o-overlay .o-col-resizer", 10, 10);
+      expect(fixture.querySelector(".o-overlay .o-col-resizer")?.classList).not.toContain("o-grab");
+    });
   });
 
   describe("move selected row(s)", () => {