[FIX] auto-complete: hide auto-complete when selecting a cell #4987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
LucasLefevre
force-pushed
the
saas-17.4-click-auto-complete-lul
branch
from
fa79423 to
385302d
Compare
rrahir
reviewed
Sep 17, 2024
src/selection_stream/event_stream.ts
Outdated
| this.observers.set(owner, { owner, callbacks }); | ||
| } | ||
|
|
||
| stopWatching(owner: Owner) { |
LucasLefevre
commented
Oct 21, 2024
Comment on lines
12
to
15
| this.model.selection.observe(this, { | ||
| handleEvent: () => this.hide(), | ||
| }); | ||
| this.onDispose(() => this.model.selection.stopWatching(this)); |
Collaborator
Author
There was a problem hiding this comment.
autocomplete should be independent from the grid selection
LucasLefevre
force-pushed
the
saas-17.4-click-auto-complete-lul
branch
from
385302d to
3d38d6d
Compare
Collaborator
|
Commit message should be reworded, in the end the auto-complete state/store was not moved. And commits should be squashed :) |
LucasLefevre
force-pushed
the
saas-17.4-click-auto-complete-lul
branch
from
2ab30cf to
87015e8
Compare
Steps to reproduce: - Insert a pivot - type in a composer =PIVOT( (the auto-complete should show up with the pivot id) - click on a cell to fill in the reference: you end up with =PIVOT(B3 - press Enter => you get =PIVOT(1B3 instead of the composer being closed Task: 4022927
LucasLefevre
force-pushed
the
saas-17.4-click-auto-complete-lul
branch
from
87015e8 to
58ec76a
Compare
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 31, 2025
Steps to reproduce: - Insert a pivot - type in a composer =PIVOT( (the auto-complete should show up with the pivot id) - click on a cell to fill in the reference: you end up with =PIVOT(B3 - press Enter => you get =PIVOT(1B3 instead of the composer being closed closes #4987 Task: 4022927 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 4022927
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist