[FIX] account: When loading chart template, don't unlink shared records #184450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
antoine162
force-pushed
the
18.0-account-chart-template-loading-do-not-delete-shared-accounts
branch
2 times, most recently
from
5a1b2ba to
275b89d
Compare
antoine162
force-pushed
the
18.0-account-chart-template-loading-do-not-delete-shared-accounts
branch
2 times, most recently
from
41a094e to
8028907
Compare
antoine162
force-pushed
the
18.0-account-chart-template-loading-do-not-delete-shared-accounts
branch
from
8028907 to
aab86cd
Compare
Comment on lines
212
to
215
There was a problem hiding this comment.
Ok if you need the groupby then, but this should work
Suggested change
| for companies_to_unlink, records_for_companies in records_to_keep.grouped(lambda r: r.company_ids & children_companies).items(): | |
| if companies_to_unlink: | |
| # Remove companies from shared records, but don't unlink them | |
| records_for_companies.write({'company_ids': [Command.unlink(c.id) for c in companies_to_unlink]}) | |
| for records_for_companies in records_to_keep.grouped('company_ids').values(): | |
| records_for_companies.company_ids -= children_companies |
There was a problem hiding this comment.
This does work, thanks so much! 😄
When loading a chart template on a root company, we check whether any journal items have already been created for the company, and if not, we delete the existing accounting configuration before loading the new CoA. However, we must take care in the case of records that are shared between several companies, to just unlink them from the active company, rather than delete them (which would affect other companies as well). This commit fixes that. task-none
antoine162
force-pushed
the
18.0-account-chart-template-loading-do-not-delete-shared-accounts
branch
from
aab86cd to
4721f26
Compare
fw-bot
deleted the
18.0-account-chart-template-loading-do-not-delete-shared-accounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a chart template on a root company, we check whether any journal items have already been created for the company, and if not, we delete the existing accounting configuration before loading the new CoA.
However, we must take care in the case of records that are shared between several companies, to just unlink them from the active company, rather than delete them (which would affect other companies as well).
This commit fixes that.
task-none