[REF] l10n_in_*: merge modules #190265
Closed
[REF] l10n_in_*: merge modules #190265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
from
5caf23d to
325e7da
Compare
jva-odoo
requested changes
Dec 12, 2024
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
from
325e7da to
5bd1c4f
Compare
|
Hello, @jva-odoo |
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
4 times, most recently
from
5c8192e to
c21d6ba
Compare
jva-odoo
requested changes
Dec 13, 2024
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
from
c21d6ba to
62ca514
Compare
C3POdoo
requested review from
a team and
hupo-odoo
and removed request for
a team
jco-odoo
reviewed
Dec 13, 2024
|
Not sure why TCS/TDS is checked by default. Maybe we should have a demo TAN as well? (probably the onchange not been triggered (or should we make it compute?)) Also, is there a way to avoid the TAN twice? The split of TCS/TDS is on purpose?
|
Yes, the split between TCS and TDS is intentional, as they can be filed individually. Regarding the TAN field appearing twice, it might be better to display separate TAN fields for TCS and TDS. Also, it will be nice to have TDS/TCS feature available for demo data. I will also add a demo for TAN. |
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
3 times, most recently
from
16b6c96 to
6b380ad
Compare
eapa-odoo
changed the title
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
3 times, most recently
from
b1d2be8 to
a7bd8a5
Compare
hupo-odoo
requested review from
a team and
RicGR98
and removed request for
a team
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
5 times, most recently
from
501b8b8 to
177f8e9
Compare
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
2 times, most recently
from
7071eb1 to
903f243
Compare
|
@robodoo r+ |
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
from
903f243 to
e7216d2
Compare
- Merged the following modules into l10n_in: - l10n_in_gstin_status - l10n_in_withholding task: 3980324
eapa-odoo
force-pushed
the
master-l10n_in-merge-modules-eapa
branch
from
e7216d2 to
8d0007e
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 31, 2025
- Merged the following modules into l10n_in: - l10n_in_gstin_status - l10n_in_withholding closes #190265 Task: 3980324 Related: odoo/enterprise#75451 Related: odoo/upgrade#6931 Signed-off-by: Josse Colpaert (jco) <jco@odoo.com>
eapa-odoo
added a commit
to odoo/documentation
that referenced
this pull request
Feb 11, 2025
Revise the India localization documentation to ensure it aligns with the updated functionality in the master branch. ref: odoo/odoo#190265
eapa-odoo
added a commit
to odoo/documentation
that referenced
this pull request
Feb 14, 2025
Revise the India localization documentation to ensure it aligns with the updated functionality in the master branch. ref: odoo/odoo#190265
eapa-odoo
added a commit
to odoo/documentation
that referenced
this pull request
Feb 18, 2025
Revise the India localization documentation to ensure it aligns with the updated functionality in the master branch. ref: odoo/odoo#190265
eapa-odoo
added a commit
to odoo/documentation
that referenced
this pull request
Feb 20, 2025
Revise the India localization documentation to ensure it aligns with the updated functionality in the master branch. ref: odoo/odoo#190265
eapa-odoo
added a commit
to odoo/documentation
that referenced
this pull request
Feb 25, 2025
Revise the India localization documentation to ensure it aligns with the updated functionality in the master branch. ref: odoo/odoo#190265
robodoo
pushed a commit
to odoo/documentation
that referenced
this pull request
Feb 25, 2025
Revise the India localization documentation to ensure it aligns with the updated functionality in the master branch. closes #12058 Ref: odoo/odoo#190265 Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
shka-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 24, 2025
This error occurs when a user selects `Fiscal Country` to `India` and attempts to configure any `Indian Integration`. Steps to reproduce : 1. Install module `l10n_in`. 2. Create a new company `without assigning a country` and switch on it. 3. In Accounting settings : - Set Fiscal Country to India and Save. - Enable Registered Under GST, enter the GST Number, and Save. ValueError: External ID not found in the system: account.1_sgst_group. This error occurs when the `Fiscal Country` is set to `India` and due to recent merge in module at [1] allows users to fill in sgst_group even when the `Fiscal Localization Package is not set`. As a result, the system cannot find the required sgst_groupID, which is created dynamically when the Fiscal Localization Package is set to India. This commit ensures that if the id does not exist, the function will return None instead of raising an exception. Link [1] : odoo#190265 sentry: 6362946694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
l10n_in:l10n_in_gstin_statusl10n_in_withholdingtask: 3980324
ENT PR: https://github.com/odoo/enterprise/pull/75451
UPGRADE PR: https://github.com/odoo/upgrade/pull/6931