Skip to content

Conversation

@alny-odoo
Copy link
Contributor

Set the correct accounts for expense & income currency exchange accounts

Description of the issue/feature this PR addresses:
task: https://www.odoo.com/odoo/my-tasks/4179478
swap Exchange Difference Gain & Exchange Difference Loss

Current behavior before PR:

  • The exchange difference accounts were wrongly assigned
    Desired behavior after PR is merged:
  • Fix issue by swapping them

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@alny-odoo alny-odoo self-assigned this Dec 16, 2024
@robodoo
Copy link
Contributor

robodoo commented Dec 16, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team and Megaaaaaa and removed request for a team December 16, 2024 12:05
@C3POdoo C3POdoo added the RD research & development, internal work label Dec 16, 2024
@Megaaaaaa Megaaaaaa requested review from SaddemAmine and removed request for Megaaaaaa December 16, 2024 14:56
@Megaaaaaa
Copy link
Contributor

Hello 👋

Sending your PR to the appropriate subteam of accounting 👍

@alny-odoo alny-odoo force-pushed the 16.0-l10n-sa-fix-coa-alny branch from ff69a21 to bb226c9 Compare January 14, 2025 13:20
Set the correct accounts for expense & income currency exchange accounts

previously the reference used was swapped.

task-4179478
@alny-odoo alny-odoo force-pushed the 16.0-l10n-sa-fix-coa-alny branch from bb226c9 to fb2445b Compare January 14, 2025 13:20
SaddemAmine
SaddemAmine approved these changes Feb 3, 2025
@SaddemAmine
Copy link
Contributor

I'm not sure if you'll need to FW this PR but maybe something to keep in mind is that you should make sure this is also consistent with your changes.

Copy link
Contributor

@FlorianGilbert FlorianGilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request Feb 7, 2025
Set the correct accounts for expense & income currency exchange accounts

previously the reference used was swapped.

task-4179478

closes #190704

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
@robodoo robodoo closed this Feb 7, 2025
@fw-bot fw-bot deleted the 16.0-l10n-sa-fix-coa-alny branch February 21, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants