Skip to content

Conversation

@chgo-odoo
Copy link
Contributor

@chgo-odoo chgo-odoo commented Dec 20, 2024

Requires :


Complete list of snippets :
s_attributes_horizontal, s_call_to_action, s_card, s_card_offset, s_card_offset, s_cards_grid, s_cards_soft, s_carousel, s_carousel_cards, s_company_team, s_company_team_basic, s_company_team_detail,
s_company_team_spotlight, s_comparisons, s_cta_card, s_cta_mobile, s_cta_mockups, s_faq_collapse, s_faq_list, s_features, s_features_grid, s_features_wave, s_image_frame, s_image_text_box, s_masonry_block, s_numbers, s_numbers_charts, s_numbers_list, s_showcase, s_table_of_content, s_text_highlight, s_three_columns, s_title

Some snippets in website were using inconsistent heading levels (e.g. h2 directly followed by h6), which harmed both accessibility and SEO. This PR standardizes the heading hierarchy inside snippets to ensure a logical structure.

This improves:

  1. Natural SEO ranking by providing clearer semantic signals to search engines.

  2. Accessibility for screen readers that rely on a consistent heading order.

  3. Overall readability and maintainability of the themes.

Note that the we preserved the design by applying a .h*-fs class that matches the old heading tag in use.

We also fixed selectors inside tests and adapted the new page templates

task-4349019


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Dec 20, 2024

Pull request status dashboard

@C3POdoo C3POdoo added the RD research & development, internal work label Dec 20, 2024
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 2 times, most recently from ed4881b to 9e5e548 Compare December 20, 2024 11:50
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from 9e5e548 to f6eddd8 Compare January 6, 2025 09:45
@chgo-odoo chgo-odoo marked this pull request as ready for review January 6, 2025 09:45
@C3POdoo C3POdoo requested review from a team January 6, 2025 09:47
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from f6eddd8 to 56a7d45 Compare January 6, 2025 10:19
@stefanorigano stefanorigano self-requested a review January 17, 2025 15:17
Copy link
Contributor

@stefanorigano stefanorigano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, design-themes is red.
Don't forget to launch runbot tests on that repo when modifying default snippets ;)

@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from 56a7d45 to f442e15 Compare January 17, 2025 15:21
@chgo-odoo
Copy link
Contributor Author

Oops, thanks @stefanorigano 😬

@chgo-odoo chgo-odoo marked this pull request as draft February 2, 2025 11:10
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 2 times, most recently from b35eb04 to a34c04f Compare February 3, 2025 13:31
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 3 times, most recently from 312c032 to 0b68f9b Compare February 14, 2025 15:12
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 3 times, most recently from b0b138f to 4483736 Compare March 5, 2025 13:36
@lebl-odoo
Copy link

lebl-odoo commented Mar 31, 2025

Just discovered a new tool to list all snippets, it helps a lot, therefore I found new occurrences:

image

image

image

image

image

image

Note : ensure each <section> has at least one title (<hn>)

Opened to the discussion whenever you want

@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 5 times, most recently from 8b3aaf4 to 67dcde5 Compare June 25, 2025 13:05
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from 67dcde5 to 1ba5183 Compare July 2, 2025 08:02
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from 1ba5183 to 628b40f Compare August 18, 2025 13:46
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 3 times, most recently from 289422e to 56eb04e Compare August 19, 2025 11:08
@chgo-odoo chgo-odoo requested a review from lebl-odoo August 19, 2025 11:50
@lebl-odoo
Copy link

@chgo-odoo ,

As discussed on Discord, here is a last occurrence to fix:
image

There is a new snippet, AI that doesn't match our new requirements: h1 is used instead of h2
image

Good luck for the freeze 💪

@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 3 times, most recently from 6fce970 to 84f8a11 Compare August 25, 2025 10:07
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 3 times, most recently from 13f0b69 to 2722625 Compare August 28, 2025 13:51
@chgo-odoo chgo-odoo marked this pull request as ready for review August 28, 2025 13:51
@chgo-odoo chgo-odoo changed the title [IMP] website: fine-tune some snippets headings [IMP] website: fine-tune some snippets headings #191300 Aug 28, 2025
@chgo-odoo chgo-odoo changed the title [IMP] website: fine-tune some snippets headings #191300 [IMP] website: fine-tune some snippets headings Aug 28, 2025
@chgo-odoo chgo-odoo requested a review from qsm-odoo August 28, 2025 13:58
@chgo-odoo
Copy link
Contributor Author

Hello @qsm-odoo 👋

This one is finally ready for review 🙃

Could you please take a look when you have a moment?

Thanks !

Complete list of snippets :
s_attributes_horizontal, s_call_to_action, s_card, s_card_offset,
s_card_offset, s_cards_grid, s_cards_soft, s_carousel, s_carousel_cards,
s_company_team, s_company_team_basic, s_company_team_detail,
s_company_team_spotlight, s_comparisons, s_cta_card, s_cta_mobile,
s_cta_mockups, s_faq_collapse, s_faq_list, s_features, s_features_grid,
s_features_wave, s_image_frame, s_image_text_box, s_masonry_block,
s_numbers, s_numbers_charts, s_numbers_list, s_showcase,
s_table_of_content, s_text_highlight, s_three_columns, s_title

Some snippets in website were using inconsistent heading levels
(e.g. h2 directly followed by h6), which harmed both accessibility and
SEO. This commit standardizes the heading hierarchy inside snippets to
ensure a logical structure.

This improves:

1. Natural SEO ranking by providing clearer semantic signals to search
engines.

2. Accessibility for screen readers that rely on a consistent heading
order.

3. Overall readability and maintainability of the themes.

Note that the we preserved the design by applying a `.h*-fs` class
that matches the old heading tag in use.

We also fixed selectors inside tests and adapted the new page templates

task-4349019
@qsm-odoo qsm-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from 2722625 to 770239e Compare September 8, 2025 10:27
Copy link
Contributor

@qsm-odoo qsm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit to odoo/design-themes that referenced this pull request Sep 8, 2025
* anelusia, artists, avantgarde, aviato, beauty, bewise, bistro,
bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace,
monglia, nano, notes, odoo_experts, orchid, paptic, real estate,
treehouse, vehicle, yes, zap

This commit adapts all the `xpath` expressions inside design themes to
target the new heading tags that were changed within the snippet files.

task-4349019

closes #1043

Related: odoo/odoo#191300
Related: odoo/enterprise#92978
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo pushed a commit that referenced this pull request Sep 8, 2025
Complete list of snippets :
s_attributes_horizontal, s_call_to_action, s_card, s_card_offset,
s_card_offset, s_cards_grid, s_cards_soft, s_carousel, s_carousel_cards,
s_company_team, s_company_team_basic, s_company_team_detail,
s_company_team_spotlight, s_comparisons, s_cta_card, s_cta_mobile,
s_cta_mockups, s_faq_collapse, s_faq_list, s_features, s_features_grid,
s_features_wave, s_image_frame, s_image_text_box, s_masonry_block,
s_numbers, s_numbers_charts, s_numbers_list, s_showcase,
s_table_of_content, s_text_highlight, s_three_columns, s_title

Some snippets in website were using inconsistent heading levels
(e.g. h2 directly followed by h6), which harmed both accessibility and
SEO. This commit standardizes the heading hierarchy inside snippets to
ensure a logical structure.

This improves:

1. Natural SEO ranking by providing clearer semantic signals to search
engines.

2. Accessibility for screen readers that rely on a consistent heading
order.

3. Overall readability and maintainability of the themes.

Note that the we preserved the design by applying a `.h*-fs` class
that matches the old heading tag in use.

We also fixed selectors inside tests and adapted the new page templates

task-4349019

closes #191300

Related: odoo/enterprise#92978
Related: odoo/design-themes#1043
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo pushed a commit to odoo/design-themes that referenced this pull request Sep 8, 2025
* anelusia, artists, avantgarde, aviato, beauty, bewise, bistro,
bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace,
monglia, nano, notes, odoo_experts, orchid, paptic, real estate,
treehouse, vehicle, yes, zap

This commit adapts all the `xpath` expressions inside design themes to
target the new heading tags that were changed within the snippet files.

task-4349019

closes #1043

Related: odoo/odoo#191300
Related: odoo/enterprise#92978
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo robodoo added the 18.5 label Sep 8, 2025
@robodoo robodoo closed this Sep 8, 2025
@qsm-odoo qsm-odoo deleted the master-website-finetune-snippets-heading-chgo branch September 8, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

18.5 RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants