-
Couldn't load subscription status.
- Fork 30.2k
[IMP] website: fine-tune some snippets headings #191300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] website: fine-tune some snippets headings #191300
Conversation
ed4881b to
9e5e548
Compare
9e5e548 to
f6eddd8
Compare
f6eddd8 to
56a7d45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, design-themes is red.
Don't forget to launch runbot tests on that repo when modifying default snippets ;)
56a7d45 to
f442e15
Compare
|
Oops, thanks @stefanorigano 😬 |
b35eb04 to
a34c04f
Compare
312c032 to
0b68f9b
Compare
b0b138f to
4483736
Compare
8b3aaf4 to
67dcde5
Compare
67dcde5 to
1ba5183
Compare
1ba5183 to
628b40f
Compare
289422e to
56eb04e
Compare
6fce970 to
84f8a11
Compare
13f0b69 to
2722625
Compare
|
Hello @qsm-odoo 👋 This one is finally ready for review 🙃 Could you please take a look when you have a moment? Thanks ! |
Complete list of snippets : s_attributes_horizontal, s_call_to_action, s_card, s_card_offset, s_card_offset, s_cards_grid, s_cards_soft, s_carousel, s_carousel_cards, s_company_team, s_company_team_basic, s_company_team_detail, s_company_team_spotlight, s_comparisons, s_cta_card, s_cta_mobile, s_cta_mockups, s_faq_collapse, s_faq_list, s_features, s_features_grid, s_features_wave, s_image_frame, s_image_text_box, s_masonry_block, s_numbers, s_numbers_charts, s_numbers_list, s_showcase, s_table_of_content, s_text_highlight, s_three_columns, s_title Some snippets in website were using inconsistent heading levels (e.g. h2 directly followed by h6), which harmed both accessibility and SEO. This commit standardizes the heading hierarchy inside snippets to ensure a logical structure. This improves: 1. Natural SEO ranking by providing clearer semantic signals to search engines. 2. Accessibility for screen readers that rely on a consistent heading order. 3. Overall readability and maintainability of the themes. Note that the we preserved the design by applying a `.h*-fs` class that matches the old heading tag in use. We also fixed selectors inside tests and adapted the new page templates task-4349019
2722625 to
770239e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
* anelusia, artists, avantgarde, aviato, beauty, bewise, bistro, bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano, notes, odoo_experts, orchid, paptic, real estate, treehouse, vehicle, yes, zap This commit adapts all the `xpath` expressions inside design themes to target the new heading tags that were changed within the snippet files. task-4349019 closes #1043 Related: odoo/odoo#191300 Related: odoo/enterprise#92978 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Complete list of snippets : s_attributes_horizontal, s_call_to_action, s_card, s_card_offset, s_card_offset, s_cards_grid, s_cards_soft, s_carousel, s_carousel_cards, s_company_team, s_company_team_basic, s_company_team_detail, s_company_team_spotlight, s_comparisons, s_cta_card, s_cta_mobile, s_cta_mockups, s_faq_collapse, s_faq_list, s_features, s_features_grid, s_features_wave, s_image_frame, s_image_text_box, s_masonry_block, s_numbers, s_numbers_charts, s_numbers_list, s_showcase, s_table_of_content, s_text_highlight, s_three_columns, s_title Some snippets in website were using inconsistent heading levels (e.g. h2 directly followed by h6), which harmed both accessibility and SEO. This commit standardizes the heading hierarchy inside snippets to ensure a logical structure. This improves: 1. Natural SEO ranking by providing clearer semantic signals to search engines. 2. Accessibility for screen readers that rely on a consistent heading order. 3. Overall readability and maintainability of the themes. Note that the we preserved the design by applying a `.h*-fs` class that matches the old heading tag in use. We also fixed selectors inside tests and adapted the new page templates task-4349019 closes #191300 Related: odoo/enterprise#92978 Related: odoo/design-themes#1043 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
* anelusia, artists, avantgarde, aviato, beauty, bewise, bistro, bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano, notes, odoo_experts, orchid, paptic, real estate, treehouse, vehicle, yes, zap This commit adapts all the `xpath` expressions inside design themes to target the new heading tags that were changed within the snippet files. task-4349019 closes #1043 Related: odoo/odoo#191300 Related: odoo/enterprise#92978 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>








Requires :
Complete list of snippets :
s_attributes_horizontal, s_call_to_action, s_card, s_card_offset, s_card_offset, s_cards_grid, s_cards_soft, s_carousel, s_carousel_cards, s_company_team, s_company_team_basic, s_company_team_detail,
s_company_team_spotlight, s_comparisons, s_cta_card, s_cta_mobile, s_cta_mockups, s_faq_collapse, s_faq_list, s_features, s_features_grid, s_features_wave, s_image_frame, s_image_text_box, s_masonry_block, s_numbers, s_numbers_charts, s_numbers_list, s_showcase, s_table_of_content, s_text_highlight, s_three_columns, s_title
Some snippets in website were using inconsistent heading levels (e.g. h2 directly followed by h6), which harmed both accessibility and SEO. This PR standardizes the heading hierarchy inside snippets to ensure a logical structure.
This improves:
Natural SEO ranking by providing clearer semantic signals to search engines.
Accessibility for screen readers that rely on a consistent heading order.
Overall readability and maintainability of the themes.
Note that the we preserved the design by applying a
.h*-fsclass that matches the old heading tag in use.We also fixed selectors inside tests and adapted the new page templates
task-4349019
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr