[IMP] l10n_my_edi: Various improvements #193497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vin-odoo
force-pushed
the
17.0-myinvois_qr_self_billed-vin
branch
10 times, most recently
from
6532b8a to
48de462
Compare
vin-odoo
changed the title
vin-odoo
force-pushed
the
17.0-myinvois_qr_self_billed-vin
branch
from
48de462 to
027399a
Compare
There was a problem hiding this comment.
Don't forget to remove in 17.2
Brings various needed improvements to the module, either in place or via a new extended module. - Neutralization resets to pre-production - Better handling of errors when generating the file by using the commercial partner as expected. - Align all the flows which update the invoice status to ensure that the data is consistent. - Improve validation for some special cases (lines without products, tax exemption) - Add a new field for Malaysian TIN, mostly for foreign entities. Will be used by default in all flows for MyInvois, with fallback on the Tax ID if empty. - Classification code on invoice line, making the use of products optional. - Rework the views for all fields related to ID on res.partner to align with other similar fields. They will be Readonly on res.partner with a parent id, but displays the value of the commercial partner. - Industrial classification on the partner. - "Full" support of self billing. - Reworked flow to send to MyInvois BEFORE send & print. Which adds support for the QR code generation, and new field to store the QR code long ID. - Send & Print can no longer be used to send invoices to MyInvois after the new module is installed Task-4363294
vin-odoo
force-pushed
the
17.0-myinvois_qr_self_billed-vin
branch
from
027399a to
f73c313
Compare
|
@william-andre Thanks a lot for the review 🤩 Before pushing, I made sure that all my tests were green, and I also manually tested a few invoices/self-billed. Please note that when you think this PR is ready to be merged, there is one on IAP that also needs to be merged into production (it was already approved and has been on the test server for a week, so it's ready for prod). |
william-andre
approved these changes
Jan 24, 2025
|
Upgrade exception #484 added. Waiting the forward-port of this pr, the exception will be applied on all builds, and create an inconsistent state for migrations. PRs adding fields/models should be merged at the beginning of the week and all the forward ports should be merged in the same week. If you need to apply any change before it reaches master, please notify runbot team. Details: |
|
@robodoo r+ |
|
@william-andre you may want to rebuild or fix this PR as it has failed CI. |
|
@vin-odoo @william-andre 'ci/runbot' failed on this reviewed PR. |
|
@robodoo r- delegate+ Waiting for someone from IAP to merge on their side, otherwise potential 💥 |
|
@robodoo r+ Not a high risk if IAP is not ready immediately, but would make it easier to merge the module on our side |
|
@william-andre you may want to rebuild or fix this PR as it has failed CI. |
robodoo
pushed a commit
that referenced
this pull request
Jan 24, 2025
Brings various needed improvements to the module, either in place or via a new extended module. - Neutralization resets to pre-production - Better handling of errors when generating the file by using the commercial partner as expected. - Align all the flows which update the invoice status to ensure that the data is consistent. - Improve validation for some special cases (lines without products, tax exemption) - Add a new field for Malaysian TIN, mostly for foreign entities. Will be used by default in all flows for MyInvois, with fallback on the Tax ID if empty. - Classification code on invoice line, making the use of products optional. - Rework the views for all fields related to ID on res.partner to align with other similar fields. They will be Readonly on res.partner with a parent id, but displays the value of the commercial partner. - Industrial classification on the partner. - "Full" support of self billing. - Reworked flow to send to MyInvois BEFORE send & print. Which adds support for the QR code generation, and new field to store the QR code long ID. - Send & Print can no longer be used to send invoices to MyInvois after the new module is installed Task-4363294 closes #193497 Signed-off-by: William André (wan) <wan@odoo.com>
This was referenced Jan 24, 2025
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 25, 2025
Brings various needed improvements to the module, either in place or via a new extended module. - Neutralization resets to pre-production - Better handling of errors when generating the file by using the commercial partner as expected. - Align all the flows which update the invoice status to ensure that the data is consistent. - Improve validation for some special cases (lines without products, tax exemption) - Add a new field for Malaysian TIN, mostly for foreign entities. Will be used by default in all flows for MyInvois, with fallback on the Tax ID if empty. - Classification code on invoice line, making the use of products optional. - Rework the views for all fields related to ID on res.partner to align with other similar fields. They will be Readonly on res.partner with a parent id, but displays the value of the commercial partner. - Industrial classification on the partner. - "Full" support of self billing. - Reworked flow to send to MyInvois BEFORE send & print. Which adds support for the QR code generation, and new field to store the QR code long ID. - Send & Print can no longer be used to send invoices to MyInvois after the new module is installed Task-4363294 closes odoo#193497 Signed-off-by: William André (wan) <wan@odoo.com>
This was referenced Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings various needed improvements to the module, either in place or
via a new extended module.
as expected.
consistent.
Will be used by default in all flows for MyInvois, with fallback on the Tax ID if empty.
fields. They will be Readonly on res.partner with a parent id, but displays the value of
the commercial partner.
QR code generation, and new field to store the QR code long ID.
module is installed
Task-4363294
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr