[FW][FIX] stock: prioritize routes by sequence in extract_rule #194706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@RicardCForgeFlow @Whenrow cherrypicking of pull request #188846 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
Sort route_ids by sequence within the 'extract_rule' method to ensure rules associated with lower-sequence routes are evaluated first. This resolves issues where higher-sequence routes (e.g., 'manufacture') were selected before lower-sequence routes (e.g., 'buy'). Added a test to ensure _get_rule selects routes based on their sequence, prioritizing lower-sequence routes. This validates that routes are correctly ordered even when assigned in an unsorted manner.
Whenrow
force-pushed
the
saas-17.2-17.0-stock-rule_prioritize_routes_by_sequence-WLpF-fw
branch
from
5c6ff69 to
2b705bc
Compare
|
robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Jan 23, 2025
Sort route_ids by sequence within the 'extract_rule' method to ensure rules associated with lower-sequence routes are evaluated first. This resolves issues where higher-sequence routes (e.g., 'manufacture') were selected before lower-sequence routes (e.g., 'buy'). Added a test to ensure _get_rule selects routes based on their sequence, prioritizing lower-sequence routes. This validates that routes are correctly ordered even when assigned in an unsorted manner. Part-of: #194706 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Jan 23, 2025
closes #194706 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
fw-bot
deleted the
saas-17.2-17.0-stock-rule_prioritize_routes_by_sequence-WLpF-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
When a product is configured with both buy and manufacture routes, the manufacture route is always prioritized, regardless of the sequence defined in the routes.
Current behavior before PR:
The method extract_rule stops evaluating routes once it finds a valid rule, even if other rules with a lower sequence exist. This leads to the manufacture route being prioritized over buy, which is not the intended behavior.
Desired behavior after PR is merged:
The routes are now evaluated based on their sequence, ensuring that rules associated with routes of lower sequence are considered first.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
cc @ForgeFlow
Forward-Port-Of: #188846