-
Notifications
You must be signed in to change notification settings - Fork 30.3k
[FIX] account: uneditable readonly section / note lines #200155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] account: uneditable readonly section / note lines #200155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 👋
I'm okay with the readonly part but I believe we should keep the placeholder. Maybe modify it because it's true that it does not reflect the user's possibilities when the move is posted but removing it causes another issue.
That issue is that the readonly part of the template is used whenever focus is lost on the line meaning also unfocused line in a draft entry. Because of that, section or note lines without text on a draft entry used to look like this:
and look like this now:
Replacing the placeholder by simply "Section" and "Note" feels more appropriate imo. So that it fits both when the user is able of modify it and when he is not. What do you think ?
Currently one can still edit section / note lines on posted moves (but not save the move). This commit makes the section / notes lines readonly when they should be. task: none
7fd2904 to
e224996
Compare
|
Good catch, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, let's get this r+ed 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
Currently one can still edit section / note lines on posted moves (but not save the move). This commit makes the section / notes lines readonly when they should be. closes #200155 Task: none Signed-off-by: Olivier Colson (oco) <oco@odoo.com>




Currently one can still edit section / note lines on posted moves (but not save the move).
This commit makes the section / notes lines readonly when they should be.
task: none