Skip to content

Conversation

@svfu-odoo
Copy link
Contributor

@svfu-odoo svfu-odoo commented Mar 4, 2025

Currently one can still edit section / note lines on posted moves (but not save the move).

This commit makes the section / notes lines readonly when they should be.

task: none

@robodoo
Copy link
Contributor

robodoo commented Mar 4, 2025

Pull request status dashboard

@svfu-odoo svfu-odoo requested review from a team and aboo-odoo and removed request for a team March 4, 2025 12:19
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 4, 2025
@aboo-odoo aboo-odoo requested review from Megaaaaaa and removed request for aboo-odoo March 4, 2025 13:10
Copy link
Contributor

@Megaaaaaa Megaaaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋

I'm okay with the readonly part but I believe we should keep the placeholder. Maybe modify it because it's true that it does not reflect the user's possibilities when the move is posted but removing it causes another issue.

That issue is that the readonly part of the template is used whenever focus is lost on the line meaning also unfocused line in a draft entry. Because of that, section or note lines without text on a draft entry used to look like this:

image

and look like this now:

image

Replacing the placeholder by simply "Section" and "Note" feels more appropriate imo. So that it fits both when the user is able of modify it and when he is not. What do you think ?

image

Currently one can still edit section / note lines on posted moves
(but not save the move).

This commit makes the section / notes lines readonly when
they should be.

task: none
@svfu-odoo svfu-odoo force-pushed the saas-17.4-readonly_note_section_lines-svfu branch from 7fd2904 to e224996 Compare March 4, 2025 14:23
@svfu-odoo
Copy link
Contributor Author

Good catch, thanks
As discussed: I left the palceholder as it is (to not break the translations) and just added the readonly

Copy link
Contributor

@Megaaaaaa Megaaaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's get this r+ed 🚀

@Megaaaaaa Megaaaaaa requested a review from oco-odoo March 4, 2025 16:03
Copy link
Contributor

@oco-odoo oco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request Mar 5, 2025
Currently one can still edit section / note lines on posted moves
(but not save the move).

This commit makes the section / notes lines readonly when
they should be.

closes #200155

Task: none
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
@robodoo robodoo closed this Mar 5, 2025
@xmo-odoo xmo-odoo deleted the saas-17.4-readonly_note_section_lines-svfu branch March 7, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants