Skip to content

Conversation

@pedrobaeza
Copy link
Collaborator

In this version, the picking type code dropship has been introduced to differentiate incoming types from this one (ref: 1547d66), but the search for missing companies without this new type is still being done with the old criteria of the source and target location.

Let's change this to use the new picking type code.

@Tecnativa

In this version, the picking type code `dropship` has been introduced
to differentiate incoming types from this one (ref:
1547d66), but the search for
missing companies without this new type is still being done with the
old criteria of the source and target location.

Let's change this to use the new picking type code.
@robodoo
Copy link
Contributor

robodoo commented Mar 15, 2025

Pull request status dashboard

@pedrobaeza
Copy link
Collaborator Author

@svs-odoo @amoyaux this is a refinement I have seen doing the OpenUpgrade scripts, so I think it's worth to be considered.

@C3POdoo C3POdoo requested review from a team and clesgow and removed request for a team March 15, 2025 11:03
@C3POdoo C3POdoo added the Logistics about stock, mrp, delivery, purchase label Mar 15, 2025
Copy link
Contributor

@clesgow clesgow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
The change looks OK to me, as the linked commit/PR included an upgrade script to apply that code to the old implementations of dropships picking type.

@clesgow
Copy link
Contributor

clesgow commented Apr 25, 2025

Apologies for the delay, guess it's fine as-is then.
@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 25, 2025
In this version, the picking type code `dropship` has been introduced
to differentiate incoming types from this one (ref:
1547d66), but the search for
missing companies without this new type is still being done with the
old criteria of the source and target location.

Let's change this to use the new picking type code.

closes #201968

Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
@robodoo robodoo closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Logistics about stock, mrp, delivery, purchase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants