JUGAC Onboarding

[jugurtha-gaci]

Create the estate module

[robodoo]

[Mathilde411]

Small comments :)

[Mathilde411]

Good work :)
Please look at your runbot and make it green.
Also take a look at the naming conventions: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming

[Mathilde411]

Suggested change

	state = fields.Selection(
	selection=[
	('new', 'New'),
	('received', 'Received'),
	('accepted', 'Accepted')
	]
	)
	state = fields.Selection(
	selection=[
	('new', 'New'),
	('received', 'Received'),
	('accepted', 'Accepted')
	], required=True, default='new'
	)

state should always be set, and new by default

[Mathilde411]

This again

[Mathilde411]

Missing newline

[Mathilde411]

Suggested change

	_description = "Table that stores the estate properties"
	_description = "Estate Property"

_description is the human-readable name of the model, not an actual description. It' a misnomer.

[Mathilde411]

Missing newline

[Mathilde411]

Missing newline

[Mathilde411]

Missing newline

[Mathilde411]

Missing newline

[Mathilde411]

Suggested change

	<list string="Estate offers">
	<group>
	<field name="price"/>
	</group>
	<group>
	<field name="partner_id"/>
	</group>
	<group>
	<field name="status"/>
	</group>
	</list>
	<list string="Estate offers">
	<field name="price"/>
	<field name="partner_id"/>
	<field name="status"/>
	</list>

No groups needed in a list view

[Mathilde411]

Same here, only one group needed

[Mathilde411]

Did you test everything ? Ifeel like some parts would outright not work at all.
Good work overall though. :)

[Mathilde411]

Suggested change

	from . import users
	from . import res_users

Model name is res.users, so here the file name should be res_users.py

[Mathilde411]

What happens here if I put False in date_deadline ? date_deadline is not required

[Mathilde411]

Suggested change

	def action_refuse(self):
	for record in self:
	record.status = 'refused'
	return True
	def action_refuse(self):
	record.status = 'refused'
	return True

This works

[Mathilde411]

Suggested change

	@api.model
	def create(self, vals_list):
	for offer in self:
	if offer.price > vals_list.price:
	raise UserError('The offer price should be greater than those already received')
	res = super().create(vals_list)
	if res.property_id.state != 'received':
	res.property_id.state = 'received'
	return res
	@api.model_create_multi
	def create(self, vals_list):
	for offer in self:
	if offer.price > vals_list.price:
	raise UserError('The offer price should be greater than those already received')
	res = super().create(vals_list)
	if res.property_id.state != 'received':
	res.property_id.state = 'received'
	return res

Did you test this ? vals_list should be a List[Dict[str, Any]], so this wouldn't work.
To make sure mark it as model_create_multi. it makes sure that vals_list is always that.

[Mathilde411]

This again

[Mathilde411]

Suggested change

	def action_set_sold(self):
	for record in self:
	if record.state == 'canceled':
	raise UserError('A canceled property cannot be sold')
	else:
	record.state = 'sold'
	return True
	def action_set_sold(self):
	for record in self:
	if record.state == 'canceled':
	raise UserError('A canceled property cannot be sold')
	record.state = 'sold'
	return True

else not needed here. The exception will break the flow anyways

[Mathilde411]

Suggested change

	def action_set_canceled(self):
	for record in self:
	if record.state == 'sold':
	raise UserError('A sold property cannot be canceled')
	else:
	record.state = 'canceled'
	return True
	def action_set_canceled(self):
	for record in self:
	if record.state == 'sold':
	raise UserError('A sold property cannot be canceled')
	record.state = 'canceled'
	return True

ditto

[Mathilde411]

Suggested change

	@api.constrains('selling_price')
	def _check_selling_price(self):
	for record in self:
	if record.state in ("new", "received"):
	return
	if float_compare(record.selling_price, (record.expected_price * 0.9), 2) < 0:
	raise ValidationError("The selling price cannot be lower than 90%% of the expected price")
	if float_is_zero(record.selling_price, 2):
	raise ValidationError("The selling price should be positive")
	@api.constrains('selling_price')
	def _check_selling_price(self):
	for record in self.filtered(lambda p: p.state not in ("new", "received")):
	if float_compare(record.selling_price, (record.expected_price * 0.9), 2) < 0:
	raise ValidationError("The selling price cannot be lower than 90%% of the expected price")
	if float_is_zero(record.selling_price, 2):
	raise ValidationError("The selling price should be positive")

This is more odooesque

[Mathilde411]

What are you trying to do here ?