[ADD] estate: created a new module #1021

hapat-odoo · 2025-11-05T07:01:26Z

Created and configured the database for the Real Estate module, defining necessary fields such as property type, tags, buyer, salesperson, and offers. Implemented list, form, and search views with groupings, and added computed fields, inverse functions, and onchange functionalities. Included 'Sold' and 'Cancel' buttons with their corresponding functionality, as well as 'Accept' and 'Refuse' buttons with related logic.

Added a new module for estate property and completed tasks 1, 2, and 3. I added a models folder and learned to push data into PostgreSQL using ORM.

Enhanced the Security Logic for improved protection. Added the access control rights for the estate_property.py file

robodoo · 2025-11-05T07:01:30Z

bit-odoo

Hello, Good Work!
I have left some comments.

For commit message you can refer this documentation :- https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html#commit-message-full-description

bit-odoo · 2025-11-07T08:42:21Z

Estate/models/estate_property.py

@@ -0,0 +1,40 @@
+


unnecessary diff.

bit-odoo · 2025-11-07T08:45:20Z

Estate/models/estate_property.py

+        copy=False,
+        default='new'
+    )
+


An empty line should be without whitespace.

bit-odoo · 2025-11-07T08:45:43Z

Estate/views/estate_menus.xml

+              name="List"
+              parent="estate_property_menu"
+              action="action_estate_property_list_only"/>
+


unnecessary diff.

bit-odoo · 2025-11-07T09:02:20Z

Estate/views/estate_menus.xml

+    <menuitem id="estate_property_list_menu"
+              name="List"
+              parent="estate_property_menu"
+              action="action_estate_property_list_only"/>


Suggested change

<menuitem id="estate_property_list_menu"

name="List"

parent="estate_property_menu"

action="action_estate_property_list_only"/>

<menuitem id="estate_property_list_menu"

name="List"

parent="estate_property_menu"

action="action_estate_property_list_only"/>

bit-odoo · 2025-11-07T09:03:37Z

Estate/views/estate_property_views.xml

+        <field name="view_id" ref="estate_property_form_view"/>
+    </record>
+
+


unnecessary diff.

bit-odoo · 2025-11-07T09:04:05Z

Estate/views/estate_property_views.xml

+                <separator/>
+                <filter name="group_by_postcode"
+                        string="Group by Postcode"
+                        context="{'group_by': 'postcode'}"/>


Please check indentation.

bit-odoo · 2025-11-07T11:16:41Z

Estate/views/estate_menus.xml

+    <menuitem id="estate_advertisement_menu"
+              name="Advertisements"
+              parent="estate_root_menu"/>
+    <menuitem id="estate_property_menu"
+              name="Properties"
+              parent="estate_advertisement_menu"
+              action="action_estate_property"/>


Same as below.

bit-odoo

Hello!
I have made another round of review
As we discussed early, can you please update your commit message title and please update your PR title and message?

bit-odoo · 2025-11-11T09:02:30Z

Estate/models/estate_property.py

+from odoo import models, fields, api
+from datetime import timedelta


Suggested change

from odoo import models, fields, api

from datetime import timedelta

from datetime import timedelta

from odoo import models, fields, api

bit-odoo · 2025-11-11T09:03:00Z

Estate/models/estate_property.py

+        ("west", "West"),
+    ])
+    active = fields.Boolean(default=True)
+


unnecessary diff.

bit-odoo · 2025-11-11T09:03:07Z

Estate/models/estate_property.py

+        ("sold", "Sold"),
+        ("canceled", "Canceled"),
+    ], string="Status", required=True, copy=False, default="new")
+


unnecessary diff.

bit-odoo · 2025-11-11T09:03:18Z

Estate/models/estate_property.py

+    salesperson_id = fields.Many2one("res.users", string="Salesperson")
+    tag_ids = fields.Many2many("estate.property.tag", string="Tags")
+    offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
+


bit-odoo · 2025-11-12T06:38:09Z

Estate/models/estate_property.py

+    _check_expected_price = models.Constraint(
+        'CHECK(expected_price < 0)',
+        'The expected price of a property must be strictly positive.'
+    )
+
+    _check_selling_price = models.Constraint(
+        'CHECK(selling_price < 0)',
+        'The selling price of a property must be positive.'
+    )


Constraints should be defined after the field declaration. And is this your condition going to work properly ?. Have you checked it?

bit-odoo · 2025-11-12T06:40:45Z

Estate/views/estate_property_views.xml

+                <header>
+                    <button name="action_set_next_status" string="Next" type="object"/>
+                    <button name="action_back_to_new" string="Reset to New" type="object"/>
+                    <button name="action_set_sold" string="Mark as Sold" type="object"/>
+                    <button name="action_set_canceled" string="Cancel" type="object"/>
+                    <field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold,canceled"/>
+                </header>


should be outside of the sheet for better visibility. You can take reference from other Odoo apps.

bit-odoo · 2025-11-12T06:50:06Z

Estate/models/estate_property.py

+            if  record.selling_price < 0.9 * record.expected_price:
+                raise ValidationError("Selling price must be at least 90% of the expected price")
+            if record.expected_price < 0:
+                raise ValidationError("Expected price must be greater than 0")


We already have constrain, so do we need it here?

bit-odoo · 2025-11-12T07:59:25Z

Estate/models/estate_property_type.py

+    _check_type_name_unique_ratio = models.Constraint(
+        'CHECK(name)',
+        'The property name must be unique.'
+    )


Should be one empty line at the end of the file.

bit-odoo

Hello,
I think you have to adapt the changes that i suggest you. I have to make comment multiple times it is not good.

bit-odoo · 2025-11-14T06:43:54Z

Estate/models/estate_property.py

+    garden_area = fields.Integer()
+    garden_orientation = fields.Selection([("north", "North"),("south", "South"),("east", "East"),("west", "West"),])
+    active = fields.Boolean(default=True)
+    state = fields.Selection([("new", "New"),("offer_received", "Offer Received"),("offer_accepted", "Offer Accepted"),("sold", "Sold"),("canceled", "Canceled")], required=True, copy=False , )


Suggested change

state = fields.Selection([("new", "New"),("offer_received", "Offer Received"),("offer_accepted", "Offer Accepted"),("sold", "Sold"),("canceled", "Canceled")], required=True, copy=False , )

state = fields.Selection(

[

("new", "New"),

("offer_received", "Offer Received"),

("offer_accepted", "Offer Accepted"),

("sold", "Sold"),

("canceled", "Canceled")

], required=True, copy=False)

For better readability.

bit-odoo · 2025-11-14T06:44:45Z

Estate/models/estate_property.py

+    total_area = fields.Float(compute="_compute_total_area", string="Total Area", store=True)
+    best_price = fields.Float(compute="_compute_best_price", string="Best Offer", store=True)
+    validity_days = fields.Integer(default=7)
+    date_deadline = fields.Date(compute="_compute_date_deadline",inverse="_inverse_date_deadline",store=True,)


Suggested change

date_deadline = fields.Date(compute="_compute_date_deadline",inverse="_inverse_date_deadline",store=True,)

date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline", store=True,)

bit-odoo · 2025-11-14T06:51:05Z

Estate/models/estate_property.py

+    _check_price = models.Constraint(
+        'CHECK(expected_price > 0 AND selling_price >= 0)',
+        'The expected price of a property must be strictly positive.'
+    )


EOL missing.

bit-odoo · 2025-11-14T06:52:32Z

Estate/views/estate_property_views.xml

+    <field name="arch" type="xml">
+        <form string="Property">
+            <header>
+                <button name="action_set_next_status" string="Next" type="object"/>


I do not think that this button is necessary. As a user can not change the state manually every time.

bit-odoo · 2025-11-14T06:58:10Z

Estate/models/estate_property.py

+                raise ValidationError("You cannot delete a new or canceled property.")
+        return super().unlink()
+
+    _check_price = models.Constraint(


It should be after field declaration, as I mentioned in the earlier comment.

bit-odoo · 2025-11-14T06:58:30Z

Estate/models/estate_property_type.py

+        'CHECK(name)',
+        'The property name must be unique.'
+    )
+


EOL missing.

bit-odoo · 2025-11-14T06:58:40Z

Estate/views/estate_property_offer_views.xml

+            </form>
+        </field>
+    </record>
+</odoo>


EOL missing.

bit-odoo · 2025-11-14T06:58:51Z

Estate/views/estate_property_views.xml

+    </record>
+
+
+</odoo>


EOL missing.

bit-odoo · 2025-11-14T06:58:56Z

Estate/views/res_users_view.xml

+          <field name="view_mode">form</field>
+          <field name="view_id" ref="view_users_form_inherit_properties"/>
+    </record>
+</odoo>


EOL missing.

Introduced a new menu structure for the estate module, including a root menu and submenus for properties. Also added an action for managing estate properties with a corresponding view mode.

-added search view state field and list and form views [IMP] estate: Added list & form view -added filter for new or offer received stage [IMP] estate: Implemented models and views for property offers -added models and views for property offers field

… and types Implemented models and views for property offers tags and types

Enhanced property model and views with new fields and improved form layout

Implemented offer acceptance and refusal actions; added state management buttons in property views [FIX] estate: resolve Runbot style and linting errors (Ruff/Semgrep) This commit fixes all Runbot Check Style issues for the estate module. [FIX] estate: Cleaned up code by removing unnecessary blank lines in model files

-Refactored validity field to validity_days -added constraints for price validation

-Implemented inline views and widgets to enhance the user interface within the Real Estate module. -Introduced list-ordering functionality to improve the organization and sorting of listings. -Added attribute and option configurations to increase customization capabilities and overall flexibility for users.

-implemented inheritance in models,views -implemented some ui changes

hapat-odoo added 2 commits October 31, 2025 11:32

[ADD] estate: Added a New Module estate_property

4da5a7b

Added a new module for estate property and completed tasks 1, 2, and 3. I added a models folder and learned to push data into PostgreSQL using ORM.

[IMP] estate: Implemented the Security Logic

e5c07e0

Enhanced the Security Logic for improved protection. Added the access control rights for the estate_property.py file

bit-odoo reviewed Nov 7, 2025

View reviewed changes

hapat-odoo force-pushed the 19.0-tutorial-hapat branch from 7f2ef3d to d4f129f Compare November 11, 2025 06:30

bit-odoo reviewed Nov 12, 2025

View reviewed changes

bit-odoo reviewed Nov 14, 2025

View reviewed changes

[IMP] estate: Added menu structure and property action

8c2f328

Introduced a new menu structure for the estate module, including a root menu and submenus for properties. Also added an action for managing estate properties with a corresponding view mode.

hapat-odoo changed the title ~~19.0 tutorial hapat~~ [ADD] estate: created a new module Nov 14, 2025

hapat-odoo force-pushed the 19.0-tutorial-hapat branch from 5efbebc to a17e115 Compare November 14, 2025 07:41

hapat-odoo added 8 commits November 14, 2025 13:15

[IMP] estate: menu structure and added property views

d958304

[IMP] estate: Implemented models and views for property offers, tags,…

c9b3913

… and types Implemented models and views for property offers tags and types

[IMP] estate: added automation logic

b473952

Enhanced property model and views with new fields and improved form layout

[IMP] estate: Implemented constraints for price validation

7a6c138

-Refactored validity field to validity_days -added constraints for price validation

[IMP] estate: Implemented inheritance logic

2343bb9

-implemented inheritance in models,views -implemented some ui changes

hapat-odoo force-pushed the 19.0-tutorial-hapat branch from 5c1626e to 2343bb9 Compare November 14, 2025 07:46

		<field name="view_id" ref="estate_property_form_view"/>
		</record>

		from odoo import models, fields, api
		from datetime import timedelta

	date_deadline = fields.Date(compute="_compute_date_deadline",inverse="_inverse_date_deadline",store=True,)
	date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline", store=True,)

[ADD] estate: created a new module #1021

Are you sure you want to change the base?

[ADD] estate: created a new module #1021

Uh oh!

Conversation

hapat-odoo commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Nov 5, 2025

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hapat-odoo commented Nov 5, 2025 •

edited

Loading

bit-odoo left a comment •

edited

Loading