FRBIN Onboarding #992
Open
FRBIN Onboarding #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mathilde411
reviewed
Oct 20, 2025
frbin-odoo
force-pushed
the
19.0-onboarding-frbin
branch
from
d52fe86 to
2e5e338
Compare
Mathilde411
requested changes
Oct 20, 2025
Mathilde411
requested changes
Oct 21, 2025
There was a problem hiding this comment.
As a more general comment take a look at the naming conventions for files and xmlids: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html
Good work :D
Mathilde411
requested changes
Oct 23, 2025
|
@frbin-odoo Can yoiu please squash everything so that there is only 1 commit per chapter ? |
frbin-odoo
force-pushed
the
19.0-onboarding-frbin
branch
from
5528587 to
e600ae2
Compare
frbin-odoo
force-pushed
the
19.0-onboarding-frbin
branch
from
e600ae2 to
9cecea0
Compare
Mathilde411
requested changes
Oct 24, 2025
frbin-odoo
force-pushed
the
19.0-onboarding-frbin
branch
from
8d6c1ec to
f89bbbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.