[FIX] util/snippets: correctly quote table/column in query #17
Conversation
|
upgradeci retry with always website* in versions 13.0 14.0 15.0 |
|
LGTM by itself. What about the other uses of quote_ident in this file? E.g. I find it counter-intuitive that upgrade-util/src/util/snippets.py Line 89 in 13289de table unquoted and column quoted, while other "getters" in the utils (like table_of_model) do not quote at all. We should consistently quote identifiers at time of use in a query, otherwise it will get confusing and hard to use.Just my 2¢. |
I agree, we'd be moving it to a better standard way in subsequent patches when needed. I don't want to do a big refactoring just for that. |
|
upgradeci retry with always only base mass_mailing test_themes theme_common web web_editor website website_blog website_event website_mass_mailing website_sale in 14.0 15.0 16.0 17.0 |
aj-fuentes
force-pushed
the
master-fix_quote_query-afu
branch
from
13289de to
023ab70
Compare
One literal column was present which caused issues with uppercase named columns. Redo the quoting with better tools from psycopg2. upg-1180733
aj-fuentes
force-pushed
the
master-fix_quote_query-afu
branch
from
023ab70 to
32ed137
Compare
|
@KangOl this is finally correct. Also good in the test with the upgrade request. |
|
upgradeci retry |
|
@KangOl good to go? |
|
@robodoo r+ |
4 participants
One literal column was present which caused issues with uppercase named
columns. Redo the quoting with better tools from psycopg2.