[FIX] util/modules: fix wrong usage of warnings filtering #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
Author
Contributor
Author
|
upgradeci retry with always theme_* |
Contributor
Author
|
upgradeci retry with always theme_* in all versions |
aj-fuentes
force-pushed
the
master-fix_typo-afu
branch
2 times, most recently
from
e520f98 to
d95f37f
Compare
aj-fuentes
changed the title
It's `catch_warnings` not `catchwarnings` https://docs.python.org/2/library/warnings.html#warnings.catch_warnings https://docs.python.org/3/library/warnings.html#warnings.catch_warnings The context manager is meant to allow for specific filters that would be reverted once it exists. This patch corrects the usage. Oversight of fbd0b4f
aj-fuentes
force-pushed
the
master-fix_typo-afu
branch
from
d95f37f to
42e4c4a
Compare
Contributor
Author
Contributor
Author
|
@robodoo priority |
robodoo
pushed a commit
that referenced
this pull request
Oct 17, 2025
It's `catch_warnings` not `catchwarnings` https://docs.python.org/2/library/warnings.html#warnings.catch_warnings https://docs.python.org/3/library/warnings.html#warnings.catch_warnings The context manager is meant to allow for specific filters that would be reverted once it exists. This patch corrects the usage. Oversight of fbd0b4f closes #342 Signed-off-by: Alvaro Fuentes Suarez (afu) <afu@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Oct 17, 2025
It's `catch_warnings` not `catchwarnings` https://docs.python.org/2/library/warnings.html#warnings.catch_warnings https://docs.python.org/3/library/warnings.html#warnings.catch_warnings The context manager is meant to allow for specific filters that would be reverted once it exists. This patch corrects the usage. Oversight of fbd0b4f closes #342 Signed-off-by: Alvaro Fuentes Suarez (afu) <afu@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's
catch_warningsnotcatchwarningshttps://docs.python.org/2/library/warnings.html#warnings.catch_warnings
https://docs.python.org/3/library/warnings.html#warnings.catch_warnings
The context manager is meant to allow for specific filters that would be
reverted once it exists. This patch corrects the usage.
Oversight of odoo-dev@fbd0b4f