[FIX] util/records: avoid row-based IS NOT NULL
#361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While using row-based `IS {,NOT} NULL`, especially after doing
LEFT JOIN we need to be very carefull as:
1. IS NULL = true if the `row is NULL OR all columns are NULL`[^1]
2. IS NOT NULL = true if the `row is NOT NULL AND all columns are NOT
NULL`[^1]
So for making it safe, we used `t2.<column> IS NOT NULL` instead
of `t2 IS NOT NULL` when the <column> was used while joining
ref: odoo/upgrade#8957
[^1]: https://www.postgresql.org/docs/12/functions-comparison.html
Contributor
|
|
aj-fuentes
approved these changes
Dec 1, 2025
Contributor
|
upgradeci retry with always only account crm hr project |
KangOl
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using row-based
IS {,NOT} NULL, especially after doing LEFT JOIN we need to be very carefull as:row is NULL OR all columns are NULL1row is NOT NULL AND all columns are NOT NULL1So for making it safe, we used
t2.<column> IS NOT NULLinstead oft2 IS NOT NULLwhen the was used while joiningref: https://github.com/odoo/upgrade/pull/8957
Footnotes
https://www.postgresql.org/docs/12/functions-comparison.html ↩ ↩2